From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amelie DELAUNAY Subject: Re: [PATCH v5 2/9] mfd: Add ST Multi-Function eXpander (STMFX) core driver Date: Wed, 8 May 2019 14:44:10 +0000 Message-ID: <697597b2-088d-9ffb-54bd-e50b3ca8c012@st.com> References: <1554794651-6874-1-git-send-email-amelie.delaunay@st.com> <1554794651-6874-3-git-send-email-amelie.delaunay@st.com> <20190508083622.GE3995@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190508083622.GE3995@dell> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones Cc: Linus Walleij , Rob Herring , Mark Rutland , Alexandre TORGUE , Maxime Coquelin , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-stm32@st-md-mailman.stormreply.com" List-Id: linux-gpio@vger.kernel.org T24gNS84LzE5IDEwOjM2IEFNLCBMZWUgSm9uZXMgd3JvdGU6DQo+IE9uIFR1ZSwgMDkgQXByIDIw MTksIEFtZWxpZSBEZWxhdW5heSB3cm90ZToNCj4gDQo+PiBTVE1pY3JvZWxlY3Ryb25pY3MgTXVs dGktRnVuY3Rpb24gZVhwYW5kZXIgKFNUTUZYKSBpcyBhIHNsYXZlIGNvbnRyb2xsZXINCj4+IHVz aW5nIEkyQyBmb3IgY29tbXVuaWNhdGlvbiB3aXRoIHRoZSBtYWluIE1DVS4gTWFpbiBmZWF0dXJl cyBhcmU6DQo+PiAtIDE2IGZhc3QgR1BJT3MgaW5kaXZpZHVhbGx5IGNvbmZpZ3VyYWJsZSBpbiBp bnB1dC9vdXRwdXQNCj4+IC0gOCBhbHRlcm5hdGUgR1BJT3MgaW5kaXZpZHVhbGx5IGNvbmZpZ3Vy YWJsZSBpbiBpbnB1dC9vdXRwdXQgd2hlbiBvdGhlcg0KPj4gU1RNRlggZnVuY3Rpb25zIGFyZSBu b3QgdXNlZA0KPj4gLSBNYWluIE1DVSBJREQgbWVhc3VyZW1lbnQNCj4+IC0gUmVzaXN0aXZlIHRv dWNoc2NyZWVuIGNvbnRyb2xsZXINCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBBbWVsaWUgRGVsYXVu YXkgPGFtZWxpZS5kZWxhdW5heUBzdC5jb20+DQo+PiAtLS0NCj4+ICAgZHJpdmVycy9tZmQvS2Nv bmZpZyAgICAgICB8ICAxMyArKw0KPj4gICBkcml2ZXJzL21mZC9NYWtlZmlsZSAgICAgIHwgICAy ICstDQo+PiAgIGRyaXZlcnMvbWZkL3N0bWZ4LmMgICAgICAgfCA1NjYgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4gICBpbmNsdWRlL2xpbnV4L21mZC9z dG1meC5oIHwgMTIzICsrKysrKysrKysNCj4+ICAgNCBmaWxlcyBjaGFuZ2VkLCA3MDMgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9t ZmQvc3RtZnguYw0KPj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9saW51eC9tZmQvc3Rt ZnguaA0KPj4NCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9LY29uZmlnIGIvZHJpdmVycy9t ZmQvS2NvbmZpZw0KPj4gaW5kZXggMzQ0M2YxYS4uOTc4M2UxOCAxMDA2NDQNCj4+IC0tLSBhL2Ry aXZlcnMvbWZkL0tjb25maWcNCj4+ICsrKyBiL2RyaXZlcnMvbWZkL0tjb25maWcNCj4+IEBAIC0x OTA3LDYgKzE5MDcsMTkgQEAgY29uZmlnIE1GRF9TVFBNSUMxDQo+PiAgIAkgIFRvIGNvbXBpbGUg dGhpcyBkcml2ZXIgYXMgYSBtb2R1bGUsIGNob29zZSBNIGhlcmU6IHRoZQ0KPj4gICAJICBtb2R1 bGUgd2lsbCBiZSBjYWxsZWQgc3RwbWljMS4NCj4+ICAgDQo+PiArY29uZmlnIE1GRF9TVE1GWA0K Pj4gKwl0cmlzdGF0ZSAiU3VwcG9ydCBmb3IgU1RNaWNyb2VsZWN0cm9uaWNzIE11bHRpLUZ1bmN0 aW9uIGVYcGFuZGVyIChTVE1GWCkiDQo+PiArCWRlcGVuZHMgb24gSTJDDQo+PiArCWRlcGVuZHMg b24gT0YgfHwgQ09NUElMRV9URVNUDQo+PiArCXNlbGVjdCBNRkRfQ09SRQ0KPj4gKwlzZWxlY3Qg UkVHTUFQX0kyQw0KPj4gKwloZWxwDQo+PiArCSAgU3VwcG9ydCBmb3IgdGhlIFNUTWljcm9lbGVj dHJvbmljcyBNdWx0aS1GdW5jdGlvbiBlWHBhbmRlci4NCj4+ICsNCj4+ICsJICBUaGlzIGRyaXZl ciBwcm92aWRlcyBjb21tb24gc3VwcG9ydCBmb3IgYWNjZXNzaW5nIHRoZSBkZXZpY2UsDQo+PiAr CSAgYWRkaXRpb25hbCBkcml2ZXJzIG11c3QgYmUgZW5hYmxlZCBpbiBvcmRlciB0byB1c2UgdGhl IGZ1bmN0aW9uYWxpdHkNCj4+ICsJICBvZiB0aGUgZGV2aWNlLg0KPj4gKw0KPj4gICBtZW51ICJN dWx0aW1lZGlhIENhcGFiaWxpdGllcyBQb3J0IGRyaXZlcnMiDQo+PiAgIAlkZXBlbmRzIG9uIEFS Q0hfU0ExMTAwDQo+PiAgIA0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL01ha2VmaWxlIGIv ZHJpdmVycy9tZmQvTWFrZWZpbGUNCj4+IGluZGV4IGI0NTY5ZWQ3Li42MTRlZWE4IDEwMDY0NA0K Pj4gLS0tIGEvZHJpdmVycy9tZmQvTWFrZWZpbGUNCj4+ICsrKyBiL2RyaXZlcnMvbWZkL01ha2Vm aWxlDQo+PiBAQCAtMjQ2LDQgKzI0Niw0IEBAIG9iai0kKENPTkZJR19NRkRfTVhTX0xSQURDKSAg ICAgKz0gbXhzLWxyYWRjLm8NCj4+ICAgb2JqLSQoQ09ORklHX01GRF9TQzI3WFhfUE1JQykJKz0g c3ByZC1zYzI3eHgtc3BpLm8NCj4+ICAgb2JqLSQoQ09ORklHX1JBVkVfU1BfQ09SRSkJKz0gcmF2 ZS1zcC5vDQo+PiAgIG9iai0kKENPTkZJR19NRkRfUk9ITV9CRDcxOFhYKQkrPSByb2htLWJkNzE4 eDcubw0KPj4gLQ0KPj4gK29iai0kKENPTkZJR19NRkRfU1RNRlgpIAkrPSBzdG1meC5vDQo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvc3RtZnguYyBiL2RyaXZlcnMvbWZkL3N0bWZ4LmMNCj4+ IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+PiBpbmRleCAwMDAwMDAwLi41OWYwYTAzDQo+PiAtLS0g L2Rldi9udWxsDQo+PiArKysgYi9kcml2ZXJzL21mZC9zdG1meC5jDQo+PiBAQCAtMCwwICsxLDU2 NiBAQA0KPj4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wDQo+PiArLyoNCj4+ ICsgKiBEcml2ZXIgZm9yIFNUTWljcm9lbGVjdHJvbmljcyBNdWx0aS1GdW5jdGlvbiBlWHBhbmRl ciAoU1RNRlgpIGNvcmUNCj4+ICsgKg0KPj4gKyAqIENvcHlyaWdodCAoQykgMjAxOSBTVE1pY3Jv ZWxlY3Ryb25pY3MNCj4+ICsgKiBBdXRob3Iocyk6IEFtZWxpZSBEZWxhdW5heSA8YW1lbGllLmRl bGF1bmF5QHN0LmNvbT4uDQo+PiArICovDQo+PiArI2luY2x1ZGUgPGxpbnV4L2JpdGZpZWxkLmg+ DQo+PiArI2luY2x1ZGUgPGxpbnV4L2kyYy5oPg0KPj4gKyNpbmNsdWRlIDxsaW51eC9pbnRlcnJ1 cHQuaD4NCj4+ICsjaW5jbHVkZSA8bGludXgvaXJxLmg+DQo+PiArI2luY2x1ZGUgPGxpbnV4L21m ZC9jb3JlLmg+DQo+PiArI2luY2x1ZGUgPGxpbnV4L21mZC9zdG1meC5oPg0KPj4gKyNpbmNsdWRl IDxsaW51eC9tb2R1bGUuaD4NCj4+ICsjaW5jbHVkZSA8bGludXgvcmVndWxhdG9yL2NvbnN1bWVy Lmg+DQo+IA0KPiBbLi4uXQ0KPiANCj4+ICtzdGF0aWMgaW50IHN0bWZ4X2NoaXBfaW5pdChzdHJ1 Y3QgaTJjX2NsaWVudCAqY2xpZW50KQ0KPj4gK3sNCj4+ICsJc3RydWN0IHN0bWZ4ICpzdG1meCA9 IGkyY19nZXRfY2xpZW50ZGF0YShjbGllbnQpOw0KPj4gKwl1MzIgaWQ7DQo+PiArCXU4IHZlcnNp b25bMl07DQo+PiArCWludCByZXQ7DQo+PiArDQo+PiArCXN0bWZ4LT52ZGQgPSBkZXZtX3JlZ3Vs YXRvcl9nZXRfb3B0aW9uYWwoJmNsaWVudC0+ZGV2LCAidmRkIik7DQo+PiArCWlmIChJU19FUlIo c3RtZngtPnZkZCkpIHsNCj4+ICsJCXJldCA9IFBUUl9FUlIoc3RtZngtPnZkZCk7DQo+PiArCQlp ZiAocmV0ICE9IC1FTk9ERVYpIHsNCj4+ICsJCQlpZiAocmV0ICE9IC1FUFJPQkVfREVGRVIpDQo+ PiArCQkJCWRldl9lcnIoJmNsaWVudC0+ZGV2LA0KPj4gKwkJCQkJIkNhbid0IGdldCBWREQgcmVn dWxhdG9yOiVkXG4iLCByZXQpOw0KPj4gKwkJCXJldHVybiByZXQ7DQo+PiArCQl9DQo+IA0KPiBB bnkgcmVhc29uIHlvdSd2ZSBkZWNpZGVkIHRvIHN0aWNrIHdpdGggdGhpcyAzLWxheWVyIG5lc3Rl ZCBpZiBpbnN0ZWFkDQo+IG9mIGdvaW5nIHdpdGggbXkgc3VnZ2VzdGlvbj8NCj4gDQoNClNvcnJ5 LCBJIGRpZG4ndCBzZWUgeW91ciBzdWdnZXN0aW9uLiBJJ2xsIGdvIHdpdGggaXQgaW4gdjYuDQoN Cj4+ICsJfSBlbHNlIHsNCj4+ICsJCXJldCA9IHJlZ3VsYXRvcl9lbmFibGUoc3RtZngtPnZkZCk7 DQo+PiArCQlpZiAocmV0KSB7DQo+PiArCQkJZGV2X2VycigmY2xpZW50LT5kZXYsICJWREQgZW5h YmxlIGZhaWxlZDogJWRcbiIsIHJldCk7DQo+PiArCQkJcmV0dXJuIHJldDsNCj4+ICsJCX0NCj4+ ICsJfQ0KPiANCj4gWy4uLl0NCj4gDQo+PiArI2lmZGVmIENPTkZJR19QTV9TTEVFUA0KPj4gK3N0 YXRpYyBpbnQgc3RtZnhfYmFja3VwX3JlZ3Moc3RydWN0IHN0bWZ4ICpzdG1meCkNCj4+ICt7DQo+ PiArCWludCByZXQ7DQo+PiArDQo+PiArCXJldCA9IHJlZ21hcF9yYXdfcmVhZChzdG1meC0+bWFw LCBTVE1GWF9SRUdfU1lTX0NUUkwsDQo+PiArCQkJICAgICAgJnN0bWZ4LT5ia3Bfc3lzY3RybCwg c2l6ZW9mKHN0bWZ4LT5ia3Bfc3lzY3RybCkpOw0KPj4gKwlpZiAocmV0KQ0KPj4gKwkJcmV0dXJu IHJldDsNCj4+ICsNCj4+ICsJcmV0ID0gcmVnbWFwX3Jhd19yZWFkKHN0bWZ4LT5tYXAsIFNUTUZY X1JFR19JUlFfT1VUX1BJTiwNCj4+ICsJCQkgICAgICAmc3RtZngtPmJrcF9pcnFvdXRwaW4sDQo+ PiArCQkJICAgICAgc2l6ZW9mKHN0bWZ4LT5ia3BfaXJxb3V0cGluKSk7DQo+PiArCWlmIChyZXQp DQo+PiArCQlyZXR1cm4gcmV0Ow0KPj4gKw0KPj4gKwlyZXR1cm4gMDsNCj4+ICt9DQo+PiArDQo+ PiArc3RhdGljIGludCBzdG1meF9yZXN0b3JlX3JlZ3Moc3RydWN0IHN0bWZ4ICpzdG1meCkNCj4+ ICt7DQo+PiArCWludCByZXQ7DQo+PiArDQo+PiArCXJldCA9IHJlZ21hcF9yYXdfd3JpdGUoc3Rt ZngtPm1hcCwgU1RNRlhfUkVHX1NZU19DVFJMLA0KPj4gKwkJCSAgICAgICAmc3RtZngtPmJrcF9z eXNjdHJsLCBzaXplb2Yoc3RtZngtPmJrcF9zeXNjdHJsKSk7DQo+PiArCWlmIChyZXQpDQo+PiAr CQlyZXR1cm4gcmV0Ow0KPj4gKw0KPj4gKwlyZXQgPSByZWdtYXBfcmF3X3dyaXRlKHN0bWZ4LT5t YXAsIFNUTUZYX1JFR19JUlFfT1VUX1BJTiwNCj4+ICsJCQkgICAgICAgJnN0bWZ4LT5ia3BfaXJx b3V0cGluLA0KPj4gKwkJCSAgICAgICBzaXplb2Yoc3RtZngtPmJrcF9pcnFvdXRwaW4pKTsNCj4+ ICsJaWYgKHJldCkNCj4+ICsJCXJldHVybiByZXQ7DQo+PiArDQo+PiArCXJldCA9IHJlZ21hcF9y YXdfd3JpdGUoc3RtZngtPm1hcCwgU1RNRlhfUkVHX0lSUV9TUkNfRU4sDQo+PiArCQkJICAgICAg ICZzdG1meC0+aXJxX3NyYywgc2l6ZW9mKHN0bWZ4LT5pcnFfc3JjKSk7DQo+PiArCWlmIChyZXQp DQo+PiArCQlyZXR1cm4gcmV0Ow0KPj4gKw0KPj4gKwlyZXR1cm4gMDsNCj4+ICt9DQo+PiArDQo+ PiArc3RhdGljIGludCBzdG1meF9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+ICt7DQo+ PiArCXN0cnVjdCBzdG1meCAqc3RtZnggPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsNCj4+ICsJaW50 IHJldDsNCj4+ICsNCj4+ICsJcmV0ID0gc3RtZnhfYmFja3VwX3JlZ3Moc3RtZngpOw0KPj4gKwlp ZiAocmV0KSB7DQo+PiArCQlkZXZfZXJyKHN0bWZ4LT5kZXYsICJSZWdpc3RlcnMgYmFja3VwIGZh aWx1cmVcbiIpOw0KPj4gKwkJcmV0dXJuIHJldDsNCj4+ICsJfQ0KPiANCj4gVGhpcyBkb2Vzbid0 IG5lZWQgdG8gYmUgYW4gZXh0cmEgZnVuY3Rpb24uICBZb3UncmUganVzdCBhZGRpbmcgbW9yZQ0K PiBsaW5lcyBvZiBjb2RlIGZvciBubyByZWFsIGdhaW4gaW4gcmV1c2FiaWxpdHkvcmVhZGFiaWxp dHkuDQo+IA0KDQpJIHVzZWQgYSBzZXBhcmF0ZSBmdW5jdGlvbiB0byBoYXZlIG9ubHkgb25lIGRl dl9lcnIgaW4gY2FzZSBvZiANCmJhY2t1cC9yZXN0b3JlIGZhaWx1cmUuDQpCdXQgYW55d2F5LCBJ J2xsIGRyb3AgYmFja3VwL3Jlc3RvcmUgZnVuY3Rpb25zIGFuZCBwdXQgdGhlIGNvZGUgaW4gDQpz dXNwZW5kL3Jlc3VtZS4NCg0KPj4gKwlpZiAoIUlTX0VSUihzdG1meC0+dmRkKSkgew0KPj4gKwkJ cmV0ID0gcmVndWxhdG9yX2Rpc2FibGUoc3RtZngtPnZkZCk7DQo+PiArCQlpZiAocmV0KQ0KPj4g KwkJCXJldHVybiByZXQ7DQo+PiArCX0NCj4+ICsNCj4+ICsJcmV0dXJuIDA7DQo+PiArfQ0KPj4g Kw0KPj4gK3N0YXRpYyBpbnQgc3RtZnhfcmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+ICt7 DQo+PiArCXN0cnVjdCBzdG1meCAqc3RtZnggPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsNCj4+ICsJ aW50IHJldDsNCj4+ICsNCj4+ICsJaWYgKCFJU19FUlIoc3RtZngtPnZkZCkpIHsNCj4+ICsJCXJl dCA9IHJlZ3VsYXRvcl9lbmFibGUoc3RtZngtPnZkZCk7DQo+PiArCQlpZiAocmV0KSB7DQo+PiAr CQkJZGV2X2VycihzdG1meC0+ZGV2LA0KPj4gKwkJCQkiVkREIGVuYWJsZSBmYWlsZWQ6ICVkXG4i LCByZXQpOw0KPj4gKwkJCXJldHVybiByZXQ7DQo+PiArCQl9DQo+PiArCX0NCj4+ICsNCj4+ICsJ cmV0ID0gc3RtZnhfcmVzdG9yZV9yZWdzKHN0bWZ4KTsNCj4+ICsJaWYgKHJldCkgew0KPj4gKwkJ ZGV2X2VycihzdG1meC0+ZGV2LCAiUmVnaXN0ZXJzIHJlc3RvcmF0aW9uIGZhaWx1cmVcbiIpOw0K Pj4gKwkJcmV0dXJuIHJldDsNCj4+ICsJfQ0KPiANCj4gVGhpcyBkb2Vzbid0IG5lZWQgdG8gYmUg YW4gZXh0cmEgZnVuY3Rpb24uICBZb3UncmUganVzdCBhZGRpbmcgbW9yZQ0KPiBsaW5lcyBvZiBj b2RlIGZvciBubyByZWFsIGdhaW4gaW4gcmV1c2FiaWxpdHkvcmVhZGFiaWxpdHkuDQo+IA0KPj4g KwlyZXR1cm4gMDsNCj4+ICt9DQo+PiArI2VuZGlmDQo+IA0KPiBbLi4uXQ0KPiA= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B778AC04AAB for ; Wed, 8 May 2019 14:44:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FB0721530 for ; Wed, 8 May 2019 14:44:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UA+MeaUx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="NDBJhGUr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FB0721530 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U/k53zzPCkyykyfrYIQ4978hdwN1cRvspiyeUTH6aa8=; b=UA+MeaUxZmwsnN lb5tSR427ZK6TthOY3RvEhxSz1i4G/WJAxbGwHCG/at4JqKZr/CRRKioZ6nHdzi+uKerd7x2r+fbW x403oLd2IvURJurmOj8AoQxGdPLp8fIkZUEJyglGWRZ9lqmKo94XqZuSy5XhstWkM4bIAjIJNbWPx 7l982mk2fQr7hX2B0NolKt4TzDIheHsipZWOnk6Xej/IpuyGHn8GueXOG055qqp3TUSdx2dXTONBs dqiT6PtWN0wFwCQdSzN5+391QQBBBvP4sp1e/NJEG4kqMnBf54koB2dFuLh4uqyu2uFuVqXzFDt2u pSWULRt9C4IboAEeokgw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hONo2-0005Pr-8r; Wed, 08 May 2019 14:44:26 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hONnz-0005PM-4D for linux-arm-kernel@lists.infradead.org; Wed, 08 May 2019 14:44:25 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x48EfRWK016745; Wed, 8 May 2019 16:44:12 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=ujx99i/SdmhJJY/rTfyjZ25oaMJTjnJ2T2B83DEfQao=; b=NDBJhGUrF+5cuInlJHlGw+Wa11TeVKy9sCKxakUcQg4M/gC07uoIxkT24K1/ylLXCY5k Wqkzt57AQ4QQIWbdeDTm64k50D83HpQnavgmO3DPW3lFsa43MPtwtayz9mF9D0q6vOea Cv2pYd5EDB78dz4AIOFkcw3UEc1gqZcvm1DrQJfcuWPdA+G59vhtndIXoHLbKyIC9h2d 0gjVQ+9DE8jS5lMkO35E8SA8A8VboazvOKB1Nl+eAUmASF8V5MofiqFSZz50jFA9fMOP Zfo6w4OdapO7LKAhrAa18JXran0E0YZ3FWsA3nNZK/0kg5Jqs6zDVyLeVp+csBDU6TcD Vw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2s94c3qnkd-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 08 May 2019 16:44:12 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0476338; Wed, 8 May 2019 14:44:10 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag3node1.st.com [10.75.127.7]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C010028CA; Wed, 8 May 2019 14:44:10 +0000 (GMT) Received: from SFHDAG3NODE2.st.com (10.75.127.8) by SFHDAG3NODE1.st.com (10.75.127.7) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 8 May 2019 16:44:10 +0200 Received: from SFHDAG3NODE2.st.com ([fe80::b82f:1ce:8854:5b96]) by SFHDAG3NODE2.st.com ([fe80::b82f:1ce:8854:5b96%20]) with mapi id 15.00.1347.000; Wed, 8 May 2019 16:44:10 +0200 From: Amelie DELAUNAY To: Lee Jones Subject: Re: [PATCH v5 2/9] mfd: Add ST Multi-Function eXpander (STMFX) core driver Thread-Topic: [PATCH v5 2/9] mfd: Add ST Multi-Function eXpander (STMFX) core driver Thread-Index: AQHU7qVAy3Bds8UGv0OmxPFvTsiQh6Zg82kAgABmwoA= Date: Wed, 8 May 2019 14:44:10 +0000 Message-ID: <697597b2-088d-9ffb-54bd-e50b3ca8c012@st.com> References: <1554794651-6874-1-git-send-email-amelie.delaunay@st.com> <1554794651-6874-3-git-send-email-amelie.delaunay@st.com> <20190508083622.GE3995@dell> In-Reply-To: <20190508083622.GE3995@dell> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-08_08:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190508_074423_614077_B832E1B0 X-CRM114-Status: GOOD ( 26.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Alexandre TORGUE , Linus Walleij , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Rob Herring , Maxime Coquelin , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/8/19 10:36 AM, Lee Jones wrote: > On Tue, 09 Apr 2019, Amelie Delaunay wrote: > >> STMicroelectronics Multi-Function eXpander (STMFX) is a slave controller >> using I2C for communication with the main MCU. Main features are: >> - 16 fast GPIOs individually configurable in input/output >> - 8 alternate GPIOs individually configurable in input/output when other >> STMFX functions are not used >> - Main MCU IDD measurement >> - Resistive touchscreen controller >> >> Signed-off-by: Amelie Delaunay >> --- >> drivers/mfd/Kconfig | 13 ++ >> drivers/mfd/Makefile | 2 +- >> drivers/mfd/stmfx.c | 566 ++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/mfd/stmfx.h | 123 ++++++++++ >> 4 files changed, 703 insertions(+), 1 deletion(-) >> create mode 100644 drivers/mfd/stmfx.c >> create mode 100644 include/linux/mfd/stmfx.h >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index 3443f1a..9783e18 100644 >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -1907,6 +1907,19 @@ config MFD_STPMIC1 >> To compile this driver as a module, choose M here: the >> module will be called stpmic1. >> >> +config MFD_STMFX >> + tristate "Support for STMicroelectronics Multi-Function eXpander (STMFX)" >> + depends on I2C >> + depends on OF || COMPILE_TEST >> + select MFD_CORE >> + select REGMAP_I2C >> + help >> + Support for the STMicroelectronics Multi-Function eXpander. >> + >> + This driver provides common support for accessing the device, >> + additional drivers must be enabled in order to use the functionality >> + of the device. >> + >> menu "Multimedia Capabilities Port drivers" >> depends on ARCH_SA1100 >> >> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile >> index b4569ed7..614eea8 100644 >> --- a/drivers/mfd/Makefile >> +++ b/drivers/mfd/Makefile >> @@ -246,4 +246,4 @@ obj-$(CONFIG_MFD_MXS_LRADC) += mxs-lradc.o >> obj-$(CONFIG_MFD_SC27XX_PMIC) += sprd-sc27xx-spi.o >> obj-$(CONFIG_RAVE_SP_CORE) += rave-sp.o >> obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o >> - >> +obj-$(CONFIG_MFD_STMFX) += stmfx.o >> diff --git a/drivers/mfd/stmfx.c b/drivers/mfd/stmfx.c >> new file mode 100644 >> index 0000000..59f0a03 >> --- /dev/null >> +++ b/drivers/mfd/stmfx.c >> @@ -0,0 +1,566 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Driver for STMicroelectronics Multi-Function eXpander (STMFX) core >> + * >> + * Copyright (C) 2019 STMicroelectronics >> + * Author(s): Amelie Delaunay . >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > [...] > >> +static int stmfx_chip_init(struct i2c_client *client) >> +{ >> + struct stmfx *stmfx = i2c_get_clientdata(client); >> + u32 id; >> + u8 version[2]; >> + int ret; >> + >> + stmfx->vdd = devm_regulator_get_optional(&client->dev, "vdd"); >> + if (IS_ERR(stmfx->vdd)) { >> + ret = PTR_ERR(stmfx->vdd); >> + if (ret != -ENODEV) { >> + if (ret != -EPROBE_DEFER) >> + dev_err(&client->dev, >> + "Can't get VDD regulator:%d\n", ret); >> + return ret; >> + } > > Any reason you've decided to stick with this 3-layer nested if instead > of going with my suggestion? > Sorry, I didn't see your suggestion. I'll go with it in v6. >> + } else { >> + ret = regulator_enable(stmfx->vdd); >> + if (ret) { >> + dev_err(&client->dev, "VDD enable failed: %d\n", ret); >> + return ret; >> + } >> + } > > [...] > >> +#ifdef CONFIG_PM_SLEEP >> +static int stmfx_backup_regs(struct stmfx *stmfx) >> +{ >> + int ret; >> + >> + ret = regmap_raw_read(stmfx->map, STMFX_REG_SYS_CTRL, >> + &stmfx->bkp_sysctrl, sizeof(stmfx->bkp_sysctrl)); >> + if (ret) >> + return ret; >> + >> + ret = regmap_raw_read(stmfx->map, STMFX_REG_IRQ_OUT_PIN, >> + &stmfx->bkp_irqoutpin, >> + sizeof(stmfx->bkp_irqoutpin)); >> + if (ret) >> + return ret; >> + >> + return 0; >> +} >> + >> +static int stmfx_restore_regs(struct stmfx *stmfx) >> +{ >> + int ret; >> + >> + ret = regmap_raw_write(stmfx->map, STMFX_REG_SYS_CTRL, >> + &stmfx->bkp_sysctrl, sizeof(stmfx->bkp_sysctrl)); >> + if (ret) >> + return ret; >> + >> + ret = regmap_raw_write(stmfx->map, STMFX_REG_IRQ_OUT_PIN, >> + &stmfx->bkp_irqoutpin, >> + sizeof(stmfx->bkp_irqoutpin)); >> + if (ret) >> + return ret; >> + >> + ret = regmap_raw_write(stmfx->map, STMFX_REG_IRQ_SRC_EN, >> + &stmfx->irq_src, sizeof(stmfx->irq_src)); >> + if (ret) >> + return ret; >> + >> + return 0; >> +} >> + >> +static int stmfx_suspend(struct device *dev) >> +{ >> + struct stmfx *stmfx = dev_get_drvdata(dev); >> + int ret; >> + >> + ret = stmfx_backup_regs(stmfx); >> + if (ret) { >> + dev_err(stmfx->dev, "Registers backup failure\n"); >> + return ret; >> + } > > This doesn't need to be an extra function. You're just adding more > lines of code for no real gain in reusability/readability. > I used a separate function to have only one dev_err in case of backup/restore failure. But anyway, I'll drop backup/restore functions and put the code in suspend/resume. >> + if (!IS_ERR(stmfx->vdd)) { >> + ret = regulator_disable(stmfx->vdd); >> + if (ret) >> + return ret; >> + } >> + >> + return 0; >> +} >> + >> +static int stmfx_resume(struct device *dev) >> +{ >> + struct stmfx *stmfx = dev_get_drvdata(dev); >> + int ret; >> + >> + if (!IS_ERR(stmfx->vdd)) { >> + ret = regulator_enable(stmfx->vdd); >> + if (ret) { >> + dev_err(stmfx->dev, >> + "VDD enable failed: %d\n", ret); >> + return ret; >> + } >> + } >> + >> + ret = stmfx_restore_regs(stmfx); >> + if (ret) { >> + dev_err(stmfx->dev, "Registers restoration failure\n"); >> + return ret; >> + } > > This doesn't need to be an extra function. You're just adding more > lines of code for no real gain in reusability/readability. > >> + return 0; >> +} >> +#endif > > [...] > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel