All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Kukjin Kim' <kgene.kim@samsung.com>,
	'Linus Walleij' <linus.walleij@linaro.org>,
	linux-samsung-soc@vger.kernel.org,
	'Thomas Abraham' <thomas.abraham@linaro.org>
Subject: Re: [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register()
Date: Fri, 08 Feb 2013 11:28:51 +0100	[thread overview]
Message-ID: <6981182.GstG0O2YEu@amdc1227> (raw)
In-Reply-To: <001901ce05be$aacdeb30$0069c190$%han@samsung.com>

On Friday 08 of February 2013 14:39:30 Jingoo Han wrote:
> This patch removes duplicated line of samsung_pinctrl_register(),
> because the number of pins is redundantly assigned twice.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/pinctrl/pinctrl-samsung.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-samsung.c
> b/drivers/pinctrl/pinctrl-samsung.c index 294bcdd..3d5cf63 100644
> --- a/drivers/pinctrl/pinctrl-samsung.c
> +++ b/drivers/pinctrl/pinctrl-samsung.c
> @@ -716,7 +716,6 @@ static int samsung_pinctrl_register(struct
> platform_device *pdev, }
>  	ctrldesc->pins = pindesc;
>  	ctrldesc->npins = drvdata->ctrl->nr_pins;
> -	ctrldesc->npins = drvdata->ctrl->nr_pins;
> 
>  	/* dynamically populate the pin number and pin name for pindesc */
>  	for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++, 
pdesc++)

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
-- 
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform

  reply	other threads:[~2013-02-08 10:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08  5:39 [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register() Jingoo Han
2013-02-08 10:28 ` Tomasz Figa [this message]
2013-02-08 22:44 ` Kukjin Kim
2013-02-10 19:17 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6981182.GstG0O2YEu@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=jg1.han@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.