All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sławomir Skowron" <szibis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] opensm: Fix opensm handover/relinquish corner case
Date: Tue, 14 Feb 2012 18:00:25 +0100	[thread overview]
Message-ID: <6985899376444923599@unknownmsgid> (raw)
In-Reply-To: <1329178427.4779.1088.camel-akkeaxHeDKRliZ7u+bvwcg@public.gmane.org>

Pozdrawiam

iSS

On 14 lut 2012, at 01:23, Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org> wrote:

> When in master state and performing light sweeps, openSM ignores
> other subnet managers in master state and fails to perform
> handovers or relinquish control.  Handovers and relinquishing
> master is only performed after a heavy sweep.  This can result
> in two subnet managers being in master state, seeing each other
> SM in master state, but both choose to do nothing about it.
>
> This patch initiates a heavy sweep when another master subnet
> manager is found during a light sweep.  This is sufficient to
> start a handover or relinquish scenario.
>
> Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> ---
> opensm/osm_sminfo_rcv.c |   18 ++++++++++++++++--
> 1 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/opensm/osm_sminfo_rcv.c b/opensm/osm_sminfo_rcv.c
> index 66eb886..d4ae7c9 100644
> --- a/opensm/osm_sminfo_rcv.c
> +++ b/opensm/osm_sminfo_rcv.c
> @@ -385,8 +385,22 @@ static void smi_rcv_process_get_sm(IN osm_sm_t * sm,
>                osm_sm_state_mgr_signal_master_is_alive(sm);
>            else {
>                /* This is a response we got while sweeping the subnet.
> -                   We will handle a case of handover needed later on, when the sweep
> -                   is done and all SMs are recongnized. */
> +                 *
> +                 * If this is during a heavy sweep, we will handle a case of
> +                 * handover needed later on, when the sweep is done and all
> +                 * SMs are recognized.
> +                 *
> +                 * If this is during a light sweep, initiate a heavy sweep
> +                 * to initiate handover scenarios.
> +                 *
> +                 * Note that it does not matter if the remote SM is lower
> +                 * or higher priority.  If it is lower priority, we must
> +                 * wait for it HANDOVER.  If it is higher priority, we need
> +                 * to HANDOVER to it.  Both cases are handled after doing
> +                 * a heavy sweep.
> +                 */
> +                if (light_sweep)
> +                    sm->p_subn->force_heavy_sweep = TRUE;
>            }
>            break;
>        case IB_SMINFO_STATE_STANDBY:
> --
> 1.7.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-02-14 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14  0:13 [PATCH] opensm: Fix opensm handover/relinquish corner case Albert Chu
     [not found] ` <1329178427.4779.1088.camel-akkeaxHeDKRliZ7u+bvwcg@public.gmane.org>
2012-02-14 17:00   ` Sławomir Skowron [this message]
2012-02-29 17:11   ` Alex Netes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6985899376444923599@unknownmsgid \
    --to=szibis-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=chu11-i2BcT+NCU+M@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.