Re: [PATCH V2] ieee1275/ofdisk: vscsi lun handling on lun len

From: Mukesh Kumar Chaurasiya <mchauras@linux.ibm.com>
To: Daniel Kiper <dkiper@net-space.pl>,
	The development of GNU GRUB <grub-devel@gnu.org>
Cc: meghanaprakash@in.ibm.com, avnish@linux.vnet.ibm.com,
	brking@linux.vnet.ibm.com, mamatha4@linux.vnet.ibm.com,
	mchauras@linux.vnet.ibm.com
Subject: Re: [PATCH V2] ieee1275/ofdisk: vscsi lun handling on lun len
Date: Wed, 17 Jan 2024 12:39:06 +0530	[thread overview]
Message-ID: <698e73b3-e792-4e4d-86f7-e038a094df46@linux.ibm.com> (raw)
In-Reply-To: <20231129191529.tomo3qz2gtvboser@tomti.i.net-space.pl>

On 11/30/23 00:45, Daniel Kiper wrote:
> On Mon, Nov 27, 2023 at 06:07:42PM +0530, Mukesh Kumar Chaurasiya wrote:
>> Signed-off-by: Mukesh Kumar Chaurasiya <mchauras@linux.ibm.com>
>> ---
>>   grub-core/disk/ieee1275/ofdisk.c | 11 ++++++++---
>>   1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/grub-core/disk/ieee1275/ofdisk.c b/grub-core/disk/ieee1275/ofdisk.c
>> index c6cba0c8a..9cd8898f1 100644
>> --- a/grub-core/disk/ieee1275/ofdisk.c
>> +++ b/grub-core/disk/ieee1275/ofdisk.c
>> @@ -222,8 +222,12 @@ dev_iterate (const struct grub_ieee1275_devalias *alias)
>>   	grub_ieee1275_cell_t table;
>>         }
>>         args;
>> +      struct lun_buf {
>> +	grub_uint64_t *buf_addr;
> This will not work on 32-bit architectures.

Umm...

  well i checked this and the definition for 32bit and 64bit are same. 
So the structure part should be fine.

+ ptr =(grub_uint64_t*)(grub_addr_t) tbl[i].buf_addr;
and this should handle the 32bit arch in terms of address.
for rest i'll send out a new version of patch
Regards,
Mukesh

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel