Re: [dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device

[Thomas Monjalon <thomas@monjalon.net>]

09/11/2021 17:55, Radha Mohan Chintakuntla:
> The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver
> for the same device uses the dmadev. So this patch updates the device
> naming and lists it under dma devices section.
> 
> Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> ---
>  usertools/dpdk-devbind.py | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index af9a0ad5ab..e298ad5f75 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -41,8 +41,8 @@
>                   'SVendor': None, 'SDevice': None}
>  octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
>                   'SVendor': None, 'SDevice': None}
> -octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> -                 'SVendor': None, 'SDevice': None}
> +cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> +            'SVendor': None, 'SDevice': None}

It doesn't look logical to have cnxk device in the middle of octeontx2 ones.
Maybe before to sort it a bit alphabetically?

>  dma_devices = [hisilicon_dma,
> -               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx]
> +               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx,
> +               cnxk_dma]

Would be better at the beginning of the list, before hisilicon
so it is alphabetically sorted.