From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AA07C3DA78 for ; Tue, 17 Jan 2023 12:05:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/c7fBxsNV3WZ4Ln2MIu0GaICefRZ//EcoQ9j61ayQNk=; b=UucGV21W4Qziyn J2C4ALR5uymRYCpMOO3igLw4QsrS99LjpuX9TQXwuN0hC10xVbm6l6PoRKw4ZkC008FPslweQ2MIo ScrVms9Z59Ee6rsXC39yj+F0l/SQEOZUZ6DfiTO8aIfmG6wd1SxtGEPb08472npP4KGsBFfE0vM+9 c/tdf2tzSmaulv/tUGR6ET/XwDrMlz45LSJ340Ok9vsft3gAKIQFG8PTRXX1r8JxqyVal/VAfxBjM Y2PihWrihLJjqu+qDzxoUj0XgbEtBl48g3SCr6wuYgpWGalDzcgdSHf4SNnAeZwob5zwTUgR04IsR 3Dm5ZvyMvBYEK4QMI0bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHkhz-00E80K-56; Tue, 17 Jan 2023 12:04:55 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHkhj-00E7vC-D6 for linux-amlogic@lists.infradead.org; Tue, 17 Jan 2023 12:04:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673957078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hIghJLY4bualUJFQqX/SZDMXujK/HbU9/7wn3xgRH5o=; b=KczKGC7skjMEm97BwZjVkN1SXbpvwpd7mQSApmbmqB+BQptUwMwZsmvKZrQzSobRTKMD+l ij0h54qZ1b/YovrniZmcMOCzW9PeUw/HOc3n7gsNtx2wNRfSHvw4fdcqRQYoWgF2uOKRe3 p422jqYmL/0BX45dkJ4MfRcNUtk52J4= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-43-ZyFKJcRJMXaYW24lsjzrfw-1; Tue, 17 Jan 2023 07:04:35 -0500 X-MC-Unique: ZyFKJcRJMXaYW24lsjzrfw-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-482d3bf0266so324482017b3.3 for ; Tue, 17 Jan 2023 04:04:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EGd8Gv7zO6+RZus69tR/m6BH1nFkS1nUUO+DcJcAeOU=; b=pXmgm2xdMEIqy4B/y3xStJpHxJeceFZCPFlAUMBjpWXECBOuGWklfDuTlG9iJ05mBw /XQRCz4LGxya9pKlCN92ctfgIDoZPIQ9V7APp6cziLX9xf67/C3Cc7bzrvpltn4Q2K6r +tvxXjvv/a3Y5RrJkfM0aWsOzdAYCcnY/i7PLxQ3LNq98YOyl3lE4LyeqVpWRY6cxLTF PNTfBzs5DaSo/rMg3MG7zurNKEKd0wxuT/bWp++ZYYCznbgFRqI4P8Bm9VXt90BdZeYZ c222kyD/30OdEk7KbAtU6illz9pl+2eDFgKza8PgAxz48HFyjVWkos5Aj3ob8Umx0wMU vvEQ== X-Gm-Message-State: AFqh2kr2HYq/IMd6izOvRqq7WawZwDWEYJz2UjD6vWv8JdIoauvaDGfG +K1W6B1aSZO+jM6ZQGIxviHI5qtJTWVt/69N9DcTjcfzfn6pNEJvBPFIw9zq6pnT6oHnrsG8aal pMr4v1BWnu7uYsnvrL3BDj9KRhrt26W8= X-Received: by 2002:a0d:ebc7:0:b0:4d2:df5d:4f8a with SMTP id u190-20020a0debc7000000b004d2df5d4f8amr2479248ywe.11.1673957074953; Tue, 17 Jan 2023 04:04:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXtHxspuMUbwpLPxkzC/BX7aJ3whS1J+KUFaZG4ER3Z2qEHdLvNUwS4DQIn2g/GbJHhFhtDxaQ== X-Received: by 2002:a0d:ebc7:0:b0:4d2:df5d:4f8a with SMTP id u190-20020a0debc7000000b004d2df5d4f8amr2479226ywe.11.1673957074632; Tue, 17 Jan 2023 04:04:34 -0800 (PST) Received: from gerbillo.redhat.com (146-241-115-179.dyn.eolo.it. [146.241.115.179]) by smtp.gmail.com with ESMTPSA id bi27-20020a05620a319b00b00706a1551428sm634487qkb.6.2023.01.17.04.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 04:04:34 -0800 (PST) Message-ID: <699f6ee109b3a72b2b377f42a78705f47d4a77b9.camel@redhat.com> Subject: Re: [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions From: Paolo Abeni To: Heiner Kallweit , Neil Armstrong , Andrew Lunn Cc: Russell King - ARM Linux , David Miller , Eric Dumazet , Jakub Kicinski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." Date: Tue, 17 Jan 2023 13:04:30 +0100 In-Reply-To: <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> References: <03ea260e-f03c-d9d7-6f5f-ff72836f5739@gmail.com> <51abd8ca-8172-edfa-1c18-b1e48231f316@linaro.org> <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230117_040439_525493_E5038412 X-CRM114-Status: GOOD ( 35.32 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiBTdW4sIDIwMjMtMDEtMTUgYXQgMjE6MzggKzAxMDAsIEhlaW5lciBLYWxsd2Vp dCB3cm90ZToKPiBPbiAxNS4wMS4yMDIzIDE5OjQzLCBOZWlsIEFybXN0cm9uZyB3cm90ZToKPiA+ IEhpIEhlaW5lciwKPiA+IAo+ID4gTGUgMTUvMDEvMjAyMyDDoCAxODowOSwgSGVpbmVyIEthbGx3 ZWl0IGEgw6ljcml0wqA6Cj4gPiA+IE9uIDE1LjAxLjIwMjMgMTc6NTcsIEFuZHJldyBMdW5uIHdy b3RlOgo+ID4gPiA+IE9uIFN1biwgSmFuIDE1LCAyMDIzIGF0IDA0OjE5OjM3UE0gKzAxMDAsIEhl aW5lciBLYWxsd2VpdCB3cm90ZToKPiA+ID4gPiA+IE9uIG15IFNDMi1iYXNlZCBzeXN0ZW0gdGhl IGdlbnBoeSBkcml2ZXIgd2FzIHVzZWQgYmVjYXVzZSB0aGUgUEhZCj4gPiA+ID4gPiBpZGVudGlm aWVzIGFzIDB4MDE4MDMzMDAuIEl0IHdvcmtzIG5vcm1hbCB3aXRoIHRoZSBtZXNvbiBnMTJhCj4g PiA+ID4gPiBkcml2ZXIgYWZ0ZXIgdGhpcyBjaGFuZ2UuCj4gPiA+ID4gPiBTd2l0Y2ggdG8gUEhZ X0lEX01BVENIX01PREVMIHRvIGNvdmVyIHRoZSBkaWZmZXJlbnQgc3ViLXZlcnNpb25zLgo+ID4g PiA+IAo+ID4gPiA+IEhpIEhlaW5lcgo+ID4gPiA+IAo+ID4gPiA+IEFyZSB0aGVyZSBhbnkgZGF0 YXNoZWV0cyBmb3IgdGhlc2UgZGV2aWNlcz8gQW55dGhpbmcgd2hpY2ggZG9jdW1lbnRzCj4gPiA+ ID4gdGhlIGxvd2VyIG5pYmJsZSByZWFsbHkgaXMgYSByZXZpc2lvbj8KPiA+ID4gPiAKPiA+ID4g PiBJJ20ganVzdCB0cnlpbmcgdG8gYXZvaWQgZnV0dXJlIHByb2JsZW1zIHdoZXJlIHdlIGZpbmQg aXQgaXMgYWN0dWFsbHkKPiA+ID4gPiBhIGRpZmZlcmVudCBQSFksIG5lZWRzIGl0cyBvd24gTUFU Q0hfRVhBQ1QgZW50cnksIGFuZCB0aGVuIHdlIGZpbmQgd2UKPiA+ID4gPiBicmVhayBkZXZpY2Vz IHVzaW5nIDB4MDE4MDMzMDIgd2hpY2ggd2UgaGFkIG5vIGlkZWEgZXhpc3RzLCBidXQgZ290Cj4g PiA+ID4gY292ZXJlZCBieSB0aGlzIGNoYW5nZS4KPiA+ID4gPiAKPiA+ID4gVGhlIFNDMiBwbGF0 Zm9ybSBpbmhlcml0ZWQgYSBsb3QgZnJvbSBHMTJBLCB0aGVyZWZvcmUgaXQncyBwbGF1c2libGUK PiA+ID4gdGhhdCBpdCdzIHRoZSBzYW1lIFBIWS4gQWxzbyB0aGUgdmVuZG9yIGRyaXZlciBmb3Ig U0MyIGdpdmVzIGEgaGludAo+ID4gPiBhcyBpdCBoYXMgdGhlIGZvbGxvd2luZyBjb21wYXRpYmxl IGZvciB0aGUgUEhZOgo+ID4gPiAKPiA+ID4gY29tcGF0aWJsZSA9ICJldGhlcm5ldC1waHktaWQw MTgwLjMzMDEiLCAiZXRoZXJuZXQtcGh5LWllZWU4MDIuMy1jMjIiOwo+ID4gPiAKPiA+ID4gQnV0 IHlvdSdyZSByaWdodCwgSSBjYW4ndCBzYXkgZm9yIHN1cmUgYXMgSSBkb24ndCBoYXZlIHRoZSBk YXRhc2hlZXRzLgo+ID4gCj4gPiBPbiBHMTJBICgmIEdYTCksIHRoZSBQSFkgSUQgaXMgc2V0IGlu IHRoZSBNRElPIE1VWCByZWdpc3RlcnMsCj4gPiBwbGVhc2Ugc2VlOgo+ID4gaHR0cHM6Ly9lbGl4 aXIuYm9vdGxpbi5jb20vbGludXgvbGF0ZXN0L3NvdXJjZS9kcml2ZXJzL25ldC9tZGlvL21kaW8t bXV4LW1lc29uLWcxMmEuYyNMMzYKPiA+IAo+ID4gU28geW91IHNob3VsZCBlaXRoZXIgYWRkIHN1 cHBvcnQgZm9yIHRoZSBQSFkgbXV4IGluIFNDMiBvciBjaGVjawo+ID4gd2hhdCBpcyBpbiB0aGUg RVRIX1BIWV9DTlRMMCByZWdpc3Rlci4KPiA+IAo+IFRoYW5rcyBmb3IgdGhlIGhpbnQuIEkganVz dCBjaGVja2VkIGFuZCByZWFkaW5nIGJhY2sgRVRIX1BIWV9DTlRMMCBhdCB0aGUKPiBlbmQgb2Yg ZzEyYV9lbmFibGVfaW50ZXJuYWxfbWRpbygpIGdpdmVzIG1lIHRoZSBleHBlY3RlZCByZXN1bHQg b2YgMHgzMzAxMDE4MC4KPiBCdXQgc3RpbGwgdGhlIFBIWSByZXBvcnRzIDMzMDAuCj4gRXZlbiBp ZiBJIHdyaXRlIHNvbWUgb3RoZXIgcmFuZG9tIHZhbHVlIHRvIEVUSF9QSFlfQ05UTDAsIEkgZ2V0 IDAxODAvMzMwMAo+IGFzIFBIWSBJRC4KPiAKPiBGb3IgdS1ib290IEkgZm91bmQgdGhlIGZvbGxv d2luZzoKPiAKPiBodHRwczovL2dpdGh1Yi5jb20va2hhZGFzL3UtYm9vdC9ibG9iL2toYWRhcy12 aW00LXItNjRiaXQvZHJpdmVycy9uZXQvcGh5L2FtbG9naWMuYwo+IAo+IHN0YXRpYyBzdHJ1Y3Qg cGh5X2RyaXZlciBhbWxvZ2ljX2ludGVybmFsX2RyaXZlciA9IHsKPiAJLm5hbWUgPSAiTWVzb24g R1hMIEludGVybmFsIFBIWSIsCj4gCS51aWQgPSAweDAxODAzMzAwLAo+IAkubWFzayA9IDB4ZmZm ZmZmZjAsCj4gCS5mZWF0dXJlcyA9IFBIWV9CQVNJQ19GRUFUVVJFUywKPiAJLmNvbmZpZyA9ICZt ZXNvbl9waHlfY29uZmlnLAo+IAkuc3RhcnR1cCA9ICZtZXNvbl9hbWxfc3RhcnR1cCwKPiAJLnNo dXRkb3duID0gJmdlbnBoeV9zaHV0ZG93biwKPiB9Owo+IAo+IFNvIGl0J3MgdGhlIHNhbWUgUEhZ IElEIEknbSBzZWVpbmcgaW4gTGludXguCj4gCj4gTXkgYmVzdCBndWVzcyBpcyB0aGF0IHRoZSBm b2xsb3dpbmcgaXMgdGhlIGNhc2U6Cj4gCj4gVGhlIFBIWSBjb21wYXRpYmxlIHN0cmluZyBpbiBE VCBpcyB0aGUgZm9sbG93aW5nIGluIGFsbCBjYXNlczoKPiBjb21wYXRpYmxlID0gImV0aGVybmV0 LXBoeS1pZDAxODAuMzMwMSIsICJldGhlcm5ldC1waHktaWVlZTgwMi4zLWMyMiI7Cj4gCj4gVGhl cmVmb3JlIGlkIDAxODAvMzMwMSBpcyB1c2VkIGV2ZW4gaWYgdGhlIFBIWSByZXBvcnRzIHNvbWV0 aGluZyBlbHNlLgo+IE1lYW5zIGl0IGRvZXNuJ3QgbWF0dGVyIHdoaWNoIHZhbHVlIHlvdSB3cml0 ZSB0byBFVEhfUEhZX0NOVEwwLgo+IAo+IEkgcmVkdWNlZCB0aGUgY29tcGF0aWJsZSBzdHJpbmcg dG8gY29tcGF0aWJsZSA9ICJldGhlcm5ldC1waHktaWVlZTgwMi4zLWMyMiIKPiBhbmQgdGhpcyBy ZXN1bHRlZCBpbiB0aGUgYWN0dWFsIFBIWSBJRCBiZWluZyB1c2VkLgo+IFlvdSBjb3VsZCBjaGFu Z2UgdGhlIGNvbXBhdGlibGUgaW4gZHRzIHRoZSBzYW1lIHdheSBmb3IgYW55IGcxMmEgc3lzdGVt Cj4gYW5kIEkgYXNzdW1lIHlvdSB3b3VsZCBnZXQgMDE4MC8zMzAwIHRvby4KPiAKPiBSZW1haW5p bmcgcXVlc3Rpb24gaXMgd2h5IHRoZSB2YWx1ZSBpbiBFVEhfUEhZX0NOVEwwIGlzIGlnbm9yZWQu CgpJIFttaXM/XXJlYWQgdGhlIGFib3ZlIGFzIHdlIGNhbid0IGNvbXBsZXRlbHkgcnVsZSBvdXQg QW5kcmV3J3MgZG91YnQsCmFzIHN1Y2ggbWFya2luZyB0aGlzIHBhdGNoIGFzIGNoYW5nZWQgcmVx dWVzdGVkLgoKQ2hlZXJzLAoKUGFvbG8KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2lj QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1384C63797 for ; Tue, 17 Jan 2023 12:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JupJHEOCWpEiHq1/Ij2jrggGRRF4wzB/5be0MmwAh0o=; b=KUecaTbvvqlLie Sj6tNXRPUkKHZ7lkpjKcqLgJ8eeQg4ZcLjbOnMwf+HxFXBX9BQuI+V5e83u0dR260sAqqQ7J7Nuvv KtDXrHSpl27Jhw5W4S4hNuk5UTHm6RgEb8KBbs//V83Z2zPakDdnjifBzw2bptu62vHZ49aXjjdYI x/DJq6nGcZH9/dqNONkG0U9HPpBEUUkfEmXqylxZ2FI1Xi/zPfbi6qutXFRevMlCNIhJVLvBY2vWy 8UK0ciZ9WiRd/JpiH8TBFFhdZsv9+RCaNJlDuD7xwKuTFFpKuh21SNRbIsIBAjYhjqfWwJlzeDBFW etWgxi8Pp+1gYPFIB4DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHkhp-00E7x5-9R; Tue, 17 Jan 2023 12:04:45 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHkhi-00E7ul-DK for linux-arm-kernel@lists.infradead.org; Tue, 17 Jan 2023 12:04:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673957077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hIghJLY4bualUJFQqX/SZDMXujK/HbU9/7wn3xgRH5o=; b=MKIBwOStgkcFg5+kJIUbnRTkjO5Yy0M/iThgG+BvzXJ6GPDPDdiLgtdQoT7bpFLYh3anWe HUrhjOIWWGmfdGY7r7OQMQG/d37i9Ttv4zcU5oK9GGNUqbCnRXQhNTgxaGn+KUokwXcIOM rRxc+BWpx1uh8OAoQGx8V97rGPK2aoc= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-567-K0pvfiYnMvyH-EJn_njq5Q-1; Tue, 17 Jan 2023 07:04:35 -0500 X-MC-Unique: K0pvfiYnMvyH-EJn_njq5Q-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-4dd4d4591f7so125587627b3.15 for ; Tue, 17 Jan 2023 04:04:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EGd8Gv7zO6+RZus69tR/m6BH1nFkS1nUUO+DcJcAeOU=; b=t42Bh5gkfTRoQMuOOSuwhnfmCQBC+XvgLsC6GKf0aqaYJsidgnu+uLHcCEcPgb2pvI umUSVVdWaSVYhDgBPsshh8zXfpQpkOAHcFr4XuZQ9RalT5f7+yUxUwItppWPt7+KziKA XG+j/oK+mKE2k6qPvUVYClxr7U75JpinZ7V0Sfr81ibjmys3rvtvsMWsEjgZ2gNc7E33 OPiUz1hDUlZc1DAuWnrY64KcYN0Sn6GdJl7YRB3UfpOPzbHMmJy0lLIrcj+cJYNXxvr1 7tb8KzOyN05ofrOMyBpzVoNa06LXOy0+ahanpkR1uMiq70XUG0jiEawp/HKOOnBxPcL1 h77Q== X-Gm-Message-State: AFqh2krmhYYLU5+B6bJ7nuzuzuoh/miUDUzzbSTXaGxigAtTPbbqFZmO 3aUKLPYJaas5x6gcy3qhjbF4eq8wWwYIbDzVnJet9obqqbUUtpB5wQ0/NDfMbergKZFnvdKpmjR jx/vmCqddGsgZUT2HPaeHAb1bi073u7kcdOo= X-Received: by 2002:a0d:ebc7:0:b0:4d2:df5d:4f8a with SMTP id u190-20020a0debc7000000b004d2df5d4f8amr2479250ywe.11.1673957074954; Tue, 17 Jan 2023 04:04:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXtHxspuMUbwpLPxkzC/BX7aJ3whS1J+KUFaZG4ER3Z2qEHdLvNUwS4DQIn2g/GbJHhFhtDxaQ== X-Received: by 2002:a0d:ebc7:0:b0:4d2:df5d:4f8a with SMTP id u190-20020a0debc7000000b004d2df5d4f8amr2479226ywe.11.1673957074632; Tue, 17 Jan 2023 04:04:34 -0800 (PST) Received: from gerbillo.redhat.com (146-241-115-179.dyn.eolo.it. [146.241.115.179]) by smtp.gmail.com with ESMTPSA id bi27-20020a05620a319b00b00706a1551428sm634487qkb.6.2023.01.17.04.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 04:04:34 -0800 (PST) Message-ID: <699f6ee109b3a72b2b377f42a78705f47d4a77b9.camel@redhat.com> Subject: Re: [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions From: Paolo Abeni To: Heiner Kallweit , Neil Armstrong , Andrew Lunn Cc: Russell King - ARM Linux , David Miller , Eric Dumazet , Jakub Kicinski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." Date: Tue, 17 Jan 2023 13:04:30 +0100 In-Reply-To: <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> References: <03ea260e-f03c-d9d7-6f5f-ff72836f5739@gmail.com> <51abd8ca-8172-edfa-1c18-b1e48231f316@linaro.org> <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230117_040438_557327_FBEE8BE3 X-CRM114-Status: GOOD ( 36.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiBTdW4sIDIwMjMtMDEtMTUgYXQgMjE6MzggKzAxMDAsIEhlaW5lciBLYWxsd2Vp dCB3cm90ZToKPiBPbiAxNS4wMS4yMDIzIDE5OjQzLCBOZWlsIEFybXN0cm9uZyB3cm90ZToKPiA+ IEhpIEhlaW5lciwKPiA+IAo+ID4gTGUgMTUvMDEvMjAyMyDDoCAxODowOSwgSGVpbmVyIEthbGx3 ZWl0IGEgw6ljcml0wqA6Cj4gPiA+IE9uIDE1LjAxLjIwMjMgMTc6NTcsIEFuZHJldyBMdW5uIHdy b3RlOgo+ID4gPiA+IE9uIFN1biwgSmFuIDE1LCAyMDIzIGF0IDA0OjE5OjM3UE0gKzAxMDAsIEhl aW5lciBLYWxsd2VpdCB3cm90ZToKPiA+ID4gPiA+IE9uIG15IFNDMi1iYXNlZCBzeXN0ZW0gdGhl IGdlbnBoeSBkcml2ZXIgd2FzIHVzZWQgYmVjYXVzZSB0aGUgUEhZCj4gPiA+ID4gPiBpZGVudGlm aWVzIGFzIDB4MDE4MDMzMDAuIEl0IHdvcmtzIG5vcm1hbCB3aXRoIHRoZSBtZXNvbiBnMTJhCj4g PiA+ID4gPiBkcml2ZXIgYWZ0ZXIgdGhpcyBjaGFuZ2UuCj4gPiA+ID4gPiBTd2l0Y2ggdG8gUEhZ X0lEX01BVENIX01PREVMIHRvIGNvdmVyIHRoZSBkaWZmZXJlbnQgc3ViLXZlcnNpb25zLgo+ID4g PiA+IAo+ID4gPiA+IEhpIEhlaW5lcgo+ID4gPiA+IAo+ID4gPiA+IEFyZSB0aGVyZSBhbnkgZGF0 YXNoZWV0cyBmb3IgdGhlc2UgZGV2aWNlcz8gQW55dGhpbmcgd2hpY2ggZG9jdW1lbnRzCj4gPiA+ ID4gdGhlIGxvd2VyIG5pYmJsZSByZWFsbHkgaXMgYSByZXZpc2lvbj8KPiA+ID4gPiAKPiA+ID4g PiBJJ20ganVzdCB0cnlpbmcgdG8gYXZvaWQgZnV0dXJlIHByb2JsZW1zIHdoZXJlIHdlIGZpbmQg aXQgaXMgYWN0dWFsbHkKPiA+ID4gPiBhIGRpZmZlcmVudCBQSFksIG5lZWRzIGl0cyBvd24gTUFU Q0hfRVhBQ1QgZW50cnksIGFuZCB0aGVuIHdlIGZpbmQgd2UKPiA+ID4gPiBicmVhayBkZXZpY2Vz IHVzaW5nIDB4MDE4MDMzMDIgd2hpY2ggd2UgaGFkIG5vIGlkZWEgZXhpc3RzLCBidXQgZ290Cj4g PiA+ID4gY292ZXJlZCBieSB0aGlzIGNoYW5nZS4KPiA+ID4gPiAKPiA+ID4gVGhlIFNDMiBwbGF0 Zm9ybSBpbmhlcml0ZWQgYSBsb3QgZnJvbSBHMTJBLCB0aGVyZWZvcmUgaXQncyBwbGF1c2libGUK PiA+ID4gdGhhdCBpdCdzIHRoZSBzYW1lIFBIWS4gQWxzbyB0aGUgdmVuZG9yIGRyaXZlciBmb3Ig U0MyIGdpdmVzIGEgaGludAo+ID4gPiBhcyBpdCBoYXMgdGhlIGZvbGxvd2luZyBjb21wYXRpYmxl IGZvciB0aGUgUEhZOgo+ID4gPiAKPiA+ID4gY29tcGF0aWJsZSA9ICJldGhlcm5ldC1waHktaWQw MTgwLjMzMDEiLCAiZXRoZXJuZXQtcGh5LWllZWU4MDIuMy1jMjIiOwo+ID4gPiAKPiA+ID4gQnV0 IHlvdSdyZSByaWdodCwgSSBjYW4ndCBzYXkgZm9yIHN1cmUgYXMgSSBkb24ndCBoYXZlIHRoZSBk YXRhc2hlZXRzLgo+ID4gCj4gPiBPbiBHMTJBICgmIEdYTCksIHRoZSBQSFkgSUQgaXMgc2V0IGlu IHRoZSBNRElPIE1VWCByZWdpc3RlcnMsCj4gPiBwbGVhc2Ugc2VlOgo+ID4gaHR0cHM6Ly9lbGl4 aXIuYm9vdGxpbi5jb20vbGludXgvbGF0ZXN0L3NvdXJjZS9kcml2ZXJzL25ldC9tZGlvL21kaW8t bXV4LW1lc29uLWcxMmEuYyNMMzYKPiA+IAo+ID4gU28geW91IHNob3VsZCBlaXRoZXIgYWRkIHN1 cHBvcnQgZm9yIHRoZSBQSFkgbXV4IGluIFNDMiBvciBjaGVjawo+ID4gd2hhdCBpcyBpbiB0aGUg RVRIX1BIWV9DTlRMMCByZWdpc3Rlci4KPiA+IAo+IFRoYW5rcyBmb3IgdGhlIGhpbnQuIEkganVz dCBjaGVja2VkIGFuZCByZWFkaW5nIGJhY2sgRVRIX1BIWV9DTlRMMCBhdCB0aGUKPiBlbmQgb2Yg ZzEyYV9lbmFibGVfaW50ZXJuYWxfbWRpbygpIGdpdmVzIG1lIHRoZSBleHBlY3RlZCByZXN1bHQg b2YgMHgzMzAxMDE4MC4KPiBCdXQgc3RpbGwgdGhlIFBIWSByZXBvcnRzIDMzMDAuCj4gRXZlbiBp ZiBJIHdyaXRlIHNvbWUgb3RoZXIgcmFuZG9tIHZhbHVlIHRvIEVUSF9QSFlfQ05UTDAsIEkgZ2V0 IDAxODAvMzMwMAo+IGFzIFBIWSBJRC4KPiAKPiBGb3IgdS1ib290IEkgZm91bmQgdGhlIGZvbGxv d2luZzoKPiAKPiBodHRwczovL2dpdGh1Yi5jb20va2hhZGFzL3UtYm9vdC9ibG9iL2toYWRhcy12 aW00LXItNjRiaXQvZHJpdmVycy9uZXQvcGh5L2FtbG9naWMuYwo+IAo+IHN0YXRpYyBzdHJ1Y3Qg cGh5X2RyaXZlciBhbWxvZ2ljX2ludGVybmFsX2RyaXZlciA9IHsKPiAJLm5hbWUgPSAiTWVzb24g R1hMIEludGVybmFsIFBIWSIsCj4gCS51aWQgPSAweDAxODAzMzAwLAo+IAkubWFzayA9IDB4ZmZm ZmZmZjAsCj4gCS5mZWF0dXJlcyA9IFBIWV9CQVNJQ19GRUFUVVJFUywKPiAJLmNvbmZpZyA9ICZt ZXNvbl9waHlfY29uZmlnLAo+IAkuc3RhcnR1cCA9ICZtZXNvbl9hbWxfc3RhcnR1cCwKPiAJLnNo dXRkb3duID0gJmdlbnBoeV9zaHV0ZG93biwKPiB9Owo+IAo+IFNvIGl0J3MgdGhlIHNhbWUgUEhZ IElEIEknbSBzZWVpbmcgaW4gTGludXguCj4gCj4gTXkgYmVzdCBndWVzcyBpcyB0aGF0IHRoZSBm b2xsb3dpbmcgaXMgdGhlIGNhc2U6Cj4gCj4gVGhlIFBIWSBjb21wYXRpYmxlIHN0cmluZyBpbiBE VCBpcyB0aGUgZm9sbG93aW5nIGluIGFsbCBjYXNlczoKPiBjb21wYXRpYmxlID0gImV0aGVybmV0 LXBoeS1pZDAxODAuMzMwMSIsICJldGhlcm5ldC1waHktaWVlZTgwMi4zLWMyMiI7Cj4gCj4gVGhl cmVmb3JlIGlkIDAxODAvMzMwMSBpcyB1c2VkIGV2ZW4gaWYgdGhlIFBIWSByZXBvcnRzIHNvbWV0 aGluZyBlbHNlLgo+IE1lYW5zIGl0IGRvZXNuJ3QgbWF0dGVyIHdoaWNoIHZhbHVlIHlvdSB3cml0 ZSB0byBFVEhfUEhZX0NOVEwwLgo+IAo+IEkgcmVkdWNlZCB0aGUgY29tcGF0aWJsZSBzdHJpbmcg dG8gY29tcGF0aWJsZSA9ICJldGhlcm5ldC1waHktaWVlZTgwMi4zLWMyMiIKPiBhbmQgdGhpcyBy ZXN1bHRlZCBpbiB0aGUgYWN0dWFsIFBIWSBJRCBiZWluZyB1c2VkLgo+IFlvdSBjb3VsZCBjaGFu Z2UgdGhlIGNvbXBhdGlibGUgaW4gZHRzIHRoZSBzYW1lIHdheSBmb3IgYW55IGcxMmEgc3lzdGVt Cj4gYW5kIEkgYXNzdW1lIHlvdSB3b3VsZCBnZXQgMDE4MC8zMzAwIHRvby4KPiAKPiBSZW1haW5p bmcgcXVlc3Rpb24gaXMgd2h5IHRoZSB2YWx1ZSBpbiBFVEhfUEhZX0NOVEwwIGlzIGlnbm9yZWQu CgpJIFttaXM/XXJlYWQgdGhlIGFib3ZlIGFzIHdlIGNhbid0IGNvbXBsZXRlbHkgcnVsZSBvdXQg QW5kcmV3J3MgZG91YnQsCmFzIHN1Y2ggbWFya2luZyB0aGlzIHBhdGNoIGFzIGNoYW5nZWQgcmVx dWVzdGVkLgoKQ2hlZXJzLAoKUGFvbG8KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE39C3DA78 for ; Tue, 17 Jan 2023 12:05:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236647AbjAQMFY (ORCPT ); Tue, 17 Jan 2023 07:05:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236485AbjAQMFX (ORCPT ); Tue, 17 Jan 2023 07:05:23 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B878A36B15 for ; Tue, 17 Jan 2023 04:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673957076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGd8Gv7zO6+RZus69tR/m6BH1nFkS1nUUO+DcJcAeOU=; b=gC6QjGVqUmmeV9ycolklps4r5JJ13egQSenoj2ZLO1gRnVecd65lzVUmnr0gxw5z7pnrib +7IEMoiZnz9uucxIiKE4a9hEpM6m2U2FSe2xF1h28yqpI3rmsGFbwILYDEgapJUxocvrE2 t0cujwiLyJ3NMru1vM6nseIY0eLsSAc= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-567-RVw27z3bNdi8Q74KRbeXWQ-1; Tue, 17 Jan 2023 07:04:35 -0500 X-MC-Unique: RVw27z3bNdi8Q74KRbeXWQ-1 Received: by mail-yb1-f200.google.com with SMTP id z17-20020a256651000000b007907852ca4dso33667350ybm.16 for ; Tue, 17 Jan 2023 04:04:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EGd8Gv7zO6+RZus69tR/m6BH1nFkS1nUUO+DcJcAeOU=; b=g+Is/8mi7Go8Vpqo1a/KdtQJnBWeNYBsv9RKDtS9S36KXzw+AlNKiGNxqaqkKNxYpW zchJYT34G3QgT13NM5tA99BQpr6YlJa/skq21jKnvsParjV5Aw6HT0ESnl33XNgx6c7/ 13jU8/GyIQYHiA5i6i33xEBtlIoSr9DQzqletS0Y50XyH1KPb7lPPhWuBY8SBpoL76ac f/ol6yW4aBiJLFvsBVxankhiB5h7z/DJ4T8yFio+opmAnhsr9eA47tReNHTAWDZ5Op+9 Tzyj1MXU6d84zT0C8knpnJ0vsRGnqdnNrSIlo+QJ9jZQ50L9rdk7OvOMJcvDK1jdZLS+ 4Kyg== X-Gm-Message-State: AFqh2koK2QmBAaUTqBdyot213yAgTobDb28ubUrb4brT6CP7p2XJsAQ1 yr6F0wG3OlS7jnfHMywt8oJsr5wWXKp6AXmn/+SViQ+Sc+vqPSrUK3eam6ULHNX9Q4LYMWvdwUw 218G4X+W6ORvbBVil X-Received: by 2002:a0d:ebc7:0:b0:4d2:df5d:4f8a with SMTP id u190-20020a0debc7000000b004d2df5d4f8amr2479246ywe.11.1673957074953; Tue, 17 Jan 2023 04:04:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXtHxspuMUbwpLPxkzC/BX7aJ3whS1J+KUFaZG4ER3Z2qEHdLvNUwS4DQIn2g/GbJHhFhtDxaQ== X-Received: by 2002:a0d:ebc7:0:b0:4d2:df5d:4f8a with SMTP id u190-20020a0debc7000000b004d2df5d4f8amr2479226ywe.11.1673957074632; Tue, 17 Jan 2023 04:04:34 -0800 (PST) Received: from gerbillo.redhat.com (146-241-115-179.dyn.eolo.it. [146.241.115.179]) by smtp.gmail.com with ESMTPSA id bi27-20020a05620a319b00b00706a1551428sm634487qkb.6.2023.01.17.04.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 04:04:34 -0800 (PST) Message-ID: <699f6ee109b3a72b2b377f42a78705f47d4a77b9.camel@redhat.com> Subject: Re: [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions From: Paolo Abeni To: Heiner Kallweit , Neil Armstrong , Andrew Lunn Cc: Russell King - ARM Linux , David Miller , Eric Dumazet , Jakub Kicinski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." Date: Tue, 17 Jan 2023 13:04:30 +0100 In-Reply-To: <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> References: <03ea260e-f03c-d9d7-6f5f-ff72836f5739@gmail.com> <51abd8ca-8172-edfa-1c18-b1e48231f316@linaro.org> <6de25c61-c187-fb88-5bd7-477b1db1510e@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, On Sun, 2023-01-15 at 21:38 +0100, Heiner Kallweit wrote: > On 15.01.2023 19:43, Neil Armstrong wrote: > > Hi Heiner, > >=20 > > Le 15/01/2023 =C3=A0 18:09, Heiner Kallweit a =C3=A9crit=C2=A0: > > > On 15.01.2023 17:57, Andrew Lunn wrote: > > > > On Sun, Jan 15, 2023 at 04:19:37PM +0100, Heiner Kallweit wrote: > > > > > On my SC2-based system the genphy driver was used because the PHY > > > > > identifies as 0x01803300. It works normal with the meson g12a > > > > > driver after this change. > > > > > Switch to PHY_ID_MATCH_MODEL to cover the different sub-versions. > > > >=20 > > > > Hi Heiner > > > >=20 > > > > Are there any datasheets for these devices? Anything which document= s > > > > the lower nibble really is a revision? > > > >=20 > > > > I'm just trying to avoid future problems where we find it is actual= ly > > > > a different PHY, needs its own MATCH_EXACT entry, and then we find = we > > > > break devices using 0x01803302 which we had no idea exists, but got > > > > covered by this change. > > > >=20 > > > The SC2 platform inherited a lot from G12A, therefore it's plausible > > > that it's the same PHY. Also the vendor driver for SC2 gives a hint > > > as it has the following compatible for the PHY: > > >=20 > > > compatible =3D "ethernet-phy-id0180.3301", "ethernet-phy-ieee802.3-c2= 2"; > > >=20 > > > But you're right, I can't say for sure as I don't have the datasheets= . > >=20 > > On G12A (& GXL), the PHY ID is set in the MDIO MUX registers, > > please see: > > https://elixir.bootlin.com/linux/latest/source/drivers/net/mdio/mdio-mu= x-meson-g12a.c#L36 > >=20 > > So you should either add support for the PHY mux in SC2 or check > > what is in the ETH_PHY_CNTL0 register. > >=20 > Thanks for the hint. I just checked and reading back ETH_PHY_CNTL0 at the > end of g12a_enable_internal_mdio() gives me the expected result of 0x3301= 0180. > But still the PHY reports 3300. > Even if I write some other random value to ETH_PHY_CNTL0, I get 0180/3300 > as PHY ID. >=20 > For u-boot I found the following: >=20 > https://github.com/khadas/u-boot/blob/khadas-vim4-r-64bit/drivers/net/phy= /amlogic.c >=20 > static struct phy_driver amlogic_internal_driver =3D { > .name =3D "Meson GXL Internal PHY", > .uid =3D 0x01803300, > .mask =3D 0xfffffff0, > .features =3D PHY_BASIC_FEATURES, > .config =3D &meson_phy_config, > .startup =3D &meson_aml_startup, > .shutdown =3D &genphy_shutdown, > }; >=20 > So it's the same PHY ID I'm seeing in Linux. >=20 > My best guess is that the following is the case: >=20 > The PHY compatible string in DT is the following in all cases: > compatible =3D "ethernet-phy-id0180.3301", "ethernet-phy-ieee802.3-c22"; >=20 > Therefore id 0180/3301 is used even if the PHY reports something else. > Means it doesn't matter which value you write to ETH_PHY_CNTL0. >=20 > I reduced the compatible string to compatible =3D "ethernet-phy-ieee802.3= -c22" > and this resulted in the actual PHY ID being used. > You could change the compatible in dts the same way for any g12a system > and I assume you would get 0180/3300 too. >=20 > Remaining question is why the value in ETH_PHY_CNTL0 is ignored. I [mis?]read the above as we can't completely rule out Andrew's doubt, as such marking this patch as changed requested. Cheers, Paolo