From: Ritesh Harjani <ritesh.list@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Ritesh Harjani <riteshh@linux.ibm.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.com>, Theodore Ts'o <tytso@mit.edu>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv5 3/5] ext4: mballoc: Introduce pcpu seqcnt for freeing PA to improve ENOSPC handling
Date: Tue, 9 Jun 2020 16:07:41 +0530 [thread overview]
Message-ID: <69a26eb8-e439-6574-6f46-e557d6c852d5@gmail.com> (raw)
In-Reply-To: <20200609102015.GA7696@zn.tnic>
On 6/9/20 3:50 PM, Borislav Petkov wrote:
> On Wed, Jun 03, 2020 at 03:40:16PM +0530, Ritesh Harjani wrote:
>> Yes, this is being discussed in the community.
>> I have submitted a patch which should help fix this warning msg.
>> Feel free to give this a try on your setup.
>>
>> https://marc.info/?l=linux-ext4&m=159110574414645&w=2
>
> I just triggered the same thing here too. Looking at your fix and not
> even pretending to know what's going on with that percpu sequence
> counting, I can't help but wonder why do you wanna do:
>
> seq = *raw_cpu_ptr(&discard_pa_seq);
>
> instead of simply doing:
>
> seq = this_cpu_read(discard_pa_seq);
>
That's correct. Thanks for pointing that out.
I guess in my development version of code I had seq as a u64 pointer
variable which later I had changed to u64 variable but I guess I
continued using pcpu ptr APIs for that.
Let me re-submit that patch with your Suggested-by tag and corresponding
changes.
-riteshh
next prev parent reply other threads:[~2020-06-09 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 6:40 [PATCHv5 0/5] Improve ext4 handling of ENOSPC with multi-threaded use-case Ritesh Harjani
2020-05-20 6:40 ` [PATCHv5 1/5] ext4: mballoc: Add blocks to PA list under same spinlock after allocating blocks Ritesh Harjani
2020-05-20 6:40 ` [PATCHv5 2/5] ext4: mballoc: Refactor ext4_mb_discard_preallocations() Ritesh Harjani
2020-05-20 6:40 ` [PATCHv5 3/5] ext4: mballoc: Introduce pcpu seqcnt for freeing PA to improve ENOSPC handling Ritesh Harjani
2020-06-03 6:48 ` Marek Szyprowski
2020-06-03 10:10 ` Ritesh Harjani
2020-06-09 10:20 ` Borislav Petkov
2020-06-09 10:37 ` Ritesh Harjani [this message]
2020-05-20 6:40 ` [PATCHv5 4/5] ext4: mballoc: Refactor ext4_mb_good_group() Ritesh Harjani
2020-05-20 6:40 ` [PATCHv5 5/5] ext4: mballoc: Use lock for checking free blocks while retrying Ritesh Harjani
2020-05-29 2:40 ` [PATCHv5 0/5] Improve ext4 handling of ENOSPC with multi-threaded use-case Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69a26eb8-e439-6574-6f46-e557d6c852d5@gmail.com \
--to=ritesh.list@gmail.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bp@alien8.de \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.