From: Aadhya-R <raghavendraaadhya@gmail.com>
To: mark.cave-ayland@ilande.co.uk
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: [PATCH v1] disas/sparc: Fix integer overflow and convert to g_malloc
Date: Sun, 15 Mar 2026 12:16:49 +0000 [thread overview]
Message-ID: <69b6a3c2.630a0220.b45bc.5ab2@mx.google.com> (raw)
Change '1 << i' to '1ul << i' to prevent undefined behavior. Also replace standard C allocators with GLib functions to safely handle out-of-memory aborts. Resolves SVACE warning and GitLab issue #1798.
Signed-off-by: Aadhya-R <aadhyar.cs24@rvce.edu.in>
---
disas/sparc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/disas/sparc.c b/disas/sparc.c
index e8f4dcba31..702409a118 100644
--- a/disas/sparc.c
+++ b/disas/sparc.c
@@ -2623,7 +2623,7 @@ build_hash_table (const sparc_opcode **opcode_table,
memset (hash_table, 0, HASH_SIZE * sizeof (hash_table[0]));
memset (hash_count, 0, HASH_SIZE * sizeof (hash_count[0]));
free(hash_buf);
- hash_buf = g_malloc(sizeof (* hash_buf) * num_opcodes);
+ hash_buf = g_malloc(sizeof(*hash_buf) * num_opcodes);
for (i = num_opcodes - 1; i >= 0; --i)
{
int hash = HASH_INSN (opcode_table[i]->match);
@@ -2685,7 +2685,7 @@ print_insn_sparc (bfd_vma memaddr, disassemble_info *info)
if (!opcodes_initialized)
sorted_opcodes =
- g_malloc(sparc_num_opcodes * sizeof (sparc_opcode *));
+ g_malloc(sparc_num_opcodes * sizeof(sparc_opcode *));
/* Reset the sorted table so we can resort it. */
for (i = 0; i < sparc_num_opcodes; ++i)
sorted_opcodes[i] = &sparc_opcodes[i];
--
2.43.0
reply other threads:[~2026-03-15 12:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b6a3c2.630a0220.b45bc.5ab2@mx.google.com \
--to=raghavendraaadhya@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.