From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E240CA0EE8 for ; Wed, 17 Sep 2025 11:05:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uypyF-0007mf-5M; Wed, 17 Sep 2025 07:05:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uypy7-0007lY-OK for grub-devel@gnu.org; Wed, 17 Sep 2025 07:04:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uypy5-0002bF-5j for grub-devel@gnu.org; Wed, 17 Sep 2025 07:04:59 -0400 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58H8btGN011417; Wed, 17 Sep 2025 11:04:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=imPfdl ihZSZOGCLqluwLCyimJSscGIcjJjphyTOfdsw=; b=Za5wc3qfNGTF7I5ay01CYP PHZb6XY4OaHAEKqDlLqu875MWrzkIId3SHCyPDrTo41LjtwH+zalAX2MS9i1a8eE lmc/E5vY9ejYJwJP9LY7Hv9kJ8zgETfP+Ooqk1sX4onT1avahQ2Wt9ddx5AwfQXV ZN4hJLOa9v+G2cIcamOp48ki2yci1x/X89rC0rTQ+Xx5uhHJcGbEF45/caz0PbJs LPwHNnMADqg815rOQUzlKNJeAl3GeX6OKQmkmCMldKV4ccOlf8l2UoAhnCuo/gZY KH9GUQVMm+LzbRr2/GkdvR1Ecp0XeIn8KqHqknWvWHRjm5j3iTEXaszuQjTMdvSQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 497g4nb187-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Sep 2025 11:04:55 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 58HAp3a3030834; Wed, 17 Sep 2025 11:04:54 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 497g4nb186-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Sep 2025 11:04:54 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 58HAA8ir022297; Wed, 17 Sep 2025 11:04:54 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 495kxprvf3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Sep 2025 11:04:54 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 58HB4rKB21758640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Sep 2025 11:04:53 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 226BB58063; Wed, 17 Sep 2025 11:04:53 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C04358059; Wed, 17 Sep 2025 11:04:52 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 17 Sep 2025 11:04:52 +0000 (GMT) MIME-Version: 1.0 Date: Wed, 17 Sep 2025 16:34:52 +0530 From: Avnish Chouhan To: mchang@suse.com Cc: grub-devel@gnu.org, ngompa13@gmail.com, mlewando@redhat.com, Daniel Kiper Subject: Re: [PATCH v2 3/9] util/grub-editenv: add fs_envblk write helper In-Reply-To: References: Message-ID: <69bf54feabed8c47dc40f6981eb9ed5b@linux.ibm.com> X-Sender: avnish@linux.ibm.com X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=MN5gmNZl c=1 sm=1 tr=0 ts=68ca95d7 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=kj9zAlcOel0A:10 a=yJojWOMRYYMA:10 a=mDV3o1hIAAAA:8 a=iox4zFpeAAAA:8 a=pGLkceISAAAA:8 a=20KFwNOVAAAA:8 a=EM3ZBdo1ZqxDZlnRkjIA:9 a=CjuIK1q_8ugA:10 a=WzC6qhA0u3u7Ye7llzcV:22 X-Proofpoint-GUID: UDWbZCTus-X9GLHpl8GCITHO5Z3rNLN8 X-Proofpoint-ORIG-GUID: QVSFvbCZb6HU5rka69onDDJQCZqpP2Qu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTE2MDIwNCBTYWx0ZWRfX7RWuhqH9kP8g rGTEwWVJivveiNXqDOlwznZqWAvuRyw8qVp02CbG9ToUtCL24+bVVqkuZBvfpp8CT5vspXVQ8R3 odO8faBfcdhKvBQVY1ZazE40AjTASlkToMtffjb1ebb09P4ZK31WIgJPsqqbVIjiAzXhhbh6MQV TKwYD6XEBDz7Oadf7NYiVOKXnWj7uHyVk0WGyQVAL9eL3whG2yoHSZXG13Nxd2sZbS0S0WqD0Wm n30M1piiJMDKgTQSGJkzohYySeS1CVdH9UjOYSOoIkL0XNUF7wKtiK74MKtGILgkZ+DEUHxIOM2 bj831h9W5CDYyvAWS4okuzi7aRfUdYuwiY/hiHK1RhT4KGxj+xrCya99LCmSOr9S/r8k4Fd7Mph dPtRrhqX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-17_01,2025-09-17_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509160204 Received-SPF: pass client-ip=148.163.158.5; envelope-from=avnish@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org T24gMjAyNS0wOS0xNSAxNDozOSwgZ3J1Yi1kZXZlbC1yZXF1ZXN0QGdudS5vcmcgd3JvdGU6CiAg PiBNZXNzYWdlOiA0Cj4gRGF0ZTogTW9uLCAxNSBTZXAgMjAyNSAxNzowODo0MiArMDgwMAo+IEZy b206IE1pY2hhZWwgQ2hhbmcgPG1jaGFuZ0BzdXNlLmNvbT4KPiBUbzogVGhlIGRldmVsb3BtZW50 IG9mIEdOVSBHUlVCIDxncnViLWRldmVsQGdudS5vcmc+Cj4gQ2M6IE5lYWwgR29tcGEgPG5nb21w YTEzQGdtYWlsLmNvbT4sCU1hcnRhIExld2FuZG93c2thCj4gCTxtbGV3YW5kb0ByZWRoYXQuY29t Pgo+IFN1YmplY3Q6IFtQQVRDSCB2MiAzLzldIHV0aWwvZ3J1Yi1lZGl0ZW52OiBhZGQgZnNfZW52 YmxrIHdyaXRlIGhlbHBlcgo+IE1lc3NhZ2UtSUQ6IDwyMDI1MDkxNTA5MDg0OC4xMzE5MzctNC1t Y2hhbmdAc3VzZS5jb20+Cj4gCj4gVGhpcyBwYXRjaCBhZGRzIHRoZSBmdW5jdGlvbiBmc19lbnZi bGtfd3JpdGUgdG8gdXBkYXRlIHRoZSByZXNlcnZlZAo+IGVudmlyb25tZW50IGJsb2NrIG9uIGRp c2suIFRoZSBoZWxwZXIgdGFrZXMgYW4gaW4gbWVtb3J5IGVudmJsayBidWZmZXIKPiBhbmQgd3Jp dGVzIGl0IGJhY2sgdG8gdGhlIGRldmljZSBhdCB0aGUgbG9jYXRpb24gZGVmaW5lZCBieSB0aGUK PiBmc19lbnZibGsgc3BlY2lmaWNhdGlvbi4gSXQgcGVyZm9ybXMgc2l6ZSBjaGVja3MgYW5kIHVz ZXMgZmlsZSBzeW5jIHRvCj4gZW5zdXJlIHRoYXQgdGhlIHVwZGF0ZWQgZGF0YSBpcyBmbHVzaGVk Lgo+IAo+IFRoZSBoZWxwZXIgaXMgYWxzbyBhZGRlZCBpbnRvIHRoZSBmc19lbnZibGsgb3BzIHRh YmxlLCB0b2dldGhlciB3aXRoIAo+IHRoZQo+IG9wZW4gaGVscGVyIGZyb20gdGhlIHByZXZpb3Vz IHBhdGNoLiBXaXRoIHRoaXMgY2hhbmdlIHRoZSBiYXNpYyBpbnB1dAo+IGFuZCBvdXRwdXQgcGF0 aCBmb3IgYW4gZXh0ZXJuYWwgZW52aXJvbm1lbnQgYmxvY2sgaXMgY29tcGxldGUuIFRoZQo+IGNo b2ljZSBvZiB3aGljaCB2YXJpYWJsZXMgc2hvdWxkIGJlIHdyaXR0ZW4gZXh0ZXJuYWxseSB3aWxs IGJlIGhhbmRsZWQKPiBieSBsYXRlciBwYXRjaGVzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1pY2hh ZWwgQ2hhbmcgPG1jaGFuZ0BzdXNlLmNvbT4KPiAtLS0KPiAgdXRpbC9ncnViLWVkaXRlbnYuYyB8 IDM4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4gIDEgZmlsZSBjaGFu Z2VkLCAzNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3V0 aWwvZ3J1Yi1lZGl0ZW52LmMgYi91dGlsL2dydWItZWRpdGVudi5jCj4gaW5kZXggNGU1ZGZmYTg2 Li4yNmE4MWQyZDAgMTAwNjQ0Cj4gLS0tIGEvdXRpbC9ncnViLWVkaXRlbnYuYwo+ICsrKyBiL3V0 aWwvZ3J1Yi1lZGl0ZW52LmMKPiBAQCAtMTMxLDkgKzEzMSwxMSBAQCBzdHJ1Y3QgZnNfZW52Ymxr X3NwZWMgewo+ICB0eXBlZGVmIHN0cnVjdCBmc19lbnZibGtfc3BlYyAqZnNfZW52YmxrX3NwZWNf dDsKPiAKPiAgc3RhdGljIGdydWJfZW52YmxrX3QgZnNfZW52YmxrX29wZW4gKGdydWJfZW52Ymxr X3QgZW52YmxrKTsKPiArc3RhdGljIHZvaWQgZnNfZW52YmxrX3dyaXRlIChncnViX2VudmJsa190 IGVudmJsayk7Cj4gCj4gIHN0cnVjdCBmc19lbnZibGtfb3BzIHsKPiAgICBncnViX2VudmJsa190 ICgqb3BlbikgKGdydWJfZW52YmxrX3QpOwo+ICsgIHZvaWQgKCp3cml0ZSkgKGdydWJfZW52Ymxr X3QpOwo+ICB9Owo+IAo+ICBzdHJ1Y3QgZnNfZW52YmxrIHsKPiBAQCAtMTQ0LDcgKzE0Niw4IEBA IHN0cnVjdCBmc19lbnZibGsgewo+ICB0eXBlZGVmIHN0cnVjdCBmc19lbnZibGsgKmZzX2VudmJs a190Owo+IAo+ICBzdGF0aWMgc3RydWN0IGZzX2VudmJsa19vcHMgZnNfZW52YmxrX29wcyA9IHsK PiAtICAub3BlbiA9IGZzX2VudmJsa19vcGVuCj4gKyAgLm9wZW4gPSBmc19lbnZibGtfb3BlbiwK PiArICAud3JpdGUgPSBmc19lbnZibGtfd3JpdGUKPiAgfTsKPiAKPiAgc3RhdGljIHN0cnVjdCBm c19lbnZibGtfc3BlYyBmc19lbnZibGtfc3BlY1tdID0gewo+IEBAIC0zNTgsNiArMzYxLDM5IEBA IHdyaXRlX2VudmJsayAoY29uc3QgY2hhciAqbmFtZSwgZ3J1Yl9lbnZibGtfdCAKPiBlbnZibGsp Cj4gICAgZmNsb3NlIChmcCk7Cj4gIH0KPiAKPiArc3RhdGljIHZvaWQKPiArZnNfZW52YmxrX3dy aXRlIChncnViX2VudmJsa190IGVudmJsaykKPiArewo+ICsgIEZJTEUgKmZwOwo+ICsgIGNvbnN0 IGNoYXIgKmRldmljZTsKPiArICBvZmZfdCBvZmZzZXQ7Cj4gKyAgc2l6ZV90IHNpemU7Cj4gKwo+ ICsgIGlmIChlbnZibGsgPT0gTlVMTCkKPiArICAgIHJldHVybjsKPiArCj4gKyAgZGV2aWNlID0g ZnNfZW52YmxrLT5kZXY7Cj4gKyAgb2Zmc2V0ID0gZnNfZW52YmxrLT5zcGVjLT5vZmZzZXQ7Cj4g KyAgc2l6ZSA9IGZzX2VudmJsay0+c3BlYy0+c2l6ZTsKPiArCj4gKyAgaWYgKGdydWJfZW52Ymxr X3NpemUgKGVudmJsaykgPiBzaXplKQo+ICsgICAgZ3J1Yl91dGlsX2Vycm9yICgiJXMiLCBfKCJl bnZpcm9ubWVudCBibG9jayB0b28gc21hbGwiKSk7Cj4gKwo+ICsgIGZwID0gZ3J1Yl91dGlsX2Zv cGVuIChkZXZpY2UsICJyK2IiKTsKPiArCj4gKyAgaWYgKCEgZnApCgpIaSBNaWNoYWVsLAoKKGZw ID09IE5VTCkgd291bGQgYmUgYmV0dGVyIGhlcmUuCgo+ICsgICAgZ3J1Yl91dGlsX2Vycm9yIChf KCJjYW5ub3Qgb3BlbiBgJXMnOiAlcyIpLCBkZXZpY2UsIHN0cmVycm9yIAo+IChlcnJubykpOwo+ ICsKPiArICBpZiAoZnNlZWsgKGZwLCBvZmZzZXQsIFNFRUtfU0VUKSA8IDApCgpmY2xvc2UgKGZw KSBtaXNzaW5nIGhlcmUhCgo+ICsgICAgZ3J1Yl91dGlsX2Vycm9yIChfKCJjYW5ub3Qgc2VlayBg JXMnOiAlcyIpLCBkZXZpY2UsIHN0cmVycm9yIAo+IChlcnJubykpOwo+ICsKPiArICBpZiAoZndy aXRlIChncnViX2VudmJsa19idWZmZXIgKGVudmJsayksIDEsIGdydWJfZW52YmxrX3NpemUKPiAo ZW52YmxrKSwgZnApICE9IGdydWJfZW52YmxrX3NpemUgKGVudmJsaykpCgpmY2xvc2UgKGZwKSBt aXNzaW5nIGhlcmUhCgpUaGFuayB5b3UhCgpSZWdhcmRzLApBdm5pc2ggQ2hvdWhhbgoKPiArICAg IGdydWJfdXRpbF9lcnJvciAoXygiY2Fubm90IHdyaXRlIHRvIGAlcyc6ICVzIiksIGRldmljZSwg c3RyZXJyb3IgCj4gKGVycm5vKSk7Cj4gKwo+ICsgIGdydWJfdXRpbF9maWxlX3N5bmMgKGZwKTsK PiArICBmY2xvc2UgKGZwKTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQKPiAgc2V0X3ZhcmlhYmxl cyAoY29uc3QgY2hhciAqbmFtZSwgaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKPiAgewo+IC0tCj4g Mi41MS4wCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpH cnViLWRldmVsIG1haWxpbmcgbGlzdApHcnViLWRldmVsQGdudS5vcmcKaHR0cHM6Ly9saXN0cy5n bnUub3JnL21haWxtYW4vbGlzdGluZm8vZ3J1Yi1kZXZlbAo=