From: Dan Williams <djbw@kernel.org>
To: Gregory Price <gourry@gourry.net>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, dave@stgolabs.net,
jonathan.cameron@huawei.com, dave.jiang@intel.com,
alison.schofield@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com
Subject: Re: [PATCH v5 2/3] cxl/core/region: move dax region device logic into region_dax.c
Date: Sat, 11 Apr 2026 10:39:32 -0700 [thread overview]
Message-ID: <69da8754369b4_6c31a10069@djbw-dev.notmuch> (raw)
In-Reply-To: <adnXeR7rOEByIg6n@gourry-fedora-PF4VCD3F>
Gregory Price wrote:
> On Fri, Apr 10, 2026 at 05:02:00PM -0700, Anisa Su wrote:
> > > +
> > > + cxlr_dax->hpa_range.start = p->res->start;
> > > + cxlr_dax->hpa_range.end = p->res->end;
> > > +
> > > + dev = &cxlr_dax->dev;
> > > + cxlr_dax->cxlr = cxlr;
> > cxlr->cxlr_dax = cxlr_dax;
> >
> > Running into segfaults without this ^
>
> This should have been a purely non-functional change (the code is just
> moving from A to B without changes).
>
> That would mean the original code should run into this too unless I
> mucked up the move.
I do not think you mucked anything up ->cxlr_dax does not exist in mainline.
next prev parent reply other threads:[~2026-04-11 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 2:02 [PATCH v5 0/3] pull region-specific logic into new files Gregory Price
2026-03-27 2:02 ` [PATCH v5 1/3] cxl/core/region: move pmem region driver logic into region_pmem.c Gregory Price
2026-03-27 16:56 ` Ira Weiny
2026-03-27 2:02 ` [PATCH v5 2/3] cxl/core/region: move dax region device logic into region_dax.c Gregory Price
2026-03-27 16:57 ` Ira Weiny
2026-04-11 0:02 ` Anisa Su
2026-04-11 0:26 ` Dave Jiang
2026-04-11 5:09 ` Gregory Price
2026-04-11 17:39 ` Dan Williams [this message]
2026-04-13 17:00 ` Anisa Su
2026-03-27 2:02 ` [PATCH v5 3/3] cxl/core: use cleanup.h for devm_cxl_add_dax_region Gregory Price
2026-03-27 17:05 ` Ira Weiny
2026-03-27 18:57 ` [PATCH v5 0/3] pull region-specific logic into new files Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69da8754369b4_6c31a10069@djbw-dev.notmuch \
--to=djbw@kernel.org \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gourry@gourry.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=kernel-team@meta.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.