From: Jake S <j@metarealtyinc.ca>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, ville.syrjala@linux.intel.com
Subject: Re: [PATCH 2/2] drm/i915/display: allow eDP VRR when EDID has adaptive sync range
Date: Wed, 15 Apr 2026 19:39:11 +0000 [thread overview]
Message-ID: <69dfe960.050a0220.1c3509.e29e@mx.google.com> (raw)
In-Reply-To: <20260415130626.10523-3-j@metarealtyinc.ca>
Hi Ville,
> It's in the LFP power block (44).
You're right -- I checked and intel_vbt_decode shows:
BDB block 44 - LFP power conservation features block:
Variable Refresh Rate (VRR): yes
And looking at the code, panel->vbt.vrr defaults to true at line
1370 of intel_bios.c anyway. So the VBT gate was never the problem.
The actual issue is the final check in intel_vrr_is_capable():
return info->monitor_range.max_vfreq - min_vfreq > 10;
monitor_range is 0/0 because this panel's EDID has no base block
Range Limits descriptor (tag 0xFD). The VRR range is only in the
DisplayID v2.0 Adaptive Sync block (tag 0x2B), which drm_edid.c
doesn't parse into monitor_range.
So patch 2/2 (the VBT relaxation) is unnecessary and I'll drop it.
Only patch 1/2 (parsing DisplayID tag 0x2B into monitor_range) is
needed. I'll send a v2 with just that patch.
Sorry for the noise on the VBT front -- should have traced the
actual failure path more carefully before assuming.
Thanks,
Jake
next prev parent reply other threads:[~2026-04-16 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 13:06 [PATCH 0/2] drm: Enable eDP VRR for panels with DisplayID Adaptive Sync Jake S
2026-04-15 13:06 ` [PATCH 1/2] drm/edid: populate monitor_range from DisplayID Adaptive Sync block Jake S
2026-04-15 13:06 ` [PATCH 2/2] drm/i915/display: allow eDP VRR when EDID has adaptive sync range Jake S
2026-04-15 14:01 ` Ville Syrjälä
2026-04-15 19:08 ` Jake S
2026-04-15 19:16 ` Ville Syrjälä
2026-04-15 19:39 ` Jake S [this message]
2026-04-15 14:05 ` [PATCH 0/2] drm: Enable eDP VRR for panels with DisplayID Adaptive Sync Ville Syrjälä
2026-04-15 19:08 ` Jake S
2026-04-16 13:21 ` ✗ LGCI.VerificationFailed: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69dfe960.050a0220.1c3509.e29e@mx.google.com \
--to=j@metarealtyinc.ca \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.