All of lore.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+3e2c95229d1ab81a0bfd@syzkaller.appspotmail.com>
To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Forwarded: Re: [syzbot] WARNING in rgblk_free
Date: Fri, 17 Apr 2026 09:21:35 -0700	[thread overview]
Message-ID: <69e25e0f.050a0220.1de265.002d.GAE@google.com> (raw)
In-Reply-To: <69651807.050a0220.eaf7.00b2.GAE@google.com>

For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.

***

Subject: Re: [syzbot] WARNING in rgblk_free
Author: tristmd@gmail.com

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>From 4649cf253677e3ba7f3266916dfe24fecc0e3b69 Mon Sep 17 00:00:00 2001
From: Tristan Madani <tristan@talencesecurity.com>
Date: Fri, 17 Apr 2026 16:15:19 +0000
Subject: [PATCH] gfs2: replace WARN_ON_ONCE with error message in rgblk_free()
rgblk_free() uses WARN_ON_ONCE when gfs2_rbm_from_block() fails,
which triggers a kernel WARNING on corrupted filesystems. Replace
with fs_warn() to log the error without triggering a WARNING splat.
Reported-by: syzbot+3e2c95229d1ab81a0bfd@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=3e2c95229d1ab81a0bfd
Signed-off-by: Tristan Madani <tristan@talencesecurity.com>
---
 fs/gfs2/rgrp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 5988a16..a7c1965 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -2264,8 +2264,11 @@ static void rgblk_free(struct gfs2_sbd *sdp, struct gfs2_rgrpd *rgd,
 	struct gfs2_bitmap *bi, *bi_prev = NULL;
 
 	rbm.rgd = rgd;
-	if (WARN_ON_ONCE(gfs2_rbm_from_block(&rbm, bstart)))
+	if (gfs2_rbm_from_block(&rbm, bstart)) {
+		fs_warn(sdp, "rgblk_free: block %llu outside rgrp\n",
+			(unsigned long long)bstart);
 		return;
+	}
 	while (blen--) {
 		bi = rbm_bi(&rbm);
 		if (bi != bi_prev) {
-- 
2.47.3

  parent reply	other threads:[~2026-04-17 16:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 15:49 [syzbot] [gfs2?] WARNING in rgblk_free (2) syzbot
2026-01-12 19:12 ` Andrew Price
2026-01-12 19:34   ` syzbot
2026-04-17 10:12 ` Forwarded: [PATCH] gfs2: replace WARN_ON_ONCE with error message in syzbot
2026-04-17 16:21 ` syzbot [this message]
2026-04-18 12:57 ` Forwarded: Re: [syzbot] WARNING in rgblk_free (2) syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69e25e0f.050a0220.1de265.002d.GAE@google.com \
    --to=syzbot+3e2c95229d1ab81a0bfd@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.