All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Denholm <nod.helm@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, greend@obbligato.org, apenwarr@gmail.com,
	gpmcgee@gmail.com, mmogilvi_git@miniinfo.net
Subject: Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass
Date: Tue, 06 May 2014 07:54:30 +1000	[thread overview]
Message-ID: <69f827ea-0ba2-4ca0-b711-002e1a0010b7@email.android.com> (raw)
In-Reply-To: <20140505050803.GA6569@sigill.intra.peff.net>

On 5 May 2014 15:08:04 GMT+10:00, Jeff King <peff@peff.net> wrote:
>On Sat, May 03, 2014 at 10:49:30PM +1000, James Denholm wrote:
>
>> The main issues are that calls are made to git itself in the build
>> process, and that a subtree-exclusive variable is used for specifying
>> the exec path. Patches 1/5 through 3/5 resolve these.
>> 
>> The "cleanup" fixes (4/5 and 5/5) are based on precedents set by
>other
>> makefiles across the project.
>
>Thanks, these all look sane to me (I do not use subtree, but since it's
>just about Makefiles, it was pretty easy to review).

Thanks for the review!

Given that subtree subtree doesn't really generate a lot of discussion,
would it be advisable to wrap this up (barring further discussion) and send
it off to Junio rather than waiting for further community consensus?

Regards,
James Denholm.

  reply	other threads:[~2014-05-06 16:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-03 12:49 [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass James Denholm
2014-05-03 12:49 ` [PATCH v2 1/5] contrib/subtree/Makefile: scrap unused $(gitdir) James Denholm
2014-05-03 12:49   ` [PATCH v2 2/5] contrib/subtree/Makefile: Use GIT-VERSION-FILE James Denholm
2014-05-03 12:49     ` [PATCH v2 3/5] contrib/subtree/Makefile: s/libexecdir/gitexecdir James Denholm
2014-05-03 12:49       ` [PATCH v2 4/5] contrib/subtree/Makefile: Doc-gen rules cleanup James Denholm
2014-05-03 12:49         ` [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup James Denholm
2014-05-05  5:09           ` Jeff King
2014-05-05 21:41             ` James Denholm
2014-05-05 21:49               ` Jeff King
2014-05-05 21:59                 ` James Denholm
2014-05-05  5:08 ` [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass Jeff King
2014-05-05 21:54   ` James Denholm [this message]
2014-05-05 22:01     ` Jeff King
2014-05-06 12:41       ` James Denholm
  -- strict thread matches above, loose matches on Subject: below --
2014-05-06 12:41 James Denholm
2014-05-06 21:17 ` Junio C Hamano
2014-05-06 21:46   ` James Denholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69f827ea-0ba2-4ca0-b711-002e1a0010b7@email.android.com \
    --to=nod.helm@gmail.com \
    --cc=apenwarr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gpmcgee@gmail.com \
    --cc=greend@obbligato.org \
    --cc=mmogilvi_git@miniinfo.net \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.