From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94CA3C38A2D for ; Wed, 26 Oct 2022 14:33:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6FECE3CB1; Wed, 26 Oct 2022 16:32:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6FECE3CB1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666794778; bh=j/+TzUZKjPg6AiDdPdUrU7skNxekli5IAwJzr55tM8E=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EpyXnoUXJf7U6ifE+KpTYgYx7FFOX7F73hL0b8jdsnqSan8y9nDgJredNxisPAiYY JAAzjUKruRAwyo3Oo1gUwgaopIt9V8Sx7G0c0bgTbwck0F9P44qTCeRP+qtdhMhLJZ Tu4DiCHScGSwx7KRL0fkbJwdkfWo7OJZVa9VbEs8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F1BE6F80240; Wed, 26 Oct 2022 16:32:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0616DF80271; Wed, 26 Oct 2022 16:32:07 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5DFADF80100 for ; Wed, 26 Oct 2022 16:31:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5DFADF80100 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="L7ocpzWK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666794721; x=1698330721; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=j/+TzUZKjPg6AiDdPdUrU7skNxekli5IAwJzr55tM8E=; b=L7ocpzWKFDu3Pkk7IAL+bwSe92qntaZFh3Hft4y0/YDc49h/uEBOWMlB nwiooJwHY5sNS2mYSZjKWhmeZZTJuPdXi4QGcPZ/Rj0N/ZoRkMWQxwd1e EIOm0hOa/O+rDtvkm42Ochum1yIIKnv6d5ibxaONSjswQ17iNDY9fvj+l BruboRBsgG5PCYKTAwpTU6uzaEfdPQeq4NbB0E+3+UuMnX47XWwx9YKbH 0pOUNs7o1H74lDioTwQmt6r7inw1f5OfwbI3t6FKAAr8fWYnJa1KQ0+a7 7rZwWqClo3ta6XLEpku96DLDW83lDacYdhOpglweLHscdNjIPumDWoMC5 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="306688279" X-IronPort-AV: E=Sophos;i="5.95,215,1661842800"; d="scan'208";a="306688279" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2022 07:31:27 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="609972132" X-IronPort-AV: E=Sophos;i="5.95,215,1661842800"; d="scan'208";a="609972132" Received: from chaosong-mobl.ccr.corp.intel.com (HELO [10.255.29.191]) ([10.255.29.191]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2022 07:31:24 -0700 Message-ID: <69fa20ca-da52-b85f-ffcc-66a533471568@linux.intel.com> Date: Wed, 26 Oct 2022 22:31:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2] ASoC: sun50i-dmic: avoid unused variable warning for sun50i_dmic_of_match Content-Language: en-US To: Ban Tao , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org References: <1666511085-2748-1-git-send-email-fengzheng923@gmail.com> From: Chao Song In-Reply-To: <1666511085-2748-1-git-send-email-fengzheng923@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/23/2022 3:44 PM, Ban Tao wrote: > In configurations with CONFIG_OF=n, we get a harmless build warning: > > sound/soc/sunxi/sun50i-dmic.c:268:34: warning: unused variable > 'sun50i_dmic_of_match' [-Wunused-const-variable] > > Signed-off-by: Ban Tao > Reported-by: kernel test robot > Acked-by: Jernej Skrabec > --- > v1->v2:Add "Acked-by" tag. > --- > sound/soc/sunxi/sun50i-dmic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c > index 86cff5a..62509cb 100644 > --- a/sound/soc/sunxi/sun50i-dmic.c > +++ b/sound/soc/sunxi/sun50i-dmic.c > @@ -391,7 +391,7 @@ static const struct dev_pm_ops sun50i_dmic_pm = { > static struct platform_driver sun50i_dmic_driver = { > .driver = { > .name = "sun50i-dmic", > - .of_match_table = of_match_ptr(sun50i_dmic_of_match), > + .of_match_table = sun50i_dmic_of_match, I don't think this is the right direction (remove the of_match_ptr) to fix the issue. of_match_ptr(of_table) returns of_table if CONFIG_OF=y, and returns NULL if CONFIG_OF=n. So guard  the definition of sun50i_dmic_of_match with `#ifdef CONFIG_OF` should be better. Many other drivers do it this way. > .pm = &sun50i_dmic_pm, > }, > .probe = sun50i_dmic_probe, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEDBCC433FE for ; Wed, 26 Oct 2022 14:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hyDD/5sb2XXooQi8ukyFNLC2w35hMBPSSlOSGo3s/vY=; b=cH856AbuxI72WB XsL396luSLx1clAmf3HtRt1XRwBAi3VwJ1ZV9ORpVNgz9I8GXk4GIVoPeKNqId+pP7PiIlB3NaDfh 70j998UhSS5X2qFHu6h4AZIpEZCxAOJnmlinKdSpcPAaNcjYawlv8gPlw+vgpglGVMn7aHNis/3Jh 1iDq7Yz2LGsGdUdj6RaeF321fD4v0Srd1Byz8/dUxp6OTQ8mvw7YSoO7181y1Lu2Nz7pezqgW8P+v 7o85AzRQZWz4VvG8SzShhRhBV1Q0C+3CGJHEYD+Kxc1iqcILCbUR0GYg4ok5MS4yU68QDXEYufx4B 6+aq0Th44ygiYr1JmgSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onhRX-009gqV-CQ; Wed, 26 Oct 2022 14:31:43 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onhRU-009goX-L8 for linux-arm-kernel@lists.infradead.org; Wed, 26 Oct 2022 14:31:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666794700; x=1698330700; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=j/+TzUZKjPg6AiDdPdUrU7skNxekli5IAwJzr55tM8E=; b=jQSD4wCPw4ME9Jp0gtli87xXjbb8yA/CuAYSCdjNiot1B91g/dKUbtp5 h7zLydeDRJVS5aBCJSHtUCJDWddC7G0PWVywWzQMJYntF3zp87y1QsIzq vWtU24shPqBItvhfj5klgjKZjBNe0Bch3EJlg8afAw0+YQ58WDRX8hj4R 6mf9/mzjruSclcYmz/GmKRRtZ6EgMcxNY+OeCrQngQNzn2jdLaX7kfnwR s/f3pPXbosu6cUE0l3nuThFW7hjKhbOOzUsOE4P0GdwzRMfWM/q1h17Wr aH1LhCC7pwnzHVBymTFkS4jrZTFFmts76OHBY00YcyPNw9T+aeJjrBonA w==; X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="287674341" X-IronPort-AV: E=Sophos;i="5.95,215,1661842800"; d="scan'208";a="287674341" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2022 07:31:27 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="609972132" X-IronPort-AV: E=Sophos;i="5.95,215,1661842800"; d="scan'208";a="609972132" Received: from chaosong-mobl.ccr.corp.intel.com (HELO [10.255.29.191]) ([10.255.29.191]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2022 07:31:24 -0700 Message-ID: <69fa20ca-da52-b85f-ffcc-66a533471568@linux.intel.com> Date: Wed, 26 Oct 2022 22:31:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2] ASoC: sun50i-dmic: avoid unused variable warning for sun50i_dmic_of_match Content-Language: en-US To: Ban Tao , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org Cc: alsa-devel@alsa-project.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1666511085-2748-1-git-send-email-fengzheng923@gmail.com> From: Chao Song In-Reply-To: <1666511085-2748-1-git-send-email-fengzheng923@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221026_073140_731711_1F1B5F06 X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDEwLzIzLzIwMjIgMzo0NCBQTSwgQmFuIFRhbyB3cm90ZToKPiBJbiBjb25maWd1cmF0aW9u cyB3aXRoIENPTkZJR19PRj1uLCB3ZSBnZXQgYSBoYXJtbGVzcyBidWlsZCB3YXJuaW5nOgo+Cj4g c291bmQvc29jL3N1bnhpL3N1bjUwaS1kbWljLmM6MjY4OjM0OiB3YXJuaW5nOiB1bnVzZWQgdmFy aWFibGUKPiAnc3VuNTBpX2RtaWNfb2ZfbWF0Y2gnIFstV3VudXNlZC1jb25zdC12YXJpYWJsZV0K Pgo+IFNpZ25lZC1vZmYtYnk6IEJhbiBUYW8gPGZlbmd6aGVuZzkyM0BnbWFpbC5jb20+Cj4gUmVw b3J0ZWQtYnk6IGtlcm5lbCB0ZXN0IHJvYm90IDxsa3BAaW50ZWwuY29tPgo+IEFja2VkLWJ5OiBK ZXJuZWogU2tyYWJlYyA8amVybmVqLnNrcmFiZWNAZ21haWwuY29tPgo+IC0tLQo+IHYxLT52MjpB ZGQgIkFja2VkLWJ5IiB0YWcuCj4gLS0tCj4gICBzb3VuZC9zb2Mvc3VueGkvc3VuNTBpLWRtaWMu YyB8IDIgKy0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQo+Cj4gZGlmZiAtLWdpdCBhL3NvdW5kL3NvYy9zdW54aS9zdW41MGktZG1pYy5jIGIvc291bmQv c29jL3N1bnhpL3N1bjUwaS1kbWljLmMKPiBpbmRleCA4NmNmZjVhLi42MjUwOWNiIDEwMDY0NAo+ IC0tLSBhL3NvdW5kL3NvYy9zdW54aS9zdW41MGktZG1pYy5jCj4gKysrIGIvc291bmQvc29jL3N1 bnhpL3N1bjUwaS1kbWljLmMKPiBAQCAtMzkxLDcgKzM5MSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgZGV2X3BtX29wcyBzdW41MGlfZG1pY19wbSA9IHsKPiAgIHN0YXRpYyBzdHJ1Y3QgcGxhdGZv cm1fZHJpdmVyIHN1bjUwaV9kbWljX2RyaXZlciA9IHsKPiAgIAkuZHJpdmVyICAgICAgICAgPSB7 Cj4gICAJCS5uYW1lICAgPSAic3VuNTBpLWRtaWMiLAo+IC0JCS5vZl9tYXRjaF90YWJsZSA9IG9m X21hdGNoX3B0cihzdW41MGlfZG1pY19vZl9tYXRjaCksCj4gKwkJLm9mX21hdGNoX3RhYmxlID0g c3VuNTBpX2RtaWNfb2ZfbWF0Y2gsCkkgZG9uJ3QgdGhpbmsgdGhpcyBpcyB0aGUgcmlnaHQgZGly ZWN0aW9uIChyZW1vdmUgdGhlIG9mX21hdGNoX3B0cikgdG8gCmZpeCB0aGUgaXNzdWUuCgpvZl9t YXRjaF9wdHIob2ZfdGFibGUpIHJldHVybnMgb2ZfdGFibGUgaWYgQ09ORklHX09GPXksIGFuZCBy ZXR1cm5zIE5VTEwgCmlmIENPTkZJR19PRj1uLgoKU28gZ3VhcmTCoCB0aGUgZGVmaW5pdGlvbiBv ZiBzdW41MGlfZG1pY19vZl9tYXRjaCB3aXRoIGAjaWZkZWYgQ09ORklHX09GYCAKc2hvdWxkIGJl IGJldHRlci4KCk1hbnkgb3RoZXIgZHJpdmVycyBkbyBpdCB0aGlzIHdheS4KCj4gICAJCS5wbSAg ICAgPSAmc3VuNTBpX2RtaWNfcG0sCj4gICAJfSwKPiAgIAkucHJvYmUgICAgICAgICAgPSBzdW41 MGlfZG1pY19wcm9iZSwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK