From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DD18CD4F52 for ; Mon, 18 May 2026 08:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Subject:CC:To:MIME-Version: From:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ux9lyf8vngyhuDjtvdmlYEInh71210LGfd2itPRBQ5o=; b=paBr6YBvLcBBrrQd72TZHOULpC 7p9rxtEETlxWRwycwa35YgD/5x5mGHU6hELmsBJOEqlLdkiaNhYFcXr4Bm0TvLUQ89uUxfbmQNTnC 8ovMGuhJJuDzfFmFUrjQ0PYPLgJzc2RU2pb0FD+QP8DzDA2IOS/Nc7R+YOafnpbuhOJL0g79Hdauw EnGN5FFQH9C3B14IBwcv1Hnr9Hu/i6DZTkHh+DvXBXYBECTvV+HYli7SX6Tqtmv4OQU56Yn4iTwxP T7s6tJGxWiaGuxnFT9VU1e4XrB9714Smq8wS8jjKUs0wLnoHqgZQuPBxafu0USNko5j49LoqMac6M RBvS1Y/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wOtij-0000000EtpB-1hhs; Mon, 18 May 2026 08:53:05 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wOtih-0000000EtoV-2kmL for linux-phy@bombadil.infradead.org; Mon, 18 May 2026 08:53:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=mTxKGHWsaIt1llzqHdUN6v5bUzQJIrrj0LXN9qPguwY=; b=QJZ1vnYrI9YVhaQ0ExaVUb9QeF ozWi9eRm+wppqmHlvossHVodDJc1SXCDicLaVp8FE3F4MaoBqUFbukCI1BlTUnKd1CYKUiB+2qQw1 1pHvRYPUKJZp8Du0fx3PvpxnsahEtLGNUsfzACyBod9cO9dhOrBY330Fev610lfl7iXc6GIVLYaAH 7crqvQTKz9EtftKXbu8Pkf6ptMJDrjrKTrBx7ioANfgWC4WZCFpDw3Y4tKL3wKOeZ4ZbKuUjhzkJS lCEGskR4QugjM2OfeR3Uv64GUgB72QrjsMyXdh7SUzCVaPhlzS/Qki8PlsSk24JLleQ9qxfFQjhta Tfze7mSg==; Received: from m16.mail.126.com ([117.135.210.7]) by desiato.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wOtid-0000000AT4O-0DGe for linux-phy@lists.infradead.org; Mon, 18 May 2026 08:53:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Message-ID:Date:From:MIME-Version:To:Subject: Content-Type; bh=mTxKGHWsaIt1llzqHdUN6v5bUzQJIrrj0LXN9qPguwY=; b=h0Zzw4oYBB39BQ+m3RGzgYjWgiYLvv11qOq1qEsHEOm0YwudrZiOrZUr5Ddqcj CU+mQLyFEiXqBYELTewwvw9M2sjDH1liDC4jFckPYX4k/LumZwX23xQrLMVyTnPr Tla4bQjkoR5/7ddbNngC6BW6CyBaq/BCAbVQBk+56+GhY= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-3 (Coremail) with SMTP id _____wD3zwtR0wpqbmouBw--.14701S2; Mon, 18 May 2026 16:52:33 +0800 (CST) Message-ID: <6A0AD35A.2000800@126.com> Date: Mon, 18 May 2026 16:52:42 +0800 From: Hongling Zeng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Vinod Koul , neil.armstrong@linaro.org, johan@kernel.org, kishon@kernel.org, rogerq@ti.com, sashiko-bo CC: zenghongling , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] phy: ti-pipe3: Fix EPROBE_DEFER handling for clock resources References: <20260518062938.48114-1-zenghongling@kylinos.cn> <20260518062938.48114-4-zenghongling@kylinos.cn> <6A0AC942.40201@126.com> In-Reply-To: <6A0AC942.40201@126.com> X-CM-TRANSID: _____wD3zwtR0wpqbmouBw--.14701S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxCr48Xw1ftw1DZw1xZF15XFb_yoWruryxpF 4DJ3WYyFWvyrWkAw43Xw1Igw1Fvw1xKF4UGrW5Ww1rZ3W3tr1UGF4xKr4jgryUCFW09w4r ta4UXa4YkFyDZ3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j40PfUUUUU= X-Originating-IP: [112.64.161.44] X-CM-SenderInfo: x2kr0wpolqwiqxrzqiyswou0bp/xtbBrhEm9moK01HBBwAA3L X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260518_095300_443524_374313E2 X-CRM114-Status: GOOD ( 25.80 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org LS0gClNhc2hpa28gQUkgcmV2aWV3IKGkaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIw MjYwNTE4MDYyOTM4LjQ4MTE0LTEtemVuZ2hvbmdsaW5nQGt5bGlub3MuY24/cGFydD0zCi0tCgog ICBIaSwKICAgUmVzZW5kIHRvIGZpeCB0aHJlYWRpbmcgLyBkZWxpdmVyeSBpc3N1ZXMuCiAgIFRo YW5rIHlvdSBmb3IgdGhlIHJldmlldy4gWW91IHJhaXNlIGEgdmFsaWQgcG9pbnQgYWJvdXQgdXNp bmcgZGV2X2Vycl9wcm9iZSgpCiAgIHRvIGF2b2lkIGRtZXNnIHNwYW0gZHVyaW5nIHByb2JlIGRl ZmVycmFsLgoKICAgSSd2ZSBrZXB0IGRldl9lcnIoKSBpbiB0aGlzIHBhdGNoIHRvIG1haW50YWlu IGNvbnNpc3RlbmN5IHdpdGggdGhlIGV4aXN0aW5nCiAgIGNvZGUgc3R5bGUgYW5kIGZvY3VzIG9u IHRoZSBjb3JlIEVQUk9CRV9ERUZFUiBmaXhlcy4gSG93ZXZlciwgSSBhZ3JlZSB0aGF0CiAgIGRl dl9lcnJfcHJvYmUoKSB3b3VsZCBiZSBiZXR0ZXIgYW5kIGNhbiBzdWJtaXQgYSBmb2xsb3ctdXAg Y2xlYW51cCBwYXRjaCB0bwogICBhZGRyZXNzIHRoZSBsb2dnaW5nIGltcHJvdmVtZW50LgogICAg CiAgIERvZXMgdGhpcyBhcHByb2FjaCB3b3JrIGZvciB5b3UsIG9yIHdvdWxkIHlvdSBwcmVmZXIg SSBpbmNsdWRlIHRoZSBkZXZfZXJyX3Byb2JlKCkKICAgY2hhbmdlIGluIHRoaXMgc2VyaWVzPwoK ICAgQmVzdCByZWdhcmRzLAogICBIb25nbGluZwoK1NogMjAyNsTqMDXUwjE4yNUgMTY6MDksIEhv bmdsaW5nIFplbmcg0LS1wDoKPiAtLSAKPiBTYXNoaWtvIEFJIHJldmlldyChpGh0dHBzOi8vc2Fz aGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDUxODA2MjkzOC40ODExNC0xLXplbmdob25nbGluZ0Br eWxpbm9zLmNuP3BhcnQ9Mwo+Cj4gLS0gCj4gICAgSGksCj4KPiAgICBUaGFuayB5b3UgZm9yIHRo ZSByZXZpZXcuIFlvdSByYWlzZSBhIHZhbGlkIHBvaW50IGFib3V0IHVzaW5nIGRldl9lcnJfcHJv YmUoKQo+ICAgIHRvIGF2b2lkIGRtZXNnIHNwYW0gZHVyaW5nIHByb2JlIGRlZmVycmFsLgo+Cj4g ICAgSSd2ZSBrZXB0IGRldl9lcnIoKSBpbiB0aGlzIHBhdGNoIHRvIG1haW50YWluIGNvbnNpc3Rl bmN5IHdpdGggdGhlIGV4aXN0aW5nCj4gICAgY29kZSBzdHlsZSBhbmQgZm9jdXMgb24gdGhlIGNv cmUgRVBST0JFX0RFRkVSIGZpeGVzLiBIb3dldmVyLCBJIGFncmVlIHRoYXQKPiAgICBkZXZfZXJy X3Byb2JlKCkgd291bGQgYmUgYmV0dGVyIGFuZCBjYW4gc3VibWl0IGEgZm9sbG93LXVwIGNsZWFu dXAgcGF0Y2ggdG8KPiAgICBhZGRyZXNzIHRoZSBsb2dnaW5nIGltcHJvdmVtZW50Lgo+ICAgICAK PiAgICBEb2VzIHRoaXMgYXBwcm9hY2ggd29yayBmb3IgeW91LCBvciB3b3VsZCB5b3UgcHJlZmVy IEkgaW5jbHVkZSB0aGUgZGV2X2Vycl9wcm9iZSgpCj4gICAgY2hhbmdlIGluIHRoaXMgc2VyaWVz Pwo+Cj4gICAgQmVzdCByZWdhcmRzLAo+ICAgIEhvbmdsaW5nCj4KPgo+INTaIDIwMjbE6jA11MIx OMjVIDE0OjI5LCBIb25nbGluZyBaZW5nINC0tcA6Cj4+IHRpX3BpcGUzX2dldF9jbGsoKSBoYXMg dHdvIGlzc3VlcyB3aXRoIC1FUFJPQkVfREVGRVIgZXJyb3IgaGFuZGxpbmc6Cj4+Cj4+IDEuIFdo ZW4gZGV2bV9jbGtfZ2V0KCkgZm9yIHN5c2NsayBmYWlscywgdGhlIGZ1bmN0aW9uIHJldHVybnMg LUVJTlZBTAo+PiAgICAgaW5zdGVhZCBvZiBwcm9wYWdhdGluZyB0aGUgYWN0dWFsIGVycm9yIGNv ZGUuIFRoaXMgbWFza3MgLUVQUk9CRV9ERUZFUgo+PiAgICAgdG8gLUVJTlZBTCwgYnJlYWtpbmcg dGhlIHByb2JlIGRlZmVycmFsIG1lY2hhbmlzbSBhbmQgY2F1c2luZyBwZXJtYW5lbnQKPj4gICAg IGRyaXZlciBpbml0aWFsaXphdGlvbiBmYWlsdXJlIG9uIHN5c3RlbXMgd2l0aCBub24tZGV0ZXJt aW5pc3RpYyBwcm9iZQo+PiAgICAgb3JkZXJpbmcuCj4+Cj4+IDIuIEZvciBTQVRBIFBIWSByZWZj bGssIHRoZSBmdW5jdGlvbiBpZ25vcmVzIGFsbCBlcnJvcnMgdG8gc3VwcG9ydCBvbGRlcgo+PiAg ICAgRFRCcyBtaXNzaW5nIHRoZSByZWZjbGsgcHJvcGVydHkuIEhvd2V2ZXIsIHRoaXMgaW5jb3Jy ZWN0bHkgaWdub3Jlcwo+PiAgICAgLUVQUk9CRV9ERUZFUiBhcyB3ZWxsLCBjYXVzaW5nIHRoZSBk cml2ZXIgdG8gcHJvY2VlZCB3aXRob3V0IHdhaXRpbmcKPj4gICAgIGZvciB0aGUgY2xvY2sgcHJv dmlkZXIgdG8gYmVjb21lIGF2YWlsYWJsZS4KPj4KPj4gRml4IGJvdGggaXNzdWVzOgo+PiAtIFJl dHVybiBQVFJfRVJSKHBoeS0+c3lzX2NsaykgaW5zdGVhZCBvZiAtRUlOVkFMIHRvIHByb3BhZ2F0 ZSBhbGwKPj4gICAgZXJyb3IgY29kZXMgaW5jbHVkaW5nIC1FUFJPQkVfREVGRVIKPj4gLSBVc2Ug ZGV2bV9jbGtfZ2V0X29wdGlvbmFsKCkgZm9yIFNBVEEgcmVmY2xrIHRvIGhhbmRsZSBvcHRpb25h bAo+PiAgICBjbG9ja3Mgd2hpbGUgcHJvcGFnYXRpbmcgLUVQUk9CRV9ERUZFUiBhbmQgb3RoZXIg ZXJyb3JzCj4+Cj4+IEZpeGVzOiBhNzAxNDNiYmVmNmIgKCJkcml2ZXJzOiBwaHk6IHVzYjMvcGlw ZTM6IEFkYXB0IHBpcGUzIGRyaXZlciB0byBHZW5lcmljIFBIWSBGcmFtZXdvcmsiKQo+PiBGaXhl czogN2YzMzkxMmQyOTc4ICgicGh5OiB0aS1waXBlMzogRml4IFNBVEEgYWNyb3NzIHN1c3BlbmQv cmVzdW1lIikKPj4gU2lnbmVkLW9mZi1ieTogSG9uZ2xpbmcgWmVuZzx6ZW5naG9uZ2xpbmdAa3ls aW5vcy5jbj4KPj4KPj4gLS0tCj4+ICAgIENoYW5nZSBpbiB2NDoKPj4gICAgIC0gTWVyZ2UgcmVm Y2xrIGxlYWsgZml4IGFuZCBFUFJPQkVfREVGRVIgZml4IGludG8gYSBzaW5nbGUgcGF0Y2gKPj4g ICAgIC0gVXNlIGRldm1fY2xrX2dldF9vcHRpb25hbCgpIGZvciBTQVRBIHJlZmNsawo+PiAgICAg LSBEcm9wIG1hbnVhbCAtRU5PRU5UIGhhbmRsaW5nCj4+ICAgICAtIEVuc3VyZSBlcnJvciBwYXRo cyBhcmUgZnVsbHkgc3ltbWV0cmljCj4+IC0tLQo+PiAgICBDaGFuZ2UgaW4gdjU6Cj4+ICAgICAt QWRkIEZpeCBpZ25vcmVkIGNsb2NrIGVuYWJsZSByZXR1cm4gdmFsdWUgaW4gaW5pdCBwYXRjaAo+ PiAtLS0KPj4gICBkcml2ZXJzL3BoeS90aS9waHktdGktcGlwZTMuYyB8IDIwICsrKysrKysrKysr KystLS0tLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDcgZGVsZXRp b25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS90aS9waHktdGktcGlwZTMuYyBi L2RyaXZlcnMvcGh5L3RpL3BoeS10aS1waXBlMy5jCj4+IGluZGV4IDJkMzZmZTRjNDIxOC4uOWVj MjI4YzJhOTQwIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL3BoeS90aS9waHktdGktcGlwZTMuYwo+ PiArKysgYi9kcml2ZXJzL3BoeS90aS9waHktdGktcGlwZTMuYwo+PiBAQCAtNjA4LDE0ICs2MDgs MjAgQEAgc3RhdGljIGludCB0aV9waXBlM19nZXRfY2xrKHN0cnVjdCB0aV9waXBlMyAqcGh5KQo+ PiAgIAlzdHJ1Y3QgY2xrICpjbGs7Cj4+ICAgCXN0cnVjdCBkZXZpY2UgKmRldiA9IHBoeS0+ZGV2 Owo+PiAgIAo+PiAtCXBoeS0+cmVmY2xrID0gZGV2bV9jbGtfZ2V0KGRldiwgInJlZmNsayIpOwo+ PiArCS8qCj4+ICsJICogcmVmY2xrIGlzIG9wdGlvbmFsIGZvciBTQVRBIFBIWSB0byBzdXBwb3J0 IG9sZGVyIERUQnMsIGJ1dAo+PiArCSAqIHJlcXVpcmVkIGZvciBvdGhlciBtb2Rlcy4gVXNlIGRl dm1fY2xrX2dldF9vcHRpb25hbCgpIGZvciBTQVRBCj4+ICsJICogd2hpY2ggcmV0dXJucyBOVUxM IGZvciAtRU5PRU5ULCBhbGxvd2luZyB1cyB0byBwcm9wYWdhdGUgYWxsCj4+ICsJICogb3RoZXIg ZXJyb3JzIGluY2x1ZGluZyAtRVBST0JFX0RFRkVSLgo+PiArCSAqLwo+PiArCWlmIChwaHktPm1v ZGUgPT0gUElQRTNfTU9ERV9TQVRBKQo+PiArCQlwaHktPnJlZmNsayA9IGRldm1fY2xrX2dldF9v cHRpb25hbChkZXYsICJyZWZjbGsiKTsKPj4gKwllbHNlCj4+ICsJCXBoeS0+cmVmY2xrID0gZGV2 bV9jbGtfZ2V0KGRldiwgInJlZmNsayIpOwo+PiArCj4+ICAgCWlmIChJU19FUlIocGh5LT5yZWZj bGspKSB7Cj4+ICAgCQlkZXZfZXJyKGRldiwgInVuYWJsZSB0byBnZXQgcmVmY2xrXG4iKTsKPj4g LQkJLyogb2xkZXIgRFRCcyBoYXZlIG1pc3NpbmcgcmVmY2xrIGluIFNBVEEgUEhZCj4+IC0JCSAq IHNvIGRvbid0IGJhaWwgb3V0IGluIGNhc2Ugb2YgU0FUQSBQSFkuCj4+IC0JCSAqLwo+PiAtCQlp ZiAocGh5LT5tb2RlICE9IFBJUEUzX01PREVfU0FUQSkKPj4gLQkJCXJldHVybiBQVFJfRVJSKHBo eS0+cmVmY2xrKTsKPj4gKwkJcmV0dXJuIFBUUl9FUlIocGh5LT5yZWZjbGspOwo+PiAgIAl9Cj4+ ICAgCj4+ICAgCWlmIChwaHktPm1vZGUgIT0gUElQRTNfTU9ERV9TQVRBKSB7Cj4+IEBAIC02MzIs NyArNjM4LDcgQEAgc3RhdGljIGludCB0aV9waXBlM19nZXRfY2xrKHN0cnVjdCB0aV9waXBlMyAq cGh5KQo+PiAgIAkJcGh5LT5zeXNfY2xrID0gZGV2bV9jbGtfZ2V0KGRldiwgInN5c2NsayIpOwo+ PiAgIAkJaWYgKElTX0VSUihwaHktPnN5c19jbGspKSB7Cj4+ICAgCQkJZGV2X2VycihkZXYsICJ1 bmFibGUgdG8gZ2V0IHN5c2Nsa1xuIik7Cj4+IC0JCQlyZXR1cm4gLUVJTlZBTDsKPj4gKwkJCXJl dHVybiBQVFJfRVJSKHBoeS0+c3lzX2Nsayk7Cj4+ICAgCQl9Cj4+ICAgCX0KPj4gICAKPgoKCi0t IApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.126.com (m16.mail.126.com [117.135.210.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281583E00B2 for ; Mon, 18 May 2026 08:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779094526; cv=none; b=bttq2/ut4b736sJuYMewXuASMyBNxUz1ajzn0G+fzcK9fsQI8lO/IybLjRdeDiw/fo0iWX+SM3F/oX9kJEy4I+KJAQZ7k24ToCuspBiWM2lp82aN4KHJiPOlLXaxMqQrzVMPBG/gtCasXTRDBN+8UbtpEwaBZqoyyg8BputPIsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779094526; c=relaxed/simple; bh=lzvsEE979nodd74xn60tIkvM0NEtcZFBqaRdxIJnMlA=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=oXxCSZcpECpqihN2CVb5ASzNkONGAJDparAAI7BqsQ12opl4n3Z36FSSf3pv7QVRh4epLCKe49m/HpS/c4iPB8Fm9gxEhGmvtpMco98gR1ZtsbDLQ7ykUX//pOArvh0OJHoACK3ebzPlDDMQAjmT0oBNBkkBGAW6fXViE2cxRZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=h0Zzw4oY; arc=none smtp.client-ip=117.135.210.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="h0Zzw4oY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Message-ID:Date:From:MIME-Version:To:Subject: Content-Type; bh=mTxKGHWsaIt1llzqHdUN6v5bUzQJIrrj0LXN9qPguwY=; b=h0Zzw4oYBB39BQ+m3RGzgYjWgiYLvv11qOq1qEsHEOm0YwudrZiOrZUr5Ddqcj CU+mQLyFEiXqBYELTewwvw9M2sjDH1liDC4jFckPYX4k/LumZwX23xQrLMVyTnPr Tla4bQjkoR5/7ddbNngC6BW6CyBaq/BCAbVQBk+56+GhY= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-3 (Coremail) with SMTP id _____wD3zwtR0wpqbmouBw--.14701S2; Mon, 18 May 2026 16:52:33 +0800 (CST) Message-ID: <6A0AD35A.2000800@126.com> Date: Mon, 18 May 2026 16:52:42 +0800 From: Hongling Zeng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: Vinod Koul , neil.armstrong@linaro.org, johan@kernel.org, kishon@kernel.org, rogerq@ti.com, sashiko-bo CC: zenghongling , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] phy: ti-pipe3: Fix EPROBE_DEFER handling for clock resources References: <20260518062938.48114-1-zenghongling@kylinos.cn> <20260518062938.48114-4-zenghongling@kylinos.cn> <6A0AC942.40201@126.com> In-Reply-To: <6A0AC942.40201@126.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wD3zwtR0wpqbmouBw--.14701S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxCr48Xw1ftw1DZw1xZF15XFb_yoWruryxpF 4DJ3WYyFWvyrWkAw43Xw1Igw1Fvw1xKF4UGrW5Ww1rZ3W3tr1UGF4xKr4jgryUCFW09w4r ta4UXa4YkFyDZ3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j40PfUUUUU= X-CM-SenderInfo: x2kr0wpolqwiqxrzqiyswou0bp/xtbBrhEm9moK01HBBwAA3L -- Sashiko AI review ·https://sashiko.dev/#/patchset/20260518062938.48114-1-zenghongling@kylinos.cn?part=3 -- Hi, Resend to fix threading / delivery issues. Thank you for the review. You raise a valid point about using dev_err_probe() to avoid dmesg spam during probe deferral. I've kept dev_err() in this patch to maintain consistency with the existing code style and focus on the core EPROBE_DEFER fixes. However, I agree that dev_err_probe() would be better and can submit a follow-up cleanup patch to address the logging improvement. Does this approach work for you, or would you prefer I include the dev_err_probe() change in this series? Best regards, Hongling 在 2026年05月18日 16:09, Hongling Zeng 写道: > -- > Sashiko AI review ·https://sashiko.dev/#/patchset/20260518062938.48114-1-zenghongling@kylinos.cn?part=3 > > -- > Hi, > > Thank you for the review. You raise a valid point about using dev_err_probe() > to avoid dmesg spam during probe deferral. > > I've kept dev_err() in this patch to maintain consistency with the existing > code style and focus on the core EPROBE_DEFER fixes. However, I agree that > dev_err_probe() would be better and can submit a follow-up cleanup patch to > address the logging improvement. > > Does this approach work for you, or would you prefer I include the dev_err_probe() > change in this series? > > Best regards, > Hongling > > > 在 2026年05月18日 14:29, Hongling Zeng 写道: >> ti_pipe3_get_clk() has two issues with -EPROBE_DEFER error handling: >> >> 1. When devm_clk_get() for sysclk fails, the function returns -EINVAL >> instead of propagating the actual error code. This masks -EPROBE_DEFER >> to -EINVAL, breaking the probe deferral mechanism and causing permanent >> driver initialization failure on systems with non-deterministic probe >> ordering. >> >> 2. For SATA PHY refclk, the function ignores all errors to support older >> DTBs missing the refclk property. However, this incorrectly ignores >> -EPROBE_DEFER as well, causing the driver to proceed without waiting >> for the clock provider to become available. >> >> Fix both issues: >> - Return PTR_ERR(phy->sys_clk) instead of -EINVAL to propagate all >> error codes including -EPROBE_DEFER >> - Use devm_clk_get_optional() for SATA refclk to handle optional >> clocks while propagating -EPROBE_DEFER and other errors >> >> Fixes: a70143bbef6b ("drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework") >> Fixes: 7f33912d2978 ("phy: ti-pipe3: Fix SATA across suspend/resume") >> Signed-off-by: Hongling Zeng >> >> --- >> Change in v4: >> - Merge refclk leak fix and EPROBE_DEFER fix into a single patch >> - Use devm_clk_get_optional() for SATA refclk >> - Drop manual -ENOENT handling >> - Ensure error paths are fully symmetric >> --- >> Change in v5: >> -Add Fix ignored clock enable return value in init patch >> --- >> drivers/phy/ti/phy-ti-pipe3.c | 20 +++++++++++++------- >> 1 file changed, 13 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/phy/ti/phy-ti-pipe3.c b/drivers/phy/ti/phy-ti-pipe3.c >> index 2d36fe4c4218..9ec228c2a940 100644 >> --- a/drivers/phy/ti/phy-ti-pipe3.c >> +++ b/drivers/phy/ti/phy-ti-pipe3.c >> @@ -608,14 +608,20 @@ static int ti_pipe3_get_clk(struct ti_pipe3 *phy) >> struct clk *clk; >> struct device *dev = phy->dev; >> >> - phy->refclk = devm_clk_get(dev, "refclk"); >> + /* >> + * refclk is optional for SATA PHY to support older DTBs, but >> + * required for other modes. Use devm_clk_get_optional() for SATA >> + * which returns NULL for -ENOENT, allowing us to propagate all >> + * other errors including -EPROBE_DEFER. >> + */ >> + if (phy->mode == PIPE3_MODE_SATA) >> + phy->refclk = devm_clk_get_optional(dev, "refclk"); >> + else >> + phy->refclk = devm_clk_get(dev, "refclk"); >> + >> if (IS_ERR(phy->refclk)) { >> dev_err(dev, "unable to get refclk\n"); >> - /* older DTBs have missing refclk in SATA PHY >> - * so don't bail out in case of SATA PHY. >> - */ >> - if (phy->mode != PIPE3_MODE_SATA) >> - return PTR_ERR(phy->refclk); >> + return PTR_ERR(phy->refclk); >> } >> >> if (phy->mode != PIPE3_MODE_SATA) { >> @@ -632,7 +638,7 @@ static int ti_pipe3_get_clk(struct ti_pipe3 *phy) >> phy->sys_clk = devm_clk_get(dev, "sysclk"); >> if (IS_ERR(phy->sys_clk)) { >> dev_err(dev, "unable to get sysclk\n"); >> - return -EINVAL; >> + return PTR_ERR(phy->sys_clk); >> } >> } >> >