All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chih Kai Hsu <hsu.chih.kai@realtek.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Birger Koblitz <mail@birger-koblitz.de>,
	"netdev-bot+sashiko@kernel.org" <netdev-bot+sashiko@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	nic_swsd <nic_swsd@realtek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	"bjorn@mork.no" <bjorn@mork.no>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>
Subject: RE: [PATCH net-next v8 10/11] r8152: add TGPHY register access for RTL8157 and RTL8159
Date: Fri, 20 Nov 2026 08:11:43 +0000	[thread overview]
Message-ID: <6a2c635ba56d4deab25a25db9af91c10@realtek.com> (raw)
In-Reply-To: <1543707c-c121-4c35-8849-c4db1a71fb57@lunn.ch>

On 19/11/2026 9:58 pm, Andrew Lunn wrote:
> On Thu, Nov 19, 2026 at 07:18:16AM +0000, Chih Kai Hsu wrote:
> > On 19/11/2026 12:42 pm, Birger Koblitz wrote:
> > > On 18/11/2026 2:42 pm, Andrew Lunn wrote:
> > > >> I plan to add two new functions, rtl_nway_restart() and
> > > >> rtl8152_get_link_ksettings, to replace mii_nway_restart() and
> > > mii_ethtool_get_link_ksettings, respectively.
> > > >
> > > > Ideally, you should port this driver to phylink.
> > > >
> > > >        Andrew
> > >
> > > Indeed, all of the (integrated) PHYs on the adapters supporeted by
> > > r8152 I looked at are already supported under
> > > drivers/net/phy/realtek/ It should be straight-forward with many immediate
> benefits.
> > >
> > > Birger
> >
> > I agree that a phylink conversion is a better long-term direction. I'd
> > like to keep it out of this series. This series fixes and completes
> > the existing RTL8157/59 support. The phylink conversion is a larger
> > change. r8152 has no MDIO bus and accesses PHY through OCP registers.
> 
> It does have an MDIO bus, it just used OCP registers to access it. But there is no
> reason you cannot export it using a normal Linux MDIO bus driver.
> 
> > , and the MAC code also does PHY configuration,
> 
> Which is a layer violation.
> 
> > firmware patching, UPS and EEE handling that would need to move or
> > coexist with the phylib drivers.
> 
> Or just thrown away because the it already works in the PHY drivers and
> phylink.
> 
> > The two helpers here are self-contained and will be removed by the
> > phylink port.
> 
> phylink_ethtool_nway_reset and phy_ethtool_nway_reset exists, so there is no
> need to add yet another version. phylink_ethtool_ksettings_set &
> phylink_ethtool_ksettings_get and phy_ethtool_get_link_ksettings &
> phy_ethtool_set_link_ksettings already exist, so there is no reason to add new
> ones.
> 
> I'm tempted to just NACK it. The best pressure i can apply to make you move to
> phylink is to not merge your patches. If you are adding stuff which should really
> by done by phylink, i think it should be rejected.
> 
>       Andrew

I will keep the MII APIs.

Our read_mii_word() returns a negative errno when a PHY access fails, so that callers
can stop early. The MII library does not check for it: mii.c uses the mdio_read() return
value as register content, so mii_nway_restart() and mii_ethtool_get_link_ksettings()
treat an errno as bits.

When the errno is -ENODEV, nothing reaches the hardware. The device is gone, so the
write that follows in mii_nway_restart() is blocked as well. The remaining case is a PHY
access timeout, where the device is still accessible. The root cause there is also that
the MII library does not check the errno, so a future patch could make the MII APIs
check the mdio_read() return value and propagate the error. That would fix it for
every user instead of working around it in r8152.

Moving r8152 to phylink is the direction we want to take. We want to study the design
before committing to it, and it's a larger change than this series, so I would like to
separate it from this series.

Meanwhile, the legacy PHY access may cause bugs if the driver and the firmware
access the PHY at the same time. So, the TGPHY patch is needed for RTL8157/
RTL8159.

Best Regards,
Chih-Kai


  reply	other threads:[~2026-11-20  8:12 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  3:24 [PATCH net-next v8 00/11] r8152: refactor and extend RTL8157/8159 support Chih Kai Hsu
2026-11-10  3:24 ` [PATCH net-next v8 01/11] r8152: fix RTL8156/RTL8156B/RTL8157/RTL8159 up and down settings Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-14  9:28   ` netdev-bot+sashiko
2026-11-10  3:24 ` [PATCH net-next v8 02/11] r8152: add rtl8157_unload() for RTL8157 and RTL8159 Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-14  9:28   ` netdev-bot+sashiko
2026-11-10  3:24 ` [PATCH net-next v8 03/11] r8152: add rtl8157_change_mtu() " Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-14  9:28   ` netdev-bot+sashiko
2026-11-10  3:24 ` [PATCH net-next v8 04/11] r8152: fix flow control for RTL8156/RTL8156B/RTL8157/RTL8159 Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-14  9:28   ` netdev-bot+sashiko
2026-11-10  3:24 ` [PATCH net-next v8 05/11] r8152: split r8156_init by generation and factor out wait_autoload_done Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-10  3:24 ` [PATCH net-next v8 06/11] r8152: add new init writes for RTL8156/8156B/8157/8159 Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-14  9:28   ` netdev-bot+sashiko
2026-11-18  8:38     ` Chih Kai Hsu
2026-11-10  3:24 ` [PATCH net-next v8 07/11] r8152: split RTL_VER_17 into QFN68 and QFN100 package variants Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-14  9:28   ` netdev-bot+sashiko
2026-11-10  3:24 ` [PATCH net-next v8 08/11] r8152: split rtl8156_enable/up/down into per-generation functions Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-10  3:24 ` [PATCH net-next v8 09/11] r8152: split r8157_hw_phy_cfg into RTL8157 and RTL8159 variants Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-14  9:28   ` netdev-bot+sashiko
2026-11-10  3:24 ` [PATCH net-next v8 10/11] r8152: add TGPHY register access for RTL8157 and RTL8159 Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-14  9:28   ` netdev-bot+sashiko
2026-11-18  9:01     ` Chih Kai Hsu
2026-11-18 13:42       ` Andrew Lunn
2026-11-18 16:42         ` Birger Koblitz
2026-11-19  7:18           ` Chih Kai Hsu
2026-11-19 13:57             ` Andrew Lunn
2026-11-20  8:11               ` Chih Kai Hsu [this message]
2026-11-20 13:21                 ` Andrew Lunn
2026-11-10  3:24 ` [PATCH net-next v8 11/11] r8152: enable UPS for RTL8157 and RTL8159 QFN68 Chih Kai Hsu
2026-11-11  3:25   ` sashiko-bot
2026-11-14  9:28   ` netdev-bot+sashiko
2026-11-18  9:13     ` Chih Kai Hsu
2026-11-10  5:04 ` [PATCH net-next v8 00/11] r8152: refactor and extend RTL8157/8159 support netdev-bot+sinfo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a2c635ba56d4deab25a25db9af91c10@realtek.com \
    --to=hsu.chih.kai@realtek.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mail@birger-koblitz.de \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.