All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wayen Yan <win847@gmail.com>
To: mikhail.kshevetskiy@iopsys.eu
Cc: linux-gpio@vger.kernel.org, lorenzo@kernel.org
Subject: Re: [06/11] pinctrl: airoha: an7583: fix incorrect led mapping in phy4_led1 pin function
Date: Mon, 15 Jun 2026 21:23:14 +0800	[thread overview]
Message-ID: <6a2ffcc6.2afc2531.35ffc5.cfba@mx.google.com> (raw)
In-Reply-To: <20260606020342.1256509-7-mikhail.kshevetskiy@iopsys.eu>

On 2026-06-06, Mikhail Kshevetskiy wrote:
> phy4_led1 pin function maps led incorrectly. It uses the same map as
> phy3_led1. PHY{X} should map to LAN{N}_PHY_LED_MAP(X-1).
> 
> Fixes: 3ffeb17a9a27 ("pinctrl: airoha: add support for Airoha AN7583 PINs")

Hi Mikhail,

Thanks for this fix series. I noticed that the same MAP(2) bug also
exists in the EN7581 phy4_led1 table, not just AN7583.

In drivers/pinctrl/mediatek/pinctrl-airoha.c:

EN7581 phy4_led1_func_group[] also uses LAN*_PHY_LED_MAP(2) — identical
to phy3_led1. Should be MAP(3) following the PHY{X} -> MAP(X-1) rule:

  AIROHA_PINCTRL_PHY_LED1("gpio43", ..., LAN0_PHY_LED_MAP(2)),  // EN7581
  AIROHA_PINCTRL_PHY_LED1("gpio44", ..., LAN1_PHY_LED_MAP(2)),  // EN7581
  AIROHA_PINCTRL_PHY_LED1("gpio45", ..., LAN2_PHY_LED_MAP(2)),  // EN7581
  AIROHA_PINCTRL_PHY_LED1("gpio46", ..., LAN3_PHY_LED_MAP(2)),  // EN7581

Could you include EN7581 in this fix as well?

Regards,
Wayen

  reply	other threads:[~2026-06-15 13:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-06  2:03 [PATCH 00/11] pinctrl: airoha: small fixes Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 01/11] pinctrl: airoha: an7581: add missed gpio32 pin group Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 02/11] pinctrl: airoha: an7583: " Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 03/11] pinctrl: airoha: an7581: fix misprint in gpio19 pinconf Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 04/11] pinctrl: airoha: an7583: " Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 05/11] pinctrl: airoha: an7581: fix incorrect led mapping in phy4_led1 pin function Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 06/11] pinctrl: airoha: an7583: " Mikhail Kshevetskiy
2026-06-15 13:23   ` Wayen Yan [this message]
2026-06-15 17:19     ` [06/11] " Mikhail Kshevetskiy
2026-06-16  0:07       ` Wayen Yan
2026-06-06  2:03 ` [PATCH 07/11] pinctrl: airoha: fix pwm pin function for an7581 and an7583 Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 08/11] pinctrl: airoha: an7583: fix gpio21 pin group Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 09/11] pinctrl: airoha: an7583: add missed gpio22 " Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 10/11] pinctrl: airoha: an7583: fix phy1_led1 pin function Mikhail Kshevetskiy
2026-06-06  2:03 ` [PATCH 11/11] pinctrl: airoha: an7583: remove undefined groups from pcm_spi " Mikhail Kshevetskiy
2026-06-11 11:53 ` [PATCH 00/11] pinctrl: airoha: small fixes Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a2ffcc6.2afc2531.35ffc5.cfba@mx.google.com \
    --to=win847@gmail.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.