From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8962E2FE042 for ; Tue, 23 Jun 2026 17:41:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782236519; cv=none; b=KubWAAv6PVfVSQKetstQ6PPYr+J0U57pEC2jxEbtAPGOStaMddS7HZuvSbN5iFR8kHeh7x9SEhXrhQ8RF9Ir1cWwvUUForlQiEwtkWGPosvIT52My3xAARt3TUavLdI5WSrLhoKDPgcfgCCVvSMOOHBgbVeY27iYjl6wwHf6aiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782236519; c=relaxed/simple; bh=Cr2FzJoSMjhAWLiCORvNsQ/qT2AGi11n9vpdN2BGQ8E=; h=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject: In-Reply-To:References; b=aX657h+lEXSsYPhHCkNyj9KcYhZlSt+zSUXViL/wfcaI1l1FVp2RFSFug9yt/cK76gQRfIw+vwRJN6JkgQYP6k3SpYzO9DpEs4fpV3LGoVbB39n08TiJ9NNsosUxXIIEayXn8POVzn+7U2kGnbSBSvmytdZmXNou2XAtanDUGcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mCsR5DDb; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mCsR5DDb" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490b613a17bso1570355e9.3 for ; Tue, 23 Jun 2026 10:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782236517; x=1782841317; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Cr2FzJoSMjhAWLiCORvNsQ/qT2AGi11n9vpdN2BGQ8E=; b=mCsR5DDb4svZoSIK+Q5SV/yjzgbtl4VXqvRKo/VIsA/9d81HBaUydQXNnOM9ZDhw9r 412rNXYk6E+8clzAufuP1MKBJUcOBMgSYHGAalkUe8TJWj9FEz9Jn06f2LrUClEPzNvl rr3bF+pbK8FLmpz37vn3+ymn4ef6Pdx/g6em8VS+k5ni6XYdH3+iNerT//V8CQF+MURo jm56nh4zPHXdaUxUmhBxbWTcQ/rNaZEE01+oF56D/ma43JzGmuqYm90g79gyMIHJutDC vgmZtYlv06I/BpIEI6AX/LoabF8EGNflc8TyNoYmTTU85OVJ3oGGOkeWz/Y7v0SpRU54 bvCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782236517; x=1782841317; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cr2FzJoSMjhAWLiCORvNsQ/qT2AGi11n9vpdN2BGQ8E=; b=RDRNZz4yN5vmKGwnVACuTFEBOElOPl++2eXZHgirkecGW6j8gSzQmVyJl0Wy4QhP/K JO6eZaeqvgCAqxENvjUEDD98l3+l6KqPFN4sBINhr6gygSCdkQ/WgOjUDtYp0hNsxL22 wfkphxnqx2+80r+ucF7GOMOD6xj12pDmJOy7eCstR/moUAbK3SwRn6h9hYoNaK0ppXaf PzeiytPfQWgH70pAda22uKD7zrEjc8ba/fK3hdMOkxuUgEfVaNUGKcvIi2HA5AXUxhnz Km6sotFafGcqAzOHOOp5ATzwaGbcgsrtJ28obeY8d2gOjfNLwcxD/i9SheY1A88acJBE hNhg== X-Forwarded-Encrypted: i=1; AFNElJ+0qlDp/bRkEQ7ZOyodfHD5IiW2jbE/hZGlNTQRlcVAdzxLpJGknTFOivSFXvsQQcdnqvFmmHG2magIuN4=@vger.kernel.org X-Gm-Message-State: AOJu0YwCgWSaeZr7fiveFI/zDtOsglX5NSv1z3z9XEUV2x7OSylXeRpv H1+YGSIM6FT/EUaVd33rB7O8+A0/PEltIJFth0S7yM3ybc2P4Eq9xXnV X-Gm-Gg: AfdE7ckKfsatHI2eCkRiVmgOYP/nDwK8BYW2kOKWnLkUuGtSs2f5t92azGVOzLwcQZP 8v4W4A38HykyINUB4UL4e3DjH2cbWjiEafYy2A3Yd6kuLn1exnMe5nSs44LbIehh5wOwKuvjbMh x5OWj2V76EG13wyH2LG1oNYgd7F1CtL9vLhIFfz9C6fdMai9lOrotzdB3K/h5PLTeJUt5hzsNor 7AKEbccfRALGWCAbN5JTMKplRC5DGPwptE2IAdw2aiAr2USGQj9ppJux/gWabVZp0avm8lDZ0ty q3UChMimDbWtvIC5l3/mDdjF5Dk/NUKJRjUyIy6vPn2q4FRi9Si2VVqCPe+cU8tYdfV4SXA70w7 PlLqA8ojsjOgvXcu39JIpGa3OFJ2WPoeDeaLcT86mn/Vwiyua1eXy7aOA969up7DUwb4trYNLS/ n0+B3aQB2hF+4fP8HlG99CdqT4I3IDWNIRh/e4uz30gcgrOBujx0K9Gbw= X-Received: by 2002:a05:600c:8b03:b0:492:45a0:dcef with SMTP id 5b1f17b1804b1-49249083cb4mr220127715e9.5.1782236516883; Tue, 23 Jun 2026 10:41:56 -0700 (PDT) Received: from legion.localdomain ([92.44.171.31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fd15535sm426715225e9.3.2026.06.23.10.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 10:41:56 -0700 (PDT) Message-ID: <6a3ac564.561280e1.325e99.1bee@mx.google.com> Date: Tue, 23 Jun 2026 10:41:56 -0700 (PDT) Content-Type: text/plain; charset="us-ascii" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Batu Ada Tutkun To: Dan Carpenter Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: most: dim2: use dev_err_probe() for clock errors in rcar enable functions In-Reply-To: References: <20260623124243.1245-1-batuadatutkun@gmail.com> Yes, this was drafted with AI assistance. Thank you for pointing it out. You are right that the error code was not broken here. rcar_gen2 and gen3 already return PTR_ERR(dev->clk), so unlike the fsl_mx6 case there is no -EFAULT bug to fix. This is just a consistency cleanup, plus devm_clk_get() can return -EPROBE_DEFER when the clock provider has not registered yet so dev_err_probe() suppresses the misleading "cannot get clock" message during a normal deferred probe. clk_prepare_enable() can't return -EPROBE_DEFER. By the time it is called the clock handle is already acquired and deferral only happens at acquisition. Because of that I deliberately left that path as dev_err(). Compile tested only. I do not have R-Car hardware. Regards, Batu Ada Tutkun