From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AAE83939B6 for ; Tue, 23 Jun 2026 19:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782244365; cv=none; b=JeVAp7pxGhTrWLd0xG6YQKl9h0+0qvzSAsPJZJUMnx+Hr/5LUaqDkEkAM/JgAEVLAnX3YK+KjHXucPNM8AdPgyTS8Sy7I1fQFFamnpy9PB62NeDUAMbXrjlGHMdEg9W737E1UzrZZ3ahpRRxCYYDo/QjKhrzkHXAQjHtIoSMQ+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782244365; c=relaxed/simple; bh=tmjhUBB1u98dLDU3QdbVkFNmoR5xov/zk3dBLRdPpd8=; h=Message-ID:From:Date:Subject:To:Cc:In-Reply-To:References; b=f2aeGvuf/ZlytgtVXdwKlg37Rgoff2+59CGTjQQCPaoMpm+luWuOsY9w9B/dzu5kWHRcUi4qNC/INTXxVjluIJB9gV9d3g+ffa1/h7GqVSROUhGbJt/DWreGvT+xm8gep7rApeeCp2pX50/IWFjJP+q3KMMq85i/US0za/Ex36E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s6FMwA70; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s6FMwA70" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4924f8db066so1538455e9.2 for ; Tue, 23 Jun 2026 12:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782244362; x=1782849162; darn=vger.kernel.org; h=references:in-reply-to:cc:to:subject:date:from:message-id:from:to :cc:subject:date:message-id:reply-to; bh=RwG/sU5n5vL9aQ5QUZES8N6P98eJf2PlCWhWLXHFgog=; b=s6FMwA70tcAO+xhqjDGdRdHMIv0NNjXF+msxlTVZZsEJsPyNdzxSvE1VH3YwkaHH+H vGtpyoptZoceCWqXU37eU3pnoSZudtvUyPOUOWtO5Sg0umWwr7cTkyQB6UhVeaP44K56 ms/gFmk1TbgO3KvrQtCAi2ILat3pdUgDJczUBdeew1W5FoIxMc2goCF49m4extljpuW5 RzZwyP37eBdM7XQgODn7ZH8iKoykcK2Kkega5vE36NebND02xaFrQaZLORcJxbRCpjGZ u1vX+B8bamQ6HGGPLrw23NkuqhhQS0z+LezjTIWUo442m4f7yeoSc01lgXM5GdDApHyy PcNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782244362; x=1782849162; h=references:in-reply-to:cc:to:subject:date:from:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RwG/sU5n5vL9aQ5QUZES8N6P98eJf2PlCWhWLXHFgog=; b=NiR2hXFu+213q9aTDoSNXxNZD/BdbNBMRgJTWSvCs8l/IOmxTjS1pJ7NiI5kEo9H9A tXiWIsrjC5ehyEUhSeLJaR8VkbFcTHpHC4r3gTxgUyESGh1T6I7N0SbYRFDQejmaGkKo Bc65ssVucNLnfkuM6I5t/UXF55E+IQ1DUMyrplftTtsulZ12WgPTXKJA+Iw0MZXsglzO v5E50BKM6PE5ArZ79rlWScaQxr9On9iQ5g/UMWDuInO8+Iza/55cBFjedtLjqG1PM+Gs NV4abnheh90TihrFFL6mmkHQN/ZICQpP9lSDROZ0Hg6WulOz0ofceJepEa7qRax/t0TZ c9pQ== X-Forwarded-Encrypted: i=1; AFNElJ82NY+TfMGtRgchXnUM/iwEF0jHLo1ZcVqdfx6cSbAK5EgHK0Ax2h6waULyUgRqywqtTD5DeP2oSUqA6Ns=@vger.kernel.org X-Gm-Message-State: AOJu0YyHK+T8YJiWdsJTfi50LHjBrqyLhvdQzCK8EutF3FcLjxBBSnnd M369Gmq52acckWSoQ5ve4ivrWSzd0HBDIKq6UJtEfXYgaYrKsU4+s26O X-Gm-Gg: AfdE7cmdN+jmBjR8UrInMuDqJuZayWAgrjgmZcXpjea3deDuH4pgo007GaK/IU2985c YTH/+J0lpq/B/1YI0RtxeTBp+ZZn5EAy8dtHGHI5S9gawnaxNccmCEeKtF8vW04Kpeec3u1A/GS W/EBE1oLNwg9Zkbju0/FSexee2/Bm8epG/8JWpONhWoY3yXYF0b7rvBdP8XytjEjIqZ2iKtrz0N anpMoRTgNLffQAd0x7a27eEybTDLitNc+3GLWZfnPFwQEMqRd4xGpqKSWXLGm/37zFQxDokKx0b Kfoq2JnK/MmHX8WdQ+BhR8PR4ELCHBkcLODHOF+hKYI1GAdA/OY5UOkN9C84L0l5GHI2+rchIZc kXueLFP7qL1/F7vwRsWv0kx8TPqLOJUvoShvNPBMuDgQpb+JFEJii2wbbBgjJpUR7BdjElFkwQf LsSRelu2Kfp3zh5RnxHAI3lSJCC/gGyqGRMIzZrRnxyirbdYM6mhzI8cQ= X-Received: by 2002:a05:600c:698d:b0:490:e190:3b50 with SMTP id 5b1f17b1804b1-4925b359a37mr59883015e9.9.1782244362383; Tue, 23 Jun 2026 12:52:42 -0700 (PDT) Received: from legion.localdomain ([92.44.171.31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4926064ea35sm6182885e9.1.2026.06.23.12.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 12:52:42 -0700 (PDT) Message-ID: <6a3ae40a.3dabba3e.2527ef.7783@mx.google.com> From: Batu Ada Tutkun Date: Tue, 23 Jun 2026 15:35:08 +0300 Subject: [PATCH v2] staging: most: dim2: use dev_err_probe() for clock errors in rcar enable functions To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com In-Reply-To: <20260623124243.1245-1-batuadatutkun@gmail.com> References: <20260623124243.1245-1-batuadatutkun@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: rcar_gen2_enable() and rcar_gen3_enable() use the old pattern of dev_err() followed by return PTR_ERR() when devm_clk_get() fails. fsl_mx6_enable() in the same file was already converted to use dev_err_probe() by a previous cleanup series. Convert the remaining two functions for consistency. devm_clk_get() calls clk_get() which can return -EPROBE_DEFER if the clock provider has not yet registered. Using dev_err_probe() suppresses the log at error level in that case, avoiding misleading "cannot get clock" output during a normal deferred probe. clk_prepare_enable() cannot return -EPROBE_DEFER since the clock handle is already acquired at that point, so those error paths are left as dev_err(). Signed-off-by: Batu Ada Tutkun --- Compile tested only. No R-Car hardware available. This is a correctness fix for the deferred probe path, not a response to a reported user visible issue. Changes in v2: - Mention clk_get() explicitly in commit message - Add testing note under --- cut off line drivers/staging/most/dim2/dim2.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index 7953d4626..56f856d6d 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -974,10 +974,9 @@ static int rcar_gen2_enable(struct platform_device *pdev) int ret; dev->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "cannot get clock\n"); - return PTR_ERR(dev->clk); - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "cannot get clock\n"); ret = clk_prepare_enable(dev->clk); if (ret) { @@ -1019,10 +1018,9 @@ static int rcar_gen3_enable(struct platform_device *pdev) int ret; dev->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "cannot get clock\n"); - return PTR_ERR(dev->clk); - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "cannot get clock\n"); ret = clk_prepare_enable(dev->clk); if (ret) { -- 2.53.0