From: "Dan Williams (nvidia)" <djbw@kernel.org>
To: Gregory Price <gourry@gourry.net>,
"Dan Williams (nvidia)" <djbw@kernel.org>
Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
driver-core@lists.linux.dev, linux-kselftest@vger.kernel.org,
kernel-team@meta.com, david@kernel.org, osalvador@suse.de,
gregkh@linuxfoundation.org, rafael@kernel.org,
dakr@kernel.org, vishal.l.verma@intel.com,
dave.jiang@intel.com, alison.schofield@intel.com,
akpm@linux-foundation.org, ljs@kernel.org, liam@infradead.org,
vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, shuah@kernel.org, iweiny@kernel.org,
Smita.KoralahalliChannabasappa@amd.com, apopple@nvidia.com,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v6 09/10] dax/kmem: add sysfs interface for atomic whole-device hotplug
Date: Thu, 09 Jul 2026 16:57:30 -0700 [thread overview]
Message-ID: <6a50356aa7a4a_3cabcb1008a@djbw-dev.notmuch> (raw)
In-Reply-To: <alApfp2z9Thyan16@gourry-fedora-PF4VCD3F>
Gregory Price wrote:
> > So the "unknown" case does not need to be here.
> >
>
> mhp_online_type_to_str can technically return NULL, seems better to not
> just let a NULL dereference sit latent even if we can visually tell it
> can't happen today?
Oh, makes sense I was thinking "unknown" was only a result of the
drvdata missing case.
> > > + if (dax_kmem_state_is_online(data->state)) {
> > > + dev_warn(dev, "Hotplug regions stuck online until reboot\n");
> >
> > I like that the BUG() is avoided, but I think these should stay
> > dev_err() given the severity.
> >
>
> I had to go back to calling remove_memory() by default given different
> feedback, but I think if anything I will just modify the BUG() to a
> WARN() and call it a day.
ack.
next prev parent reply other threads:[~2026-07-09 23:57 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 21:18 [PATCH v6 00/10] dax/kmem: atomic whole-device hotplug via sysfs Gregory Price
2026-06-30 21:18 ` [PATCH v6 01/10] mm/memory: add memory_block_aligned_range() helper Gregory Price
2026-07-09 17:58 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 02/10] mm/memory_hotplug: add mhp_online_type_to_str() and export string helpers Gregory Price
2026-07-01 8:30 ` David Hildenbrand (Arm)
2026-07-09 17:59 ` Dave Jiang
2026-07-09 21:08 ` Dave Jiang
2026-07-09 21:57 ` Gregory Price
2026-07-10 12:44 ` David Hildenbrand (Arm)
2026-06-30 21:18 ` [PATCH v6 03/10] mm/memory_hotplug: pass online_type to online_memory_block() via arg Gregory Price
2026-07-09 18:22 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 04/10] mm/memory_hotplug: export mhp_get_default_online_type Gregory Price
2026-07-09 18:30 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 05/10] mm/memory_hotplug: add __add_memory_driver_managed() with online_type arg Gregory Price
2026-07-09 18:48 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 06/10] mm/memory_hotplug: add offline_and_remove_memory_ranges() Gregory Price
2026-07-01 8:32 ` David Hildenbrand (Arm)
2026-07-09 8:45 ` Richard Cheng
2026-07-09 15:06 ` Gregory Price
2026-07-09 17:15 ` Gregory Price
2026-07-09 18:53 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 07/10] dax: plumb hotplug online_type through dax Gregory Price
2026-07-09 21:07 ` Dave Jiang
2026-07-09 21:46 ` Dan Williams (nvidia)
2026-07-09 22:08 ` Gregory Price
2026-07-10 1:30 ` Gregory Price
2026-07-11 0:44 ` Dan Williams (nvidia)
2026-07-12 13:19 ` Gregory Price
2026-07-12 13:27 ` Gregory Price
2026-06-30 21:18 ` [PATCH v6 08/10] dax/kmem: extract hotplug/hotremove helper functions Gregory Price
2026-07-09 21:44 ` Dave Jiang
2026-07-09 21:57 ` Gregory Price
2026-06-30 21:18 ` [PATCH v6 09/10] dax/kmem: add sysfs interface for atomic whole-device hotplug Gregory Price
2026-06-30 21:32 ` sashiko-bot
2026-06-30 22:14 ` Gregory Price
2026-07-01 6:13 ` Hannes Reinecke
2026-07-01 6:23 ` Gregory Price
2026-07-09 8:07 ` Richard Cheng
2026-07-09 14:57 ` Gregory Price
2026-07-09 22:14 ` Dave Jiang
2026-07-09 22:22 ` Gregory Price
2026-07-09 22:36 ` Dan Williams (nvidia)
2026-07-09 23:06 ` Gregory Price
2026-07-09 23:57 ` Dan Williams (nvidia) [this message]
2026-07-10 3:08 ` Gregory Price
2026-06-30 21:18 ` [PATCH v6 10/10] selftests/dax: add dax/kmem hotplug sysfs regression test Gregory Price
2026-07-09 8:20 ` Richard Cheng
2026-07-09 15:02 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a50356aa7a4a_3cabcb1008a@djbw-dev.notmuch \
--to=djbw@kernel.org \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=apopple@nvidia.com \
--cc=dakr@kernel.org \
--cc=dave.jiang@intel.com \
--cc=david@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gourry@gourry.net \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=iweiny@kernel.org \
--cc=kernel-team@meta.com \
--cc=liam@infradead.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=nvdimm@lists.linux.dev \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.