From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 06/10] drm/i915/pmu: Wire up engine busy stats to PMU Date: Wed, 4 Oct 2017 18:35:08 +0100 Message-ID: <6a56eed4-ec6f-29b3-4372-b1445263c44c@linux.intel.com> References: <20170929123500.3186-1-tvrtko.ursulin@linux.intel.com> <20170929123500.3186-7-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id F30206E73D for ; Wed, 4 Oct 2017 17:35:10 +0000 (UTC) In-Reply-To: <20170929123500.3186-7-tvrtko.ursulin@linux.intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI5LzA5LzIwMTcgMTM6MzQsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+IEZyb206IFR2cnRr byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gCj4gV2UgY2FuIHVzZSBlbmdp bmUgYnVzeSBzdGF0cyBpbnN0ZWFkIG9mIHRoZSBzYW1wbGluZyB0aW1lciBmb3IKPiBiZXR0ZXIg YWNjdXJhY3kuCj4gCj4gQnkgZG9pbmcgdGhpcyB3ZSByZXBsYWNlIHRoZSBzdG9oYXN0aWMgc2Ft cGxpbmcgd2l0aCBidXN5bmVzcwo+IG1ldHJpYyBkZXJpdmVkIGRpcmVjdGx5IGZyb20gZW5naW5l IGFjdGl2aXR5LiBUaGlzIGlzIGNvbnRleHQKPiBzd2l0Y2ggaW50ZXJydXB0IGRyaXZlbiwgc28g YXMgYWNjdXJhdGUgYXMgd2UgY2FuIGdldCBmcm9tCj4gc29mdHdhcmUgdHJhY2tpbmcuCgpUbyBx dWFudGlmeSB0aGUgcHJlY2lzaW9uIGJlbmVmaXQgd2l0aCBhIGdyYXBoOgoKaHR0cHM6Ly9wZW9w bGUuZnJlZWRlc2t0b3Aub3JnL350dXJzdWxpbi9zYW1wbGluZy12cy1idXN5LXN0YXRzLnBuZwoK VGhpcyByZXByZXNlbnRzIHRoZSByZW5kZXIgZW5naW5lIGJ1c3luZXNzIG9uIG5ldmVyYmFsbCBt ZW51IHNjcmVlbiAKbG9vcGluZyBhIGZldyB0aW1lcy4gUE1VIHNhbXBsaW5nIGludGVydmFsIGlz IDEwMG1zLiBJdCB3YXMgZ2VuZXJhdGVkIApmcm9tIGEgc3BlY2lhbCBidWlsZCB3aXRoIGJvdGgg UE1VIGNvdW50ZXJzIHJ1bm5pbmcgaW4gcGFyYWxsZWwgc28gdGhlIApkYXRhIGlzIGFic29sdXRl bHkgYWxpZ25lZC4KCkFub21hbHkgb2YgYnVzeW5lc3MgZ29pbmcgb3ZlciAxMDAlIGlzIGNhdXNl ZCBieSBtZSBub3QgYm90aGVyaW5nIHRvIHVzZSAKdGhlIGFjdHVhbCB0aW1lc3RhbXBzIGdvdCBm cm9tIFBNVSwgYnV0IHVzaW5nIGZpeGVkIGludGVydmFsIChwZXJmIHN0YXQgCi1JIDEwMCkuIEJ1 dCBJIGRvbid0IHRoaW5rIGl0IG1hdHRlcnMgZm9yIHRoZSByb3VnaCBjb21wYXJpc29uIGFuZCAK bG9va2luZyBhdCB0aGUgbm9pc2UgYW5kIGVycm9yIGluIHRoZSBzYW1wbGluZyB2ZXJzaW9uLgoK PiBBcyBhIHNlY29uZGFyeSBiZW5lZml0LCB3ZSBjYW4gYWxzbyBub3QgcnVuIHRoZSBzYW1wbGlu ZyB0aW1lcgo+IGluIGNhc2VzIG9ubHkgYnVzeW5lc3MgbWV0cmljIGlzIGVuYWJsZWQuCgpGb3Ig dGhpcyBvbmUgZGF0YSBpcyBub3Qgc2hvd2luZyBhbnl0aGluZyBzaWduaWZpY2FudC4gSSd2ZSBz ZWVuIHRoZSAKaTkxNV9zYW1wbGUgZnVuY3Rpb24gdXNlIDwwLjElIG9mIENQVSB0aW1lIGJ1dCB0 aGF0J3MgaXQuIFByb2JhYmx5IHdpdGggCnRoZSBvcmlnaW5hbCB2ZXJzaW9uIHdoaWNoIHVzZWQg TU1JTyBpdCB3YXMgbXVjaCB3b3JzZS4KClJlZ2FyZHMsCgpUdnJ0a28KCj4gdjI6IFJlYmFzZS4K PiB2MzoKPiAgICogUmViYXNlLCBjb21tZW50cy4KPiAgICogTGVhdmUgZW5naW5lIGJ1c3luZXNz IGNvbnRyb2xzIG91dCBvZiB3b3JrZXJzLgo+IHY0OiBDaGVja3BhdGNoIGNsZWFudXAuCj4gdjU6 IEFkZGVkIGNvbW1lbnQgdG8gcG11X25lZWRzX3RpbWVyIGNoYW5nZS4KPiB2NjoKPiAgICogUmVi YXNlLgo+ICAgKiBGaXggc3R5bGUgb2Ygc29tZSBjb21tZW50cy4gKENocmlzIFdpbHNvbikKPiB2 NzogUmViYXNlIGFuZCBjb21taXQgbWVzc2FnZSB1cGRhdGUuIChDaHJpcyBXaWxzb24pCj4gCj4g U2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4g LS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jICAgICAgICAgfCAzNyArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuaCB8ICA1ICsrKysrCj4gICAyIGZpbGVzIGNoYW5nZWQsIDQwIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcG11LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4gaW5k ZXggZjM0MWM5MDRjMTU5Li45M2MwZTdlYzdkNzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9wbXUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11 LmMKPiBAQCAtOTAsNiArOTAsMTEgQEAgc3RhdGljIHVuc2lnbmVkIGludCBldmVudF9lbmFibGVk X2JpdChzdHJ1Y3QgcGVyZl9ldmVudCAqZXZlbnQpCj4gICAJcmV0dXJuIGNvbmZpZ19lbmFibGVk X2JpdChldmVudC0+YXR0ci5jb25maWcpOwo+ICAgfQo+ICAgCj4gK3N0YXRpYyBib29sIHN1cHBv cnRzX2J1c3lfc3RhdHModm9pZCkKPiArewo+ICsJcmV0dXJuIGk5MTVfbW9kcGFyYW1zLmVuYWJs ZV9leGVjbGlzdHM7Cj4gK30KPiArCj4gICBzdGF0aWMgYm9vbCBwbXVfbmVlZHNfdGltZXIoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIGJvb2wgZ3B1X2FjdGl2ZSkKPiAgIHsKPiAgIAl1 NjQgZW5hYmxlOwo+IEBAIC0xMTUsNiArMTIwLDEyIEBAIHN0YXRpYyBib29sIHBtdV9uZWVkc190 aW1lcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgYm9vbCBncHVfYWN0aXZlKQo+ICAg CSAqLwo+ICAgCWlmICghZ3B1X2FjdGl2ZSkKPiAgIAkJZW5hYmxlICY9IH5FTkdJTkVfU0FNUExF X01BU0s7Cj4gKwkvKgo+ICsJICogQWxzbyB0aGVyZSBpcyBzb2Z0d2FyZSBidXN5bmVzcyB0cmFj a2luZyBhdmFpbGFibGUgd2UgZG8gbm90Cj4gKwkgKiBuZWVkIHRoZSB0aW1lciBmb3IgSTkxNV9T QU1QTEVfQlVTWSBjb3VudGVyLgo+ICsJICovCj4gKwllbHNlIGlmIChzdXBwb3J0c19idXN5X3N0 YXRzKCkpCj4gKwkJZW5hYmxlICY9IH5CSVQoSTkxNV9TQU1QTEVfQlVTWSk7Cj4gICAKPiAgIAkv Kgo+ICAgCSAqIElmIHNvbWUgYml0cyByZW1haW4gaXQgbWVhbnMgd2UgbmVlZCB0aGUgc2FtcGxp bmcgdGltZXIgcnVubmluZy4KPiBAQCAtMzYyLDYgKzM3Myw5IEBAIHN0YXRpYyB1NjQgX19pOTE1 X3BtdV9ldmVudF9yZWFkKHN0cnVjdCBwZXJmX2V2ZW50ICpldmVudCkKPiAgIAo+ICAgCQlpZiAo V0FSTl9PTl9PTkNFKCFlbmdpbmUpKSB7Cj4gICAJCQkvKiBEbyBub3RoaW5nICovCj4gKwkJfSBl bHNlIGlmIChzYW1wbGUgPT0gSTkxNV9TQU1QTEVfQlVTWSAmJgo+ICsJCQkgICBlbmdpbmUtPnBt dS5idXN5X3N0YXRzKSB7Cj4gKwkJCXZhbCA9IGt0aW1lX3RvX25zKGludGVsX2VuZ2luZV9nZXRf YnVzeV90aW1lKGVuZ2luZSkpOwo+ICAgCQl9IGVsc2Ugewo+ICAgCQkJdmFsID0gZW5naW5lLT5w bXUuc2FtcGxlW3NhbXBsZV0uY3VyOwo+ICAgCQl9Cj4gQEAgLTM5OCw2ICs0MTIsMTIgQEAgc3Rh dGljIHZvaWQgaTkxNV9wbXVfZXZlbnRfcmVhZChzdHJ1Y3QgcGVyZl9ldmVudCAqZXZlbnQpCj4g ICAJbG9jYWw2NF9hZGQobmV3IC0gcHJldiwgJmV2ZW50LT5jb3VudCk7Cj4gICB9Cj4gICAKPiAr c3RhdGljIGJvb2wgZW5naW5lX25lZWRzX2J1c3lfc3RhdHMoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKQo+ICt7Cj4gKwlyZXR1cm4gc3VwcG9ydHNfYnVzeV9zdGF0cygpICYmCj4gKwkg ICAgICAgKGVuZ2luZS0+cG11LmVuYWJsZSAmIEJJVChJOTE1X1NBTVBMRV9CVVNZKSk7Cj4gK30K PiArCj4gICBzdGF0aWMgdm9pZCBpOTE1X3BtdV9lbmFibGUoc3RydWN0IHBlcmZfZXZlbnQgKmV2 ZW50KQo+ICAgewo+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1ID0KPiBAQCAtNDM3 LDcgKzQ1NywxNCBAQCBzdGF0aWMgdm9pZCBpOTE1X3BtdV9lbmFibGUoc3RydWN0IHBlcmZfZXZl bnQgKmV2ZW50KQo+ICAgCj4gICAJCUdFTV9CVUdfT04oc2FtcGxlID49IEk5MTVfUE1VX1NBTVBM RV9CSVRTKTsKPiAgIAkJR0VNX0JVR19PTihlbmdpbmUtPnBtdS5lbmFibGVfY291bnRbc2FtcGxl XSA9PSB+MCk7Cj4gLQkJZW5naW5lLT5wbXUuZW5hYmxlX2NvdW50W3NhbXBsZV0rKzsKPiArCQlp ZiAoZW5naW5lLT5wbXUuZW5hYmxlX2NvdW50W3NhbXBsZV0rKyA9PSAwKSB7Cj4gKwkJCWlmIChl bmdpbmVfbmVlZHNfYnVzeV9zdGF0cyhlbmdpbmUpICYmCj4gKwkJCSAgICAhZW5naW5lLT5wbXUu YnVzeV9zdGF0cykgewo+ICsJCQkJZW5naW5lLT5wbXUuYnVzeV9zdGF0cyA9Cj4gKwkJCQkJaW50 ZWxfZW5hYmxlX2VuZ2luZV9zdGF0cyhlbmdpbmUpID09IDA7Cj4gKwkJCQlXQVJOX09OX09OQ0Uo IWVuZ2luZS0+cG11LmJ1c3lfc3RhdHMpOwo+ICsJCQl9Cj4gKwkJfQo+ICAgCX0KPiAgIAo+ICAg CS8qCj4gQEAgLTQ3Myw4ICs1MDAsMTQgQEAgc3RhdGljIHZvaWQgaTkxNV9wbXVfZGlzYWJsZShz dHJ1Y3QgcGVyZl9ldmVudCAqZXZlbnQpCj4gICAJCSAqIERlY3JlbWVudCB0aGUgcmVmZXJlbmNl IGNvdW50IGFuZCBjbGVhciB0aGUgZW5hYmxlZAo+ICAgCQkgKiBiaXRtYXNrIHdoZW4gdGhlIGxh c3QgbGlzdGVuZXIgb24gYW4gZXZlbnQgZ29lcyBhd2F5Lgo+ICAgCQkgKi8KPiAtCQlpZiAoLS1l bmdpbmUtPnBtdS5lbmFibGVfY291bnRbc2FtcGxlXSA9PSAwKQo+ICsJCWlmICgtLWVuZ2luZS0+ cG11LmVuYWJsZV9jb3VudFtzYW1wbGVdID09IDApIHsKPiAgIAkJCWVuZ2luZS0+cG11LmVuYWJs ZSAmPSB+QklUKHNhbXBsZSk7Cj4gKwkJCWlmICghZW5naW5lX25lZWRzX2J1c3lfc3RhdHMoZW5n aW5lKSAmJgo+ICsJCQkgICAgZW5naW5lLT5wbXUuYnVzeV9zdGF0cykgewo+ICsJCQkJZW5naW5l LT5wbXUuYnVzeV9zdGF0cyA9IGZhbHNlOwo+ICsJCQkJaW50ZWxfZGlzYWJsZV9lbmdpbmVfc3Rh dHMoZW5naW5lKTsKPiArCQkJfQo+ICsJCX0KPiAgIAl9Cj4gICAKPiAgIAlHRU1fQlVHX09OKGJp dCA+PSBJOTE1X1BNVV9NQVNLX0JJVFMpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5n YnVmZmVyLmgKPiBpbmRleCBlZTczOGM3Njk0ZTUuLjBmOGNjYjI0MzQwNyAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBAQCAtMzUxLDYgKzM1MSwxMSBAQCBz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzIHsKPiAgIAkJICogT3VyIGludGVybmFsIHRpbWVyIHN0b3Jl cyB0aGUgY3VycmVudCBjb3VudGVycyBpbiB0aGlzIGZpZWxkLgo+ICAgCQkgKi8KPiAgIAkJc3Ry dWN0IGk5MTVfcG11X3NhbXBsZSBzYW1wbGVbSTkxNV9FTkdJTkVfU0FNUExFX01BWF07Cj4gKwkJ LyoqCj4gKwkJICogQGJ1c3lfc3RhdHM6IEhhcyBlbmFibGVtZW50IG9mIGVuZ2luZSBzdGF0cyB0 cmFja2luZyBiZWVuCj4gKwkJICogCQlyZXF1ZXN0ZWQuCj4gKwkJICovCj4gKwkJYm9vbCBidXN5 X3N0YXRzOwo+ICAgCX0gcG11Owo+ICAgCj4gICAJLyoKPiAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==