From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: kraghava@qti.qualcomm.com, meta-virtualization@lists.yoctoproject.org
Cc: vkraleti@qti.qualcomm.com, anujmitt@qti.qualcomm.com,
sbanerje@qti.qualcomm.com
Subject: Re: [PATCH v3 0/2] Add crosvm recipe to meta-virtualization
Date: Mon, 20 Jul 2026 14:11:41 -0700 (PDT) [thread overview]
Message-ID: <6a5e8f0d.4cee2a04.252f89.ec06@mx.google.com> (raw)
In-Reply-To: <20260707132249.677711-1-kraghava@qti.qualcomm.com>
Hi Keerthivasan,
Thanks for the v3, the series has been applied to master and is
staged on master-next.
Nearly every item from the last round is picked up: postfunc-remove is
in place, the LIC_FILES_CHKSUM now points at the in-source LICENSE,
the bindgen wiring (clang-native + LIBCLANG_PATH +
BINDGEN_EXTRA_CLANG_ARGS) is there, BBCLASSEXTEND = "native" is
dropped, the "uage" typo is fixed in the image recipe, and the
KVM_MODULES:aarch64 empty override is kept with a tightened
comment.
The inline TODO about breaking wayland DEPENDS into pkgconfig-mapped
feature flags is a good spot for that follow-up.
One process point for the next round (and for any future series):
please include a "Changes in vN" section in the cover letter. This v3
cover is byte-identical to the v2 cover, so the only way to see what
changed was to diff the actual patches. That works for a 2-patch
series, but it defeats archiving: when we (or anyone else) need to
track a still-open TODO across versions later, the cover-letter
changelog is the canonical place to find it.
Two things I flagged in earlier reviews that this v3 doesn't touch:
1. The single BSD-3-Clause LICENSE declaration for a 966-crate tree
almost certainly under-represents the actual license mix. Not
blocking — other recipes in the layer have the same issue and it's
on my broader cleanup list — but a per-recipe TODO comment would
help track it.
2. The wayland unconditional DEPENDS. You've noted the intent
inline; a real PACKAGECONFIG follow-up is still open.
Neither is blocking the merge; the series is in as-is on master
and master-next.
Recording them here so the trail is on the list.
Bruce
next prev parent reply other threads:[~2026-07-20 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 13:22 [PATCH v3 0/2] Add crosvm recipe to meta-virtualization Keerthivasan Raghavan
2026-07-07 13:22 ` [PATCH v3 1/2] crosvm: add recipe for ChromeOS Virtual Machine Monitor (VMM) Keerthivasan Raghavan
2026-07-07 13:22 ` [PATCH v3 2/2] crosvm-image-minimal: add a reference image for crosvm demo Keerthivasan Raghavan
2026-07-08 1:44 ` [PATCH v3 0/2] Add crosvm recipe to meta-virtualization Bruce Ashfield
2026-07-20 21:11 ` Bruce Ashfield [this message]
2026-07-21 11:08 ` Keerthivasan Raghavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a5e8f0d.4cee2a04.252f89.ec06@mx.google.com \
--to=bruce.ashfield@gmail.com \
--cc=anujmitt@qti.qualcomm.com \
--cc=kraghava@qti.qualcomm.com \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=sbanerje@qti.qualcomm.com \
--cc=vkraleti@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.