Re: [LTP] thp04: Simplify to focus on CVE-2017-1000405 race test only

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

Hi Jan,

> Hi Jan,
> 
> On Tue, 21 Jul 2026, Jan Polensky wrote:
> > thp04: Simplify to focus on CVE-2017-1000405 race test only
> 
> --- [PATCH 1/3] ---
> 
> > Remove ptrace mode support from thp04.c to keep the test focused on
> > its original purpose: testing the CVE-2017-1000405 race condition.
> 
> The pre-patch thp04.c has no ptrace calls or "ptrace mode" branch at
> all -- it is already just the plain fuzzy-sync race test using
> /proc/self/mem. There does not seem to be anything to remove here.
> 
> What the diff actually does is move the static globals (write_thp,
> read_thp, write_ptr, read_ptr, thp_size, writefd, readfd, fzsync_pair)
> into a heap-allocated `struct thp_state *state`, and add a new probe in
> setup() that performs a real write() to /proc/self/mem and reports
> TCONF if it fails with EIO (i.e. when CONFIG_PROC_MEM_FORCE_PTRACE or
> CONFIG_PROC_MEM_NO_FORCE blocks unforced self-writes). Could the commit
> message be updated to describe this actual change and its motivation?

LLMs tends to be a bit verbose in here, so please keep commit message
straight to the point. The rest of the review is correct.

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp