From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18150399372 for ; Mon, 27 Jul 2026 20:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785183725; cv=none; b=XuBU12VMq2zJr6lRAub6G+hdf3SZMc0ncQrVs0VcVe8LBYX6S2YO8VIli9/SwEOBgxC2igVVgnZO3ng4ChIxqa58w2T1pImpTTSCreCvmreZiDjgz1q/tUZfxrPk5Xj5/lczJjzvulpDsh8IbFFGMv05rm/5nvoKi0Pto3d593M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785183725; c=relaxed/simple; bh=m6Fo2EgIL7XM92/wfw+NDLABcCGPzpi1Tg1Fvr75kwE=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i3M2wVlbkb8PKAjSM5bH6NQZIbM9x/LLpFbX8mTY0tx5EJQSOhmzJRQ14kNwdOVKlQfdY+Re9/DCOOTlZ0EMtQBHcjyeov3mbKJUXsxMQJx5hh/E0+nZsiGB9F9CTHcDPgaM6PMIWsCZgSOiQJyEzk9tFMdbougD6RbRkHvCaAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m8QdOv0G; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m8QdOv0G" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4954a32cf1eso16268235e9.3 for ; Mon, 27 Jul 2026 13:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785183722; x=1785788522; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:subject:cc:to:from:date:message-id:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YBuCYxkWRbFtl8jK6C5+fJEPvb/XB+dTpWvS0UE7x2o=; b=m8QdOv0GSN1/BYJv2LOmcHUkHKQ0rboTo//6fFUKBlrI3fEZ/bfyN9rxMfP+qilBOU D8FiSWNtTy5cjUjfPLMqeOsSIJeJnwT87DWTZ+TWCh7cjvdwJGZ56fmZP0KyK6YHPU5M ESmCATbDpW0bgoqXo44kTeNmckbdRJr0Yf1tFgyHrDco5l+RcDVZ9eBCGm4zJxVjGvhg Spiga4NRZFuTQwXZEM3GDsNbGwT4aI/M6X96UolJC/I8xpdkxBYBOz3DSNusQU+tKj9G mUKYxHbQvXq0dmt7Uwp1TukUCvvv0QDr2yi/EqwwRYKxljQGTLdSNjbNe1uQa6YZGCk7 Idfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785183722; x=1785788522; h=in-reply-to:content-disposition:content-type:mime-version :references:subject:cc:to:from:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YBuCYxkWRbFtl8jK6C5+fJEPvb/XB+dTpWvS0UE7x2o=; b=sZrQCm026uT7qscf7jkgpT3VZI6xTqlNd5pLdFweaZZj63GTbr2lBzwPbzk3mmdFp/ Sf0/+naoq/HahLogYGgKvhvHwTmNTki6rYijukhkoBMd1zJjuan+R2U9Todihu9P5RMv EB9g9gi5tcrEtEzo58MoIVLn//4DN5nf8PQ9uUHKOG8Os3wbJnawQhEYlBPwD9pOdiNb bF0x6xG3dDrsOFXQpyYgQGGdns/15FNbb3jCbUaDWQvGfEXhfEEqpWBSDqXNqQQH58g1 Tf6ieLPfM2g3gqvdvabycjVp6kuAzPnW+klPXucCmFlF2TzHYnHeCaRQxecNWNVLMwdt 0imA== X-Forwarded-Encrypted: i=1; AHgh+Rp0+0Q/mUat+L018MBKYHhI0NQqxI/GyztEIXxi1pPk49dr76xafXfCqFMnBjN175gXs31w8jmxoFQK@vger.kernel.org X-Gm-Message-State: AOJu0Yyhs92yrnA/29PeSvuYz7+nooPSUxwCUFPP+rYHOpi9xdI28XrS 9Ee7ipwWtarY10vQNNgpUMeWxHUWJOpHS+WY2u8oU1hmlYuRvU3qlKwc X-Gm-Gg: AR+sD12ZiHPy0tMniGnKBabDh549z7TKVECx5Ugn++E+X8WAvYEsf0HsUHUDOpmVvLW NGS2ROXiuYzNWT9K4QXt/8ravHVNW9jO20Xw8PPyU3oyYz75BvBa3brvsiDiaMoMPfQth7jE4lK ZYpt8JwFQgnOJs0nDu3+7GjFK3Va+fM3utY8rgpWu63RDjVewbY1zkjM7dfUujLDuXlMwCk9dng Tm3zhGIPsnWYfevxNwsOZEHNpUr02uBxwzqNAlBR236qlm3Ar4YO21uXu8rgLZ+5S6NYtRo8DE4 +IjEIRKiJGHqnSI2KLQX74Te7DMyWNT9RoXJV9+VcOoARZIht80pUlBHC5hbk/VOeLkbBpTUlLe 8YZNrG6mqqRBtoORC8G1vVEsFi11b+Z21PYLfvJnOdGgAmdoQRCUgiM0rVVU7J7iWbEISCJBFE7 VkUpnP01hKPNYkUPPim0XaBj/cQzDZxkQSHKI9sWaZVwt2x/QbL9RRNHY= X-Received: by 2002:a05:600c:c87:b0:495:4b00:1bab with SMTP id 5b1f17b1804b1-496b5747e1cmr127217345e9.21.1785183722248; Mon, 27 Jul 2026 13:22:02 -0700 (PDT) Received: from Ansuel-XPS. (host-87-0-193-91.retail.telecomitalia.it. [87.0.193.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85c6287csm52500346f8f.25.2026.07.27.13.22.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 13:22:01 -0700 (PDT) Message-ID: <6a67bde9.8509f64d.df519.9322@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 27 Jul 2026 22:21:57 +0200 From: Christian Marangi To: Brian Masney Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Felix Fietkau , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: clock: airoha: Add PHY binding for Serdes port References: <20260724184304.192962-1-ansuelsmth@gmail.com> <20260724184304.192962-2-ansuelsmth@gmail.com> <6a67baf1.d9578069.494be.a993@mx.google.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 27, 2026 at 04:18:37PM -0400, Brian Masney wrote: > On Mon, Jul 27, 2026 at 10:09:17PM +0200, Christian Marangi wrote: > > On Mon, Jul 27, 2026 at 04:05:43PM -0400, Brian Masney wrote: > > > On Fri, Jul 24, 2026 at 08:43:01PM +0200, Christian Marangi wrote: > > > > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > > > index eb24a5687639..fc37786ac7ed 100644 > > > > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > > > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > > > @@ -23,6 +23,7 @@ description: | > > > > > > > > All these identifiers can be found in: > > > > [1]: . > > > > + [2]: . > > > > > > > > The clocks are provided inside a system controller node. > > > > > > > > @@ -50,6 +51,12 @@ properties: > > > > description: ID of the controller reset line > > > > const: 1 > > > > > > > > + '#phy-cells': > > > > + description: > > > > + The first cell indicates the serdes phy number, see [2] for the > > > > + available serdes port. > > > > + const: 1 > > > > + > > > > required: > > > > - compatible > > > > - reg > > > > @@ -65,12 +72,23 @@ allOf: > > > > reg: > > > > minItems: 2 > > > > > > > > + '#phy-cells': false > > > > + > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + const: econet,en751221-scu > > > > + then: > > > > + properties: > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + '#phy-cells': false > > > > + > > > > - if: > > > > properties: > > > > compatible: > > > > - enum: > > > > - - airoha,en7581-scu > > > > - - econet,en751221-scu > > > > + const: airoha,en7581-scu > > > > then: > > > > properties: > > > > reg: > > > > > > This chunk is new since the split out v10 series[1]. I see that you dropped > > > krzk's Reviewed-by presumably because of the new chunk. However I don't > > > see a changelog. > > > > > > I'm collecting patches up for a clk pull to Stephen. (I'm not sure if > > > he's going to pull but I'm going to try.) I'm not going to include this > > > series until I see a Reviewed-by by one of the dt maintainers on the new > > > patch. > > > > > > https://lore.kernel.org/all/20260702093812.15918-2-ansuelsmth@gmail.com/ > > > > > > > Hi Brian, > > > > yes all correct. I dropped as the patch changed (change is trivial but not > > correct) > > But not correct? Do you need to post a new version of this series? > Also the previous one was O.K.. This is just better. > If this version is correct, then I suggest including a changelog here > for krzk. > Let me add the changelog here so he can quickly check the change: Changelog from v10 series: - Rework if condition and reject #phy-cells for econet,en751221-scu compatible. -- Ansuel