From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] [PATCH 1/2] image-oci: call pm.update() before pm.install() in multi-layer package layers
Date: Tue, 28 Jul 2026 19:30:21 -0700 (PDT) [thread overview]
Message-ID: <6a6965bd.403c09ca.e524c.ee28@mx.google.com> (raw)
In-Reply-To: <20260728115516.1107990-2-koen.kooi@oss.qualcomm.com>
Taken to master-next with two things worth flagging.
1) I reworded the commit message to capture historical context that
only makes sense from the maintainer side: our own multi-layer
test recipes use OCI_LAYER_MODE=multi with packages: layers and
they build fine, so it wasn't obvious at first read why this bug
didn't already burn us. Root cause turned out to be that
image-oci.bbclass has three separate call sites resolving
IMAGE_PKGTYPE with hardcoded defaults that disagree with each
other (rpm/ipk/rpm), so our unpinned builds silently take the
rpm path -- and dnf install refreshes repodata on demand, so the
missing pm.update() was a no-op for us. Reproducing your ipk
trace required someone to actually be using opkg, which we
weren't. The reworded body walks through all of that so the next
reader doesn't have to. Your Signed-off-by is preserved.
2) Two follow-up commits on top:
* "image-oci: unify IMAGE_PKGTYPE default via oci_pkg_type()
helper" -- collapses the three disagreeing defaults into one
shared helper, defaulting to ipk to match oe-core's
PACKAGE_CLASSES default. Nothing changes for anyone who was
already pinning IMAGE_PKGTYPE.
* "tests: assert multi-layer OCI blobs have real content, not
just count" -- our existing multilayer test only checked
len(layers) == 3, which happily passes on a fully-empty build.
Adds a per-layer blob-size floor so a silent pm.install()
failure fails the test the way it should have all along.
Thanks for finding this one. The 2/2 libgcc/libgcc-initial patch
I'm still working through; I'd like to reproduce it locally and
see whether the fix can be simpler than a full BB_TASKDEPDATA
mutation. I'll follow up on that thread separately.
Bruce
next prev parent reply other threads:[~2026-07-29 2:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 11:55 [meta-virtualization][PATCH 0/2] image-oci: two do_image_oci bugfixes (missing pm.update(), libgcc/libgcc-initial sysroot collision) Koen Kooi
2026-07-28 11:55 ` [PATCH 1/2] image-oci: call pm.update() before pm.install() in multi-layer package layers Koen Kooi
2026-07-29 2:30 ` Bruce Ashfield [this message]
2026-07-28 11:55 ` [PATCH 2/2] image-oci: drop *-initial sysroot deps in do_image_oci to avoid libgcc collision Koen Kooi
2026-07-29 3:17 ` [meta-virtualization] " Bruce Ashfield
2026-07-28 12:45 ` [meta-virtualization][PATCH 0/2] image-oci: two do_image_oci bugfixes (missing pm.update(), libgcc/libgcc-initial sysroot collision) Bruce Ashfield
2026-07-28 17:30 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a6965bd.403c09ca.e524c.ee28@mx.google.com \
--to=bruce.ashfield@gmail.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.