From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Shaojie Sun" <sunshaojie@kylinos.cn>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/3] cgroup: add CPU cgroup v2 tests ported from kselftest
Date: Thu, 30 Jul 2026 06:38:58 +0000 [thread overview]
Message-ID: <6a6af183.b2781ae3.74d0c.9671@mx.google.com> (raw)
In-Reply-To: <20260730032850.775128-3-sunshaojie@kylinos.cn>
Hi Shaojie,
> + * Copyright (c) 2025 Richard Palethorpe <rpalethorpe@suse.com>
even before starting the review, why Richie is mentioned as the
developer of these tests?
Also, I would be really careful to convert tests from kselftests
to LTP API. We did that in the past and often it might require
more maintenance than we really need while using cgroups tests
from kselftests.
Is there a reason for this?
Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-30 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 3:28 [LTP] [PATCH 0/3] Add CPU cgroup v2 tests ported from kselftest Shaojie Sun
2026-07-30 3:28 ` [LTP] [PATCH 1/3] tst_cgroup: add cpu.stat and cpu.weight to cgroup file table Shaojie Sun
2026-07-30 7:04 ` [LTP] " linuxtestproject.agent
2026-07-30 3:28 ` [LTP] [PATCH 2/3] cgroup: add CPU cgroup v2 tests ported from kselftest Shaojie Sun
2026-07-30 6:38 ` Andrea Cervesato via ltp [this message]
2026-07-30 3:28 ` [LTP] [PATCH 3/3] runtest/controllers: add CPU cgroup v2 test entries Shaojie Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a6af183.b2781ae3.74d0c.9671@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=sunshaojie@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.