From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Cyril Hrubis" <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/5] syscalls: Add epoll_wait13
Date: Thu, 30 Jul 2026 11:10:24 +0000 [thread overview]
Message-ID: <6a6b3120.16149c93.268d1c.58c5@mx.google.com> (raw)
In-Reply-To: <20260715123612.1684984-3-chrubis@suse.cz>
> if (fds[i][0] > 0) {
> SAFE_CLOSE(fds[i][0]);
> SAFE_CLOSE(fds[i][1]);
> }
It's worth to change the statement to check for fd != -1.
Otherwise:
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-30 11:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 12:36 [LTP] [PATCH v2 0/5] Even more epoll tests Cyril Hrubis
2026-07-15 12:36 ` [LTP] [PATCH v2 1/5] syscalls: Add epoll_ctl07 Cyril Hrubis
2026-07-15 12:59 ` [LTP] " linuxtestproject.agent
2026-07-30 8:49 ` [LTP] [PATCH v2 1/5] " Andrea Cervesato via ltp
2026-07-15 12:36 ` [LTP] [PATCH v2 2/5] syscalls: Add epoll_wait13 Cyril Hrubis
2026-07-30 11:10 ` Andrea Cervesato via ltp [this message]
2026-07-15 12:36 ` [LTP] [PATCH v2 3/5] syscalls: Add epoll_wait14 Cyril Hrubis
2026-07-30 11:12 ` Andrea Cervesato via ltp
2026-07-15 12:36 ` [LTP] [PATCH v2 4/5] syscalls: Add epoll_wait15 Cyril Hrubis
2026-07-30 11:15 ` Andrea Cervesato via ltp
2026-07-15 12:36 ` [LTP] [PATCH v2 5/5] syscalls: Add epoll_wait16 EPOLLEXCLUSIVE test Cyril Hrubis
2026-07-30 11:17 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a6b3120.16149c93.268d1c.58c5@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=chrubis@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.