All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Shaojie Sun" <sunshaojie@kylinos.cn>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 0/3] Add CPU cgroup v2 tests ported from kselftest
Date: Fri, 31 Jul 2026 08:20:39 +0000	[thread overview]
Message-ID: <6a6c5ad7.d9578069.1a429d.2ed8@mx.google.com> (raw)
In-Reply-To: <20260731031343.1298712-1-sunshaojie@kylinos.cn>

Hi Shaojie,

we didn't receive any answer about the reason of introducing this
into LTP. kselftests are not working? are they unmaintained?

But more importantly: once we introduce these rewrite into LTP, 
who's gonna maintain them?

We already had an example of kselftests tests rewritten in
memcontrol02/03 and (as you can see from the history of this ML)
these are causing lots of issues and false positives. Mostly,
unfixable.

What I personally see, it's a duplication of code between projects
and even if LTP core library has a "better" cgroup support than
ksefltests, still, there's a risk we are going to maintain something
that is breaking and someone has to figure our why/what needs a fix.

kselftests almost come "for free" and many people are already using
them all around the world to test cgroups.

For this reason, I'm against adding these tests into LTP, unless
there's a valid maintenance plan for the future.


Kind Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-07-31  8:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 12:25 [LTP] [PATCH v2 0/3] Add CPU cgroup v2 tests ported from kselftest Shaojie Sun
2026-07-30 12:25 ` [LTP] [PATCH v2 1/3] tst_cgroup: add cpu.stat and cpu.weight to cgroup file table Shaojie Sun
2026-07-30 14:06   ` [LTP] " linuxtestproject.agent
2026-07-31  3:13   ` [LTP] [PATCH v3 0/3] Add CPU cgroup v2 tests ported from kselftest Shaojie Sun
2026-07-31  3:13     ` [LTP] [PATCH v3 1/3] tst_cgroup: add cpu.stat and cpu.weight to cgroup file table Shaojie Sun
2026-07-31  6:20       ` [LTP] " linuxtestproject.agent
2026-07-31  3:13     ` [LTP] [PATCH v3 2/3] cgroup: add CPU cgroup v2 tests ported from kselftest Shaojie Sun
2026-07-31  3:13     ` [LTP] [PATCH v3 3/3] runtest/controllers: add CPU cgroup v2 test entries Shaojie Sun
2026-07-31  8:20     ` Andrea Cervesato via ltp [this message]
2026-07-30 12:25 ` [LTP] [PATCH v2 2/3] cgroup: add CPU cgroup v2 tests ported from kselftest Shaojie Sun
2026-07-30 12:25 ` [LTP] [PATCH v2 3/3] runtest/controllers: add CPU cgroup v2 test entries Shaojie Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a6c5ad7.d9578069.1a429d.2ed8@mx.google.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=sunshaojie@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.