Re: [meta-virtualization][PATCH v3] Add Eclipse Ankaios container orchestrator recipe

[Bruce Ashfield <bruce.ashfield@gmail.com>]

Thanks Kaloyan, and enjoy the vacation.

The v2->v3 changes address what I had, and the license comment
referencing deny.toml with the specific crate mappings
(ring / foldhash / borrow-or-share / unicode-ident) is exactly the
audit I was looking for.

The end-to-end test image + README is a nice add too -- it makes this
actually reviewable in a QEMU boot rather than just parsing cleanly.

Two things I'd like fixed before I take it. Neither is urgent; happy
to hold until you're back.

1. LICENSE uses the old bitbake-style '&' separator:

     LICENSE = "Apache-2.0 & MIT & BSD-3-Clause & ISC & Unicode-3.0 & Zlib & MIT-0 & OpenSSL"

   OE-core now emits a "LICENSE is using an old syntax" warning for
   that form -- it wants SPDX-2 with 'AND' / 'OR', alphabetized, no
   commas. We just did a layer-wide sweep for exactly this warning, so
   a brand new recipe on '&' would go straight back into the same
   pile. Suggested:

     LICENSE = "Apache-2.0 AND BSD-3-Clause AND ISC AND MIT AND MIT-0 AND OpenSSL AND Unicode-3.0 AND Zlib"

   MIT-0 might need special handling if oe-core's COMMON_LICENSE_DIR
   doesn't ship it

2. The inherit line and the comment above it disagree. The comment
   says:

     # Add cargo-update-recipe-crates so `bitbake -c update_crates
     # ankaios` works for future maintenance

   but the actual inherit is:

     inherit cargo systemd update-rc.d

   cargo-update-recipe-crates isn't there, so `bitbake -c
   update_crates ankaios` won't actually work. Presumably you meant:

     inherit cargo cargo-update-recipe-crates systemd update-rc.d

   That was the intent I was checking for -- future SRCREV bumps
   should be a `bitbake ankaios -c update_crates` away rather than a
   hand rebuild of ankaios-crates.inc.

Small style thing (not a blocker): `require ${BPN}-crates.inc` sits
above `inherit cargo`. Usually `inherit cargo` goes first and the
require comes after. Doesn't break anything the way you have it, but
it's what most cargo recipes in the layer look like.

I'll wait for v4.

Bruce