From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v2] drm/i915/pmu: Fix sleep under atomic in RC6 readout Date: Wed, 7 Feb 2018 15:06:46 +0100 Message-ID: <6a7d6ffc-ae2d-e335-8ffe-2682f76eb5d2@intel.com> References: <20180206161058.nuc2cfilodtqk32a@ideak-desk.fi.intel.com> <20180206183311.17924-1-tvrtko.ursulin@linux.intel.com> <151795146211.17167.9079739737184415375@mail.alporthouse.com> <20180206215447.mo6f772gcqzj6ivt@ideak-desk.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180206215447.mo6f772gcqzj6ivt@ideak-desk.fi.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: imre.deak@intel.com Cc: David Airlie , Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gMi82LzIwMTggMTA6NTQgUE0sIEltcmUgRGVhayB3cm90ZToKPiBIaSBSYWZhZWwsCj4KPiBP biBUdWUsIEZlYiAwNiwgMjAxOCBhdCAwOToxMTowMlBNICswMDAwLCBDaHJpcyBXaWxzb24gd3Jv dGU6Cj4+IFF1b3RpbmcgVHZydGtvIFVyc3VsaW4gKDIwMTgtMDItMDYgMTg6MzM6MTEpCj4+PiBG cm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pj4KPj4+IFdl IGFyZSBub3QgYWxsb3dlZCB0byBjYWxsIGludGVsX3J1bnRpbWVfcG1fZ2V0IGZyb20gdGhlIFBN VSBjb3VudGVyIHJlYWQKPj4+IGNhbGxiYWNrIHNpbmNlIHRoZSBmb3JtZXIgY2FuIHNsZWVwLCBh bmQgdGhlIGxhdHRlciBpcyBydW5uaW5nIHVuZGVyIElSUQo+Pj4gY29udGV4dC4KPj4+Cj4+PiBU byB3b3JrYXJvdW5kIHRoaXMsIHdlIHJlY29yZCB0aGUgbGFzdCBrbm93biBSQzYgYW5kIHdoaWxl IHJ1bnRpbWUKPj4+IHN1c3BlbmRlZCBlc3RpbWF0ZSBpdHMgaW5jcmVhc2UgYnkgcXVlcnlpbmcg dGhlIHJ1bnRpbWUgUE0gY29yZQo+Pj4gdGltZXN0YW1wcy4KPj4+Cj4+PiBEb3duc2lkZSBvZiB0 aGlzIGFwcHJvYWNoIGlzIHRoYXQgd2UgY2FuIHRlbXBvcmFyaWx5IGxvc2UgYSBjaHVuayBvZiBS QzYKPj4+IHRpbWUsIGZyb20gdGhlIGxhc3QgUE1VIHJlYWQtb3V0IHRvIHJ1bnRpbWUgc3VzcGVu ZCBlbnRyeSwgYnV0IHRoYXQgd2lsbAo+Pj4gZXZlbnR1YWxseSBjYXRjaCB1cCwgb25jZSBkZXZp Y2UgY29tZXMgYmFjayBvbmxpbmUgYW5kIGluIHRoZSBwcmVzZW5jZSBvZgo+Pj4gUE1VIHF1ZXJp ZXMuCj4+Pgo+Pj4gQWxzbywgd2UgaGF2ZSB0byBiZSBjYXJlZnVsIG5vdCB0byBvdmVyc2hvb3Qg dGhlIFJDNiBlc3RpbWF0ZSwgc28gb25jZQo+Pj4gcmVzdW1lZCBhZnRlciBhIHBlcmlvZCBvZiBh cHByb3hpbWF0aW9uLCB3ZSBvbmx5IHVwZGF0ZSB0aGUgY291bnRlciBvbmNlCj4+PiBpdCBjYXRj aGVzIHVwLiBXaXRoIHRoZSBvYnNlcnZhdGlvbiB0aGF0IFJDNiBpcyBpbmNyZWFzaW5nIHdoaWxl IHRoZQo+Pj4gZGV2aWNlIGlzIHN1c3BlbmRlZCwgdGhpcyBzaG91bGQgbm90IHBvc2UgYSBwcm9i bGVtIGFuZCBjYW4gb25seSBjYXVzZQo+Pj4gc2xpZ2h0IGluYWNjdXJhY2llcyBkdWUgY2xvY2sg YmFzZSBkaWZmZXJlbmNlcy4KPj4+Cj4+PiB2MjogU2ltcGxpZnkgYnkgZXN0aW1hdGluZyBvbiB0 b3Agb2YgUE0gY29yZSBjb3VudGVycy4gKEltcmUpCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogVHZy dGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4+IEJ1Z3ppbGxhOiBodHRw czovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ5NDMKPj4+IEZpeGVz OiA2MDYwYjZhZWMwM2MgKCJkcm0vaTkxNS9wbXU6IEFkZCBSQzYgcmVzaWRlbmN5IG1ldHJpY3Mi KQo+Pj4gVGVzdGNhc2U6IGlndC9wZXJmX3BtdS9yYzYtcnVudGltZS1wbQo+Pj4gQ2M6IFR2cnRr byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+PiBDYzogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtA aW50ZWwuY29tPgo+Pj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5j b20+Cj4+PiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwu Y29tPgo+Pj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPj4+IENj OiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4+PiBDYzogaW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+Pj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK Pj4+IC0tLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jIHwgOTMgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9wbXUuaCB8ICA2ICsrKwo+Pj4gICAyIGZpbGVzIGNoYW5nZWQsIDg0IGluc2Vy dGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3BtdS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+ Pj4gaW5kZXggMWM0NDA0NjAyNTVkLi5iZmM0MDJkNDc2MDkgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3BtdS5jCj4+PiBAQCAtNDE1LDcgKzQxNSw4MSBAQCBzdGF0aWMgaW50IGk5MTVfcG11 X2V2ZW50X2luaXQoc3RydWN0IHBlcmZfZXZlbnQgKmV2ZW50KQo+Pj4gICAgICAgICAgcmV0dXJu IDA7Cj4+PiAgIH0KPj4+ICAgCj4+PiAtc3RhdGljIHU2NCBfX2k5MTVfcG11X2V2ZW50X3JlYWQo c3RydWN0IHBlcmZfZXZlbnQgKmV2ZW50KQo+Pj4gK3N0YXRpYyB1NjQgZ2V0X3JjNihzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgYm9vbCBsb2NrZWQpCj4+PiArewo+Pj4gKyAgICAgICB1 bnNpZ25lZCBsb25nIGZsYWdzOwo+Pj4gKyAgICAgICB1NjQgdmFsOwo+Pj4gKwo+Pj4gKyAgICAg ICBpZiAoaW50ZWxfcnVudGltZV9wbV9nZXRfaWZfaW5fdXNlKGk5MTUpKSB7Cj4+PiArICAgICAg ICAgICAgICAgdmFsID0gaW50ZWxfcmM2X3Jlc2lkZW5jeV9ucyhpOTE1LCBJU19WQUxMRVlWSUVX KGk5MTUpID8KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFZMVl9HVF9SRU5ERVJfUkM2IDoKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIEdFTjZfR1RfR0ZYX1JDNik7Cj4+PiArCj4+PiArICAg ICAgICAgICAgICAgaWYgKEhBU19SQzZwKGk5MTUpKQo+Pj4gKyAgICAgICAgICAgICAgICAgICAg ICAgdmFsICs9IGludGVsX3JjNl9yZXNpZGVuY3lfbnMoaTkxNSwgR0VONl9HVF9HRlhfUkM2cCk7 Cj4+PiArCj4+PiArICAgICAgICAgICAgICAgaWYgKEhBU19SQzZwcChpOTE1KSkKPj4+ICsgICAg ICAgICAgICAgICAgICAgICAgIHZhbCArPSBpbnRlbF9yYzZfcmVzaWRlbmN5X25zKGk5MTUsIEdF TjZfR1RfR0ZYX1JDNnBwKTsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgICBpbnRlbF9ydW50aW1l X3BtX3B1dChpOTE1KTsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgICAvKgo+Pj4gKyAgICAgICAg ICAgICAgICAqIElmIHdlIGFyZSBjb21pbmcgYmFjayBmcm9tIGJlaW5nIHJ1bnRpbWUgc3VzcGVu ZGVkIHdlIG11c3QKPj4+ICsgICAgICAgICAgICAgICAgKiBiZSBjYXJlZnVsIG5vdCB0byByZXBv cnQgYSBsYXJnZXIgdmFsdWUgdGhhbiByZXR1cm5lZAo+Pj4gKyAgICAgICAgICAgICAgICAqIHBy ZXZpb3VzbHkuCj4+PiArICAgICAgICAgICAgICAgICovCj4+PiArCj4+PiArICAgICAgICAgICAg ICAgaWYgKCFsb2NrZWQpCj4+PiArICAgICAgICAgICAgICAgICAgICAgICBzcGluX2xvY2tfaXJx c2F2ZSgmaTkxNS0+cG11LmxvY2ssIGZsYWdzKTsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgICBp ZiAodmFsID49IGk5MTUtPnBtdS5zYW1wbGVbX19JOTE1X1NBTVBMRV9SQzZfRVNUSU1BVEVEXS5j dXIpIHsKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGk5MTUtPnBtdS5zYW1wbGVbX19JOTE1 X1NBTVBMRV9SQzZfRVNUSU1BVEVEXS5jdXIgPSAwOwo+Pj4gKyAgICAgICAgICAgICAgICAgICAg ICAgaTkxNS0+cG11LnNhbXBsZVtfX0k5MTVfU0FNUExFX1JDNl0uY3VyID0gdmFsOwo+Pj4gKyAg ICAgICAgICAgICAgIH0gZWxzZSB7Cj4+PiArICAgICAgICAgICAgICAgICAgICAgICB2YWwgPSBp OTE1LT5wbXUuc2FtcGxlW19fSTkxNV9TQU1QTEVfUkM2X0VTVElNQVRFRF0uY3VyOwo+Pj4gKyAg ICAgICAgICAgICAgIH0KPj4+ICsKPj4+ICsgICAgICAgICAgICAgICBpZiAoIWxvY2tlZCkKPj4+ ICsgICAgICAgICAgICAgICAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmk5MTUtPnBt dS5sb2NrLCBmbGFncyk7Cj4+PiArICAgICAgIH0gZWxzZSB7Cj4+PiArICAgICAgICAgICAgICAg c3RydWN0IHBjaV9kZXYgKnBkZXYgPSBpOTE1LT5kcm0ucGRldjsKPj4+ICsgICAgICAgICAgICAg ICBzdHJ1Y3QgZGV2aWNlICprZGV2ID0gJnBkZXYtPmRldjsKPj4+ICsgICAgICAgICAgICAgICB1 bnNpZ25lZCBsb25nIGZsYWdzMjsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgICAvKgo+Pj4gKyAg ICAgICAgICAgICAgICAqIFdlIGFyZSBydW50aW1lIHN1c3BlbmRlZC4KPj4+ICsgICAgICAgICAg ICAgICAgKgo+Pj4gKyAgICAgICAgICAgICAgICAqIFJlcG9ydCB0aGUgZGVsdGEgZnJvbSB3aGVu IHRoZSBkZXZpY2Ugd2FzIHN1c3BlbmRlZCB0byBub3csCj4+PiArICAgICAgICAgICAgICAgICog b24gdG9wIG9mIHRoZSBsYXN0IGtub3duIHJlYWwgdmFsdWUsIGFzIHRoZSBhcHByb3hpbWF0ZWQg UkM2Cj4+PiArICAgICAgICAgICAgICAgICogY291bnRlciB2YWx1ZS4KPj4+ICsgICAgICAgICAg ICAgICAgKi8KPj4+ICsgICAgICAgICAgICAgICBpZiAoIWxvY2tlZCkKPj4+ICsgICAgICAgICAg ICAgICAgICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZpOTE1LT5wbXUubG9jaywgZmxhZ3MpOwo+ Pj4gKwo+Pj4gKyAgICAgICAgICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZrZGV2LT5wb3dlci5s b2NrLCBmbGFnczIpOwo+Pj4gKwo+Pj4gKyAgICAgICAgICAgICAgIGlmICghaTkxNS0+cG11LnNh bXBsZVtfX0k5MTVfU0FNUExFX1JDNl9FU1RJTUFURURdLmN1cikKPj4+ICsgICAgICAgICAgICAg ICAgICAgICAgIGk5MTUtPnBtdS5zdXNwZW5kZWRfamlmZmllc19sYXN0ID0KPj4+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGtkZXYtPnBvd2VyLnN1c3Bl bmRlZF9qaWZmaWVzOwo+Pj4gKwo+Pj4gKyAgICAgICAgICAgICAgIHZhbCA9IGtkZXYtPnBvd2Vy LnN1c3BlbmRlZF9qaWZmaWVzIC0KPj4+ICsgICAgICAgICAgICAgICAgICAgICBpOTE1LT5wbXUu c3VzcGVuZGVkX2ppZmZpZXNfbGFzdDsKPj4+ICsgICAgICAgICAgICAgICB2YWwgKz0gamlmZmll cyAtIGtkZXYtPnBvd2VyLmFjY291bnRpbmdfdGltZXN0YW1wOwo+Pj4gKwo+Pj4gKyAgICAgICAg ICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmtkZXYtPnBvd2VyLmxvY2ssIGZsYWdzMik7 Cj4+PiArCj4+PiArICAgICAgICAgICAgICAgdmFsID0gamlmZmllc190b19uc2Vjcyh2YWwpOwo+ Pj4gKyAgICAgICAgICAgICAgIHZhbCArPSBpOTE1LT5wbXUuc2FtcGxlW19fSTkxNV9TQU1QTEVf UkM2XS5jdXI7Cj4+PiArICAgICAgICAgICAgICAgaTkxNS0+cG11LnNhbXBsZVtfX0k5MTVfU0FN UExFX1JDNl9FU1RJTUFURURdLmN1ciA9IHZhbDsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgICBp ZiAoIWxvY2tlZCkKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJl c3RvcmUoJmk5MTUtPnBtdS5sb2NrLCBmbGFncyk7Cj4+PiArICAgICAgIH0KPj4+ICsKPj4+ICsg ICAgICAgcmV0dXJuIHZhbDsKPj4+ICt9Cj4+IEkgZmVlbCBzbGlnaHRseSBkaXJ0eSwgYnV0IHRo ZSBkYW5jZSBjaGVja3Mgb3V0Lgo+IFdvdWxkIGl0IGJlIHBvc3NpYmxlIHRvIGFkZCBhbiBSUE0g aGVscGVyIHRoYXQgcHJvdmlkZXMgdGhlIGRldmljZSdzCj4gcnVudGltZSBzdXNwZW5kIHJlc2lk ZW5jeSBmb3IgdGhlIGFib3ZlIHB1cnBvc2U/IFRoaXMgd291bGQgYmUKPiBlc3NlbnRpYWxseSB3 aGF0IHJ0cG1fc3VzcGVuZGVkX3RpbWVfc2hvdygpIHByb3ZpZGVzLgoKWWVzLCBpbiBnZW5lcmFs LCBidXQgYXMgYWxyZWFkeSBtZW50aW9uZWQgaW4gdGhpcyB0aHJlYWQsIEkgZ3Vlc3MgaXQncyAK YmV0dGVyIHRvIGRvIHRoYXQgbGF0ZXIgYXMgYW4gZXh0cmEgc3RlcCBmb3IgdGhlIGJhY2twb3J0 YWJpbGl0eSBzYWtlLgoKVGhhbmtzLApSYWZhZWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=