From: hanzhijian <hanzhijian1991@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Viresh Kumar <vireshk@kernel.org>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: bootrom: fix potential NULL dereference
Date: Fri, 21 Aug 2026 05:07:33 -0700 (PDT) [thread overview]
Message-ID: <6a883f85.f375f8af.234495.358a@mx.google.com> (raw)
In-Reply-To: <aog8KROHA18VIZtm@stanley.mountain>
On Fri, Aug 21, 2026 at 02:53:13PM +0300, Dan Carpenter wrote:
> You're using the word "potential" but the commit message correctly
> explains why a NULL dereference is impossible. Don't say potentially
> for things which are impossible.
>
> A lot of people would argue that the original code is easy to follow...
> It's not really fragile either...
You're right on all counts. The commit message contradicts itself, and
the refactor does make the error path harder to follow than the original
if/else. I'll drop this patch.
Thanks for the review.
hanzhijian
prev parent reply other threads:[~2026-08-21 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 11:35 [PATCH] staging: greybus: bootrom: fix potential NULL dereference hanzhijian
2026-08-21 11:53 ` Dan Carpenter
2026-08-21 12:07 ` hanzhijian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a883f85.f375f8af.234495.358a@mx.google.com \
--to=hanzhijian1991@gmail.com \
--cc=elder@kernel.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.