All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Wei Gao" <wegao@suse.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v7] shmctl03: Fix 32-bit compat mode failure by adjusting comparisons for compat mode truncation
Date: Tue, 25 Aug 2026 13:52:41 +0000	[thread overview]
Message-ID: <6a8d9e29.215ab133.223754.df6f@mx.google.com> (raw)
In-Reply-To: <20260821013917.28499-1-wegao@suse.com>

Hi Wei,

title is too long, it needs to be shorten.

> On 64-bit kernels, the default shmmax and shmall values often exceed
> the range of a 32-bit unsigned long or are clipped differently by the
> kernel's compat syscall layer than they appear in /proc.

Also here we are above 85 lines.

> +/**
> + * TST_ASSERT_BITWISE - Keep only the lower 32 bits of the read value.
> + *
> + * If this flag is set, only the low 32 bits of the value read from the
> + * sysfs/procfs file are compared.
> + */
> +#define TST_ASSERT_BITWISE         0x02

I was thinking that this should be probably TST_ASSERT_TRUNC_32BIT, since
bitwise is misleading.

needs to be fixed before merge.

Thanks,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-08-25 13:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  9:26 [LTP] [PATCH v1] shmctl03: Fix 32-bit compat mode failure by forcing limits Wei Gao via ltp
2026-04-10 13:14 ` Andrea Cervesato via ltp
2026-04-10 14:12   ` Wei Gao via ltp
2026-04-10 14:32     ` Andrea Cervesato via ltp
2026-04-13  6:19 ` [LTP] [PATCH v2] shmctl03: Fix 32-bit compat mode failure by adjusting comparisons for compat mode truncation Wei Gao via ltp
2026-04-29  8:04   ` [LTP] " linuxtestproject.agent
2026-04-29 11:18   ` [LTP] [PATCH v3] " Wei Gao via ltp
2026-04-29 12:33     ` [LTP] " linuxtestproject.agent
2026-04-30  3:47     ` [LTP] [PATCH v4] " Wei Gao via ltp
2026-04-30  6:35       ` [LTP] " linuxtestproject.agent
2026-05-06 17:28         ` Andrea Cervesato via ltp
2026-05-07  9:51           ` Wei Gao via ltp
2026-05-07 10:01             ` Andrea Cervesato via ltp
2026-08-19  3:17       ` [LTP] [PATCH v5] " Wei Gao via ltp
2026-08-19  3:48         ` [LTP] " linuxtestproject.agent
2026-08-19  7:11           ` Andrea Cervesato via ltp
2026-08-19  8:38         ` [LTP] [PATCH v6] " Wei Gao via ltp
2026-08-19  9:39           ` [LTP] " linuxtestproject.agent
2026-08-21  1:39           ` [LTP] [PATCH v7] " Wei Gao via ltp
2026-08-21  3:05             ` [LTP] " linuxtestproject.agent
2026-08-25 13:52             ` Andrea Cervesato via ltp [this message]
2026-08-26  7:52             ` [LTP] [PATCH v8] shmctl03: Fix 32-bit compat mode failure Wei Gao via ltp
2026-08-28  9:26               ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a8d9e29.215ab133.223754.df6f@mx.google.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=dan.carpenter@linaro.org \
    --cc=wegao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.