From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it
Subject: Re: [LTP] ima_tpm.sh: properly detect failure to verify the IMA measurement list
Date: Thu, 27 Aug 2026 06:56:15 +0000 [thread overview]
Message-ID: <6a8fdf90.52a3ce3c.38dd62.6301@mx.google.com> (raw)
In-Reply-To: <20260827030518.4078-1-linuxtestproject.agent@gmail.com>
Hi Mimi,
> > + pcr_aggregate="$(cat tmp.txt | awk '{print $1}')"
>
> The cat here is redundant, awk can read the file directly:
>
This is valid.
> > + lineno="$(cat tmp.txt | awk '{print $2}')"
>
> Same here:
>
> lineno="$(awk '{print $2}' tmp.txt)"
[..]
>
> > + tst_res TPASS "aggregate PCR value matched real PCR value (line: $lineno/$total_measurements)"
>
> This line is about 100 columns wide. LTP shell style asks for lines
> under 80 characters; perhaps wrap it or shorten the message.
we can ignore this one.
@Petr can you please take a look?
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-08-27 6:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 22:29 [LTP] [PATCH v2] ima_tpm.sh: properly detect failure to verify the IMA measurement list Mimi Zohar
2026-08-26 22:29 ` Mimi Zohar
2026-08-27 3:05 ` [LTP] " linuxtestproject.agent
2026-08-27 6:56 ` Andrea Cervesato via ltp [this message]
2026-08-27 10:22 ` Petr Vorel
2026-08-27 12:59 ` Petr Vorel
2026-08-27 13:38 ` Mimi Zohar
2026-09-10 19:41 ` [LTP] [PATCH v2] " Petr Vorel
2026-09-10 19:41 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2026-08-26 0:34 [LTP] [PATCH] " Mimi Zohar
2026-08-26 1:15 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a8fdf90.52a3ce3c.38dd62.6301@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=linuxtestproject.agent@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.