All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abdifatah Suruur <suruurism@gmail.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/platform: keep logical vm_pgoff in MMIO region mmap
Date: Sun, 06 Sep 2026 05:33:38 -0700 (PDT)	[thread overview]
Message-ID: <6a9d5da2.c9eda3e9.76660.4544@mx.google.com> (raw)
In-Reply-To: <882503c8-6993-452a-98e5-2eb72faff58b@redhat.com>

On 9/4/26 16:52, Eric Auger wrote:
> While at it, don't you want to fix the same pattern in cdx/main.c,
> fsl-mc/vfio_fsl_mc.c?

Yes - sent as separate patches for both drivers:

- [PATCH] vfio/fsl-mc: keep logical vm_pgoff in MMIO region mmap
  <20260903092922.470-1-suruurism@gmail.com>
- [PATCH] vfio/cdx: keep logical vm_pgoff in MMIO region mmap
  <20260903092932.526-1-suruurism@gmail.com>

And a follow-up for the cdx mmap path: MAP_PRIVATE mappings go through
the COW special case in get_remap_pgoff(), which overwrites vm_pgoff
with the raw PFN regardless of the mmap_mmio change, so vfio_cdx_mmap()
needs the VM_SHARED guard the other drivers already have:

- [PATCH] vfio/cdx: reject non-shared MMIO mmaps
  <20260906123245.10884-1-suruurism@gmail.com>

Thanks for the reviews.

Abdifatah

  reply	other threads:[~2026-09-06 12:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  9:29 [PATCH] vfio/platform: keep logical vm_pgoff in MMIO region mmap Abdifatah Suruur
2026-09-04 13:52 ` Eric Auger
2026-09-06 12:33   ` Abdifatah Suruur [this message]
2026-09-07  5:00     ` Eric Auger
2026-09-07 14:10 ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a9d5da2.c9eda3e9.76660.4544@mx.google.com \
    --to=suruurism@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.