Re: [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes

[Hans Verkuil <hverkuil+cisco@kernel.org>]

On 12/09/2025 13:21, Jai Luthra wrote:
> Hi Hans,
> 
> On Fri, Sep 12, 2025 at 12:17:17PM +0200, Hans Verkuil wrote:
>> Hi Jai,
>>
>> On 12/09/2025 11:55, Jai Luthra wrote:
>>> Hi Hans, Mauro,
>>>
>>> The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:
>>>
>>>   media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)
>>>
>>> are available in the Git repository at:
>>>
>>>   https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed
>>>
>>> for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:
>>>
>>>   media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)
>>>
>>> ----------------------------------------------------------------
>>> TI and Cadence CSI2RX driver changes:
>>>
>>> - Multistream support for Cadence and TI CSI2RX
>>> - Runtime PM support for Cadence and TI CSI2RX
>>> - System suspend and resume support for TI CSI2RX
>>> - Misc cleanups
>>
>> This should go through Sakari most likely, possibly Laurent, seeing that this is CSI
>> related. Several patches do not even have a Reviewed-by from Sakari or Laurent.
>>
>> I can't take this, I'm afraid.
>>
>> I'm not sure why we get a PR from you, was there some misunderstanding?
>>
> 
> Apologies. I had a look at other "GIT PULL" messages on linux-media and 
> inferred that any driver maintainer can send a pull request for media tree.

Ah, no. It's media maintainers that do that. For small subsystems you would post
patches and the subsystem maintainer will (when ready) merge them and send a PR
to Linus.

For large subsystems like media you have multiple media maintainers, each responsible
for a part of the subsystem. They will review and prep a PR for the media maintainers
(me and Mauro) to pick up. The media subsystem is far too big for a single maintainer.

Hopefully once we get the multi-committer up and running (pending doc changes) we can
do away with most of the PRs.

> 
> I looked at 
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html but 
> that was not very informative.
> 
> But yes, happy to wait for more reviews from Sakari and Laurent (or Tomi given 
> this is about streams support).
> 
> Could the process and who-owns-what sub-subsystem be better documented in 
> docs.kernel.org or linuxtv.org? I am aware of the proposed multi-committer 
> model, but until that is finalized even the current process is hard to 
> understand for a newbie :-)

It's here (link below), but I see that it is out-of-date: it's missing Nicolas Dufresne for
codecs and Bryan O'Donoghue for Qualcomm drivers.

https://linuxtv.org/downloads/v4l-dvb-apis-new/driver-api/maintainer-entry-profile.html#media-maintainers

In any case, your PR came in too late. After rc6 is released we only merge fixes as a
general rule. It's good to keep that in mind for the next kernel cycle.

If your PR contains fixes that you believe are important for v6.18, then discuss that
with Sakari and he can post a PR with those fixes.

Regards,

	Hans

> 
>> Regards,
>>
>> 	Hans
>>
> 
> Thanks,
> Jai
> 
>>>
>>> ----------------------------------------------------------------
>>> Changhuang Liang (1):
>>>       media: cadence: csi2rx: Support runtime PM
>>>
>>> Jai Luthra (9):
>>>       dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
>>>       media: ti: j721e-csi2rx: separate out device and context
>>>       media: ti: j721e-csi2rx: add a subdev for the core device
>>>       media: ti: j721e-csi2rx: add support for processing virtual channels
>>>       media: cadence: csi2rx: add multistream support
>>>       media: ti: j721e-csi2rx: add multistream support
>>>       media: ti: j721e-csi2rx: Submit all available buffers
>>>       media: ti: j721e-csi2rx: Support runtime suspend
>>>       media: ti: j721e-csi2rx: Support system suspend using pm_notifier
>>>
>>> Pratyush Yadav (4):
>>>       media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
>>>       media: ti: j721e-csi2rx: allocate DMA channel based on context index
>>>       media: ti: j721e-csi2rx: get number of contexts from device tree
>>>       media: cadence: csi2rx: add get_frame_desc wrapper
>>>
>>> Rishikesh Donadkar (2):
>>>       media: ti: j721e-csi2rx: Remove word size alignment on frame width
>>>       media: ti: j721e-csi2rx: Change the drain architecture for multistream
>>>
>>>  Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
>>>  drivers/media/platform/cadence/Kconfig                            |    1 +
>>>  drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
>>>  drivers/media/platform/ti/Kconfig                                 |    1 +
>>>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
>>>  5 files changed, 1300 insertions(+), 399 deletions(-)
>>>
>>> --
>>> Thanks,
>>>
>>> Jai
>>>
>>