All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Sascha Hauer <sha@pengutronix.de>
Subject: RE: [PATCH v2 1/3] wifi: rtw88: usb: Copy instead of cloning the RX skb
Date: Fri, 20 Dec 2024 00:13:23 +0000	[thread overview]
Message-ID: <6aa9254f7ee84c289527e6e205d52bcb@realtek.com> (raw)
In-Reply-To: <d7adb319-8840-47a3-b17c-87d9dd45f32f@gmail.com>

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> 
> On 19/12/2024 08:17, Ping-Ke Shih wrote:
> > Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> >
> >> +                       skb = alloc_skb(skb_len, GFP_KERNEL);
> >> +                       if (!skb) {
> >> +                               rtw_dbg(rtwdev, RTW_DBG_USB,
> >> +                                       "failed to allocate RX skb of size %u\n",
> >> +                                       skb_len);
> >
> > checkpatch warns this is unnecessary.
> >
> > WARNING: Possible unnecessary 'out of memory' message
> > #94: FILE: drivers/net/wireless/realtek/rtw88/usb.c:591:
> > +                       if (!skb) {
> > +                               rtw_dbg(rtwdev, RTW_DBG_USB,
> >
> >
> >
> 
> checkpatch is wrong about this one. alloc_skb doesn't say
> anything when it fails.

Got it. Then

Acked-by: Ping-Ke Shih <pkshih@realtek.com>



  reply	other threads:[~2024-12-20  0:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 22:33 [PATCH v2 1/3] wifi: rtw88: usb: Copy instead of cloning the RX skb Bitterblue Smith
2024-12-18 22:34 ` [PATCH v2 2/3] wifi: rtw88: Handle C2H_ADAPTIVITY in rtw_fw_c2h_cmd_handle() Bitterblue Smith
2024-12-19  6:19   ` Ping-Ke Shih
2024-12-18 22:35 ` [PATCH v2 3/3] wifi: rtw88: usb: Preallocate and reuse the RX skbs Bitterblue Smith
2024-12-19  7:18   ` Ping-Ke Shih
2024-12-19  6:17 ` [PATCH v2 1/3] wifi: rtw88: usb: Copy instead of cloning the RX skb Ping-Ke Shih
2024-12-19 11:15   ` Bitterblue Smith
2024-12-20  0:13     ` Ping-Ke Shih [this message]
2024-12-23  8:07 ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6aa9254f7ee84c289527e6e205d52bcb@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.