From: Christian Marangi <ansuelsmth@gmail.com>
To: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Daniel Golle <daniel@makrotopia.org>,
Rosen Penev <rosenp@gmail.com>, Sashiko <sashiko-bot@kernel.org>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v3 1/2] net: phy: qca808x: accept the active-high LED polarity mode
Date: Thu, 17 Sep 2026 01:56:55 +0200 [thread overview]
Message-ID: <6aab2cca.142fb78a.207455.5b1d@mx.google.com> (raw)
In-Reply-To: <20260915223138.321307-2-donggeunyoo.kernel@gmail.com>
On Wed, Sep 16, 2026 at 07:31:37AM +0900, Donggeun Yoo wrote:
> commit a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs")
> added PHY_LED_ACTIVE_HIGH, but qca808x_led_polarity_set() still rejects
> everything except PHY_LED_ACTIVE_LOW. An LED node carrying 'active-high'
> therefore falls into the default case and returns -EINVAL, which
> phy_probe() propagates: the mdio device is left unbound and
> phy_attach_direct() falls back to the genphy driver, so the PHY loses
> every qca808x-specific feature, not just the LED.
>
> Accept the mode. The register write below already handles both
> polarities.
>
> Cc: stable@vger.kernel.org
> Fixes: a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs")
> Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
> Assisted-by: Claude:claude-fable-5
Reviewed-by: Christian Marangi <ansuelsmth@gmail.com>
--
Ansuel
next prev parent reply other threads:[~2026-09-16 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 22:31 [PATCH net v3 0/2] net: phy: qca808x: fix the active-high LED polarity mode Donggeun Yoo
2026-09-15 22:31 ` [PATCH net v3 1/2] net: phy: qca808x: accept " Donggeun Yoo
2026-09-16 23:56 ` Christian Marangi [this message]
2026-09-15 22:31 ` [PATCH net v3 2/2] net: phy: qca808x: keep an explicit active-high LED across the reset Donggeun Yoo
2026-09-16 23:57 ` Christian Marangi
2026-09-18 0:10 ` [PATCH net v3 0/2] net: phy: qca808x: fix the active-high LED polarity mode patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aab2cca.142fb78a.207455.5b1d@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=donggeunyoo.kernel@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.