From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"james.smart@broadcom.com" <james.smart@broadcom.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH V3] nvme: set non-mdts limits in nvme_scan_work
Date: Thu, 19 May 2022 19:44:16 +0000 [thread overview]
Message-ID: <6ab0141b-b02c-24f2-016f-4277096d5be3@nvidia.com> (raw)
In-Reply-To: <YoaaRlK8MF7UQrA0@kbusch-mbp.dhcp.thefacebook.com>
On 5/19/22 12:28, Keith Busch wrote:
> On Wed, May 18, 2022 at 08:51:38AM -0700, Chaitanya Kulkarni wrote:
>> + /**
>> + * Identify controller limits can change at controller reset due to
>> + * new firmware download, even though it is not common we cannot ignore
>> + * such scenario. Controller's non-mdts limits are reported in the unit
>> + * of logical blocks that is dependent on the format of attached
>> + * namespace. Hence re-read the limits at the time of ns allocation.
>> + */
>
> I think we usually see the "/**" comment style for kernel doc.
>
> But otherwise, patch looks good.
>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
Yes, I wanted it to be documented in kernel doc.
-ck
prev parent reply other threads:[~2022-05-19 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 15:51 [PATCH V3] nvme: set non-mdts limits in nvme_scan_work Chaitanya Kulkarni
2022-05-19 19:28 ` Keith Busch
2022-05-19 19:44 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ab0141b-b02c-24f2-016f-4277096d5be3@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.