From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07A58C4167E for ; Mon, 15 Nov 2021 21:27:29 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43AC663244 for ; Mon, 15 Nov 2021 21:27:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 43AC663244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 54CDB837AA; Mon, 15 Nov 2021 22:27:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="RJlQ0NGA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8FBAC837B2; Mon, 15 Nov 2021 22:27:24 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CA6CE837AE for ; Mon, 15 Nov 2021 22:27:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id 46C2E1F451AC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1637011641; bh=CQ/Z8Syt+Lqgqyv3+ua+Izx/cmcX9d/+yvs/l26eTb8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=RJlQ0NGARQjLDx7AqhJLCrigNJ5RZFzoqc6Ni29n6DeD+e0/42hk1Gg6GrXUVB5js /urpYCxi139hCvH37eWlphTNRwtoLy4lPKyMwboKeVXWv4wLUTR8VuIK9tCt0xsXYk j+58mua2rTpB9B/nRkLx6CWyKh5ZfNriDbVdSXla1UyycyU5beIZY4NnC+8qYgwSZD d9GkzaY0EjX3cT+O+4sXowUtrHKlBEAE7kuFTbWmJS0V/ywNzJVw6mhpEbGHLMJe/B 3VcOrhPzOurXrSI9w+9737dlwMgZynZb6Uo/9soO+5NwNvwv3BbM9dBID8YHd2I0qe nelRaqPuaSU4w== Subject: Re: [PATCH v2] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board To: Tom Rini Cc: u-boot@lists.denx.de, uboot-imx@nxp.com, aford173@gmail.com, andre.przywara@arm.com, andrey.zhizhikin@leica-geosystems.com, christianshewitt@gmail.com, festevam@gmail.com, hs@denx.de, iliev@ronetix.at, jagan@amarulasolutions.com, marcel.ziswiler@toradex.com, narmstrong@baylibre.com, patrick.delaunay@foss.st.com, pbrobinson@gmail.com, peng.fan@nxp.com, rick@andestech.com, sbabic@denx.de, seanga2@gmail.com, sjg@chromium.org, t.remmet@phytec.de, tharvey@gateworks.com References: <20211115202422.537136-1-ariel.dalessandro@collabora.com> <20211115211133.GX24579@bill-the-cat> From: Ariel D'Alessandro Message-ID: <6ab89061-46eb-ef79-3133-a661f23101d1@collabora.com> Date: Mon, 15 Nov 2021 18:27:08 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211115211133.GX24579@bill-the-cat> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, Thanks for the feedback. On 11/15/21 6:11 PM, Tom Rini wrote: > On Mon, Nov 15, 2021 at 05:24:22PM -0300, Ariel D'Alessandro wrote: > >> Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for: >> >> - 1GiB DDR4 RAM >> - 16 GiB eMMC >> - SD card >> - Gigabit ethernet >> - USBOTG1 peripheral - fastboot >> >> Signed-off-by: Ariel D'Alessandro >> --- >> MAINTAINERS | 8 + > > Typically this goes in to board/.../MAINTAINERS Will fix in v3. > >> arch/arm/dts/imx8mn-var-som.dts | 423 ++++++++++++++ > > What linux kernel version (or, is it just in linux-next?) is this from? It's already supported in current linux/master: $ git describe origin/master v5.16-rc1-3-g8ab774587903 > > [snip] >> +#ifdef CONFIG_SPL_BUILD >> + >> +#define CONFIG_SPL_STACK 0x980000 >> +#define CONFIG_SPL_BSS_START_ADDR 0x950000 >> +#define CONFIG_SPL_BSS_MAX_SIZE SZ_8K >> +#define CONFIG_SYS_SPL_MALLOC_START 0x42200000 >> +#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K >> + >> +/* For RAW image gives a error info not panic */ >> +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE >> + >> +#endif /* CONFIG_SPL_BUILD */ > > We can't guard CONFIG options with CONFIG_SPL_BUILD or > !CONFIG_SPL_BUILD. Sorry I don't understand, could you expand on the proper way to handle the above configuration? AFAICS, several imx8m boards follow this same pattern: $ git grep -l CONFIG_SPL_BUILD -- include/configs/imx8m* include/configs/imx8mm-cl-iot-gate.h include/configs/imx8mm_beacon.h include/configs/imx8mm_evk.h include/configs/imx8mm_icore_mx8mm.h include/configs/imx8mm_venice.h include/configs/imx8mn_beacon.h include/configs/imx8mn_evk.h include/configs/imx8mp_evk.h include/configs/imx8mq_cm.h include/configs/imx8mq_evk.h include/configs/imx8mq_phanbell.h Regards, Ariel