From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [Autotest] [AUTOTEST] [PATCH 1/2] Add latest LTP test in autotest Date: Tue, 7 Jul 2009 12:31:44 -0300 Message-ID: <6ac58f4f0907070831h381a405bqdd58fdfaf132333e@mail.gmail.com> References: <1246863519.2865.18.camel@localhost.localdomain> <33307c790907061137h3da12536q47517b1662498793@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Martin Bligh , Autotest mailing list , Lucas Meneghel Rodrigues , Uri Lublin , kvm-devel To: sudhir kumar Return-path: Received: from mail-vw0-f202.google.com ([209.85.212.202]:62138 "EHLO mail-vw0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756660AbZGGPbq (ORCPT ); Tue, 7 Jul 2009 11:31:46 -0400 Received: by vwj40 with SMTP id 40so3794451vwj.33 for ; Tue, 07 Jul 2009 08:31:45 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jul 7, 2009 at 4:24 AM, sudhir kumar wrote: >> OK, Can we encapsulate this into the wrapper though, rather than making >> people do it manually? in the existing ltp.patch or something? >> > definitely we can do that, but that needs to know about all the corner > cases of failure. So may be we can continue enhancing the patch as per > the failure reports on different OSes. For the most immediate needs, we could try building LTP with make -k. Plain re-package of LTP kinda goes against our own rules. The preferred way to do testsuite modifications is patching before the execution. So let's strive to use the approach 'upstream package unmodified, patch if needed'. That's how distro package does it, makes sense for us too. > 1 more thing I wanted to start a discussion on LTP mailing list is to > make aware the testcase if it is running on a physical host or on a > guest(say KVM guest). Testcases like power management, group > scheduling fairness etc do not make much sense to run on a guest(as > they will fail or break). So It is better for the test to recognise > the environment and not execute if it is under virtualization and it > is supposed to fail or break under that environment. Does that make > sense to you also ? We need to make an assessment of what we would expect to see failing under a guest. LTP has a fairly large codebase, so it will be a fair amount of work. Lucas