From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D585CC54EE9 for ; Tue, 6 Sep 2022 12:35:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B03610E687; Tue, 6 Sep 2022 12:34:24 +0000 (UTC) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD7B710E44F; Mon, 5 Sep 2022 16:32:18 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id by6so9717067ljb.11; Mon, 05 Sep 2022 09:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=Ee8/zXiC17K5Rmn0dM8r0JytBnfg1FnzFfKZcmoJMYt08MtgAEUEjpKH7+0UHsqlkK BZrCCHBnA1Je5o+/sxNlA3yrl0TxM37U7XpZXjbsaVxHKMl2x7PzYQchiiwPobO+z7V/ tYJCFJd1YCvEbeeLM6BvAS/M1DUr6tpSFJVdgoRwA8WStFNY9E6PPHdk4RZZCOrggakT xyQ8/6DOwLr6S51gainQauwtIl7r4PsEHnn/94yga+F5jpf0cp7C0OxDPl+JWqQDMoGv UZySK3bX2kiLPPNYAc06FY4U1q0dxZf5LlWu/claShZQeiMPrvC2bab0MTV9I+5YA40i L12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=EE4eyaTrT0YQ5eN2QI+aVkhSCvGriBL7Kr/8sPd5LUHF2br+9OTfonZPfwxDxAVCJm Ou+fkmKti7Sl8VWRdlmvWzMBQQ40JPCgZhwg5rfrFrVMxm3lpeqQIoRFbM/O3wMzFqOh Vmt9Cj1AAVFTD2UQ3N+lWH7hg3CgGmRRakbD4THiXGrOWClIying5TkVd1E1l30Q0DIK iwypk5HinwUNQQgjK5NUYHNrqeNwm+QR95UTKZVSojZfpLlsTl6wrqjRphpkwXVInUxY uUsgjjMLb+peTkl0EWHXHaCjHe7660+9i80xzuhgNN0bzBziyl1T0lTquxYU/IvDKioJ 11IA== X-Gm-Message-State: ACgBeo0+JGE2T9EPArA2/pYbDW2rCj0iDc2LbDFEAAc4IY/yYfK4imyc NU07X8EDG/nrN+IqipiwiEz15JwPPcrdbg== X-Google-Smtp-Source: AA6agR47yvdHHgnlIjy9Ip2njnz0g5/SwgXMzTGVjcmNgzpxzvtvdxNNmmfmzBYcTnu1KYoufiDMaA== X-Received: by 2002:a2e:88d2:0:b0:263:2c63:d784 with SMTP id a18-20020a2e88d2000000b002632c63d784mr11481762ljk.12.1662395536908; Mon, 05 Sep 2022 09:32:16 -0700 (PDT) Received: from ?IPV6:2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852? ([2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852]) by smtp.googlemail.com with ESMTPSA id q13-20020a056512210d00b004946a758d21sm1235189lfr.161.2022.09.05.09.32.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 09:32:16 -0700 (PDT) From: Mateusz Kwiatkowski X-Google-Original-From: Mateusz Kwiatkowski Message-ID: <6ac67d1f-e5b5-2687-372f-4146eed5cc5d@gmail.com> Date: Mon, 5 Sep 2022 18:32:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: pl To: Maxime Ripard , Geert Uytterhoeven References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-10-459522d653a7@cerno.tech> <242d272b-5b79-986c-9aaf-64e62f6b37ff@gmail.com> <20220905133251.js26hxdosibx4r4i@houat> In-Reply-To: <20220905133251.js26hxdosibx4r4i@houat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 06 Sep 2022 12:33:45 +0000 Subject: Re: [Intel-gfx] [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , David Airlie , Nouveau Dev , DRI Development , Phil Elwell , Emma Anholt , Samuel Holland , Jernej Skrabec , Chen-Yu Tsai , Ben Skeggs , linux-sunxi@lists.linux.dev, Thomas Zimmermann , Intel Graphics Development , Rodrigo Vivi , Daniel Vetter , Linux ARM , Dom Cobley , Dave Stevenson , Linux Kernel Mailing List , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Philipp Zabel Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Maxime, W dniu 5.09.2022 o 15:32, Maxime Ripard pisze: > Hi, > > On Wed, Aug 31, 2022 at 10:14:28AM +0200, Geert Uytterhoeven wrote: >>>> +enum drm_mode_analog { >>>> +    DRM_MODE_ANALOG_NTSC, >>>> +    DRM_MODE_ANALOG_PAL, >>>> +}; >>> >>> Using "NTSC" and "PAL" to describe the 50Hz and 60Hz analog TV modes is common, >>> but strictly speaking a misnomer. Those are color encoding systems, and your >>> patchset fully supports lesser used, but standard encodings for those (e.g. >>> PAL-M for 60Hz and SECAM for 50Hz). I'd propose switching to some more neutral >>> naming scheme. Some ideas: >>> >>> - DRM_MODE_ANALOG_60_HZ / DRM_MODE_ANALOG_50_HZ (after standard refresh rate) >>> - DRM_MODE_ANALOG_525_LINES / DRM_MODE_ANALOG_625_LINES (after standard line >>>   count) >> >> IMHO these are bad names, as e.g. VGA640x480@60 is also analog, using >> 60 Hz and 525 lines.  Add "TV" to the name? >> >>> - DRM_MODE_ANALOG_JM / DRM_MODE_ANALOG_BDGHIKLN (after corresponding ITU System >>>   Letter Designations) >> >> Or DRM_MODE_ITU_*? >> But given the long list of letters, this looks fragile to me. > > Does it matter at all? It's an internal API that isn't exposed at all. > I'd rather have a common name that everyone can understand in this case > rather than a *perfect* name where most will scratch their head > wondering what it's about. You may have a point. But in that case, maybe it'd make sense to at least add a short comment explaining what do you mean by "NTSC" and "PAL" in this context? Best regards, Mateusz Kwiatkowski From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B3363C02 for ; Mon, 5 Sep 2022 16:32:18 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id x10so9756566ljq.4 for ; Mon, 05 Sep 2022 09:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=Ee8/zXiC17K5Rmn0dM8r0JytBnfg1FnzFfKZcmoJMYt08MtgAEUEjpKH7+0UHsqlkK BZrCCHBnA1Je5o+/sxNlA3yrl0TxM37U7XpZXjbsaVxHKMl2x7PzYQchiiwPobO+z7V/ tYJCFJd1YCvEbeeLM6BvAS/M1DUr6tpSFJVdgoRwA8WStFNY9E6PPHdk4RZZCOrggakT xyQ8/6DOwLr6S51gainQauwtIl7r4PsEHnn/94yga+F5jpf0cp7C0OxDPl+JWqQDMoGv UZySK3bX2kiLPPNYAc06FY4U1q0dxZf5LlWu/claShZQeiMPrvC2bab0MTV9I+5YA40i L12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=NJAGktUqHJSFe8uXMTaRlKoGo7qYRIVqvSTmTg/p7S3vry+Qi7Hrcg3J+KNUSJv5LW HnwNigl97LYuPxZycqrVZYoV5N5AMyRJQigmAibp/BTpGIdhYiq2tKFleMAGb3X2C+kE bpbEEpUdubXS4UPqpVcgSfm8mpMBoi40ofLQmfkjhIlAcJVaFGpL3BSofb6uuQIGU0mu sL5mep7RS1gt3kXbn/hayHh9cEDH/u6UVPa2OoLf52iwL4ynXhWW9Oc3cmXbyd8gxubr ekEUqeN8MvnLCKoi+V/D2JURc5ZwvTB6n15qXNWhzfeOd0mcLtas61d84MhsIgNzC9Qf fQiQ== X-Gm-Message-State: ACgBeo32qiNrIW7eUfnmICL7DRQT3LjurW4CLmnDBw00XERBzKV2wxVu QB2E4cML9imlYIf+HL6zzNA= X-Google-Smtp-Source: AA6agR47yvdHHgnlIjy9Ip2njnz0g5/SwgXMzTGVjcmNgzpxzvtvdxNNmmfmzBYcTnu1KYoufiDMaA== X-Received: by 2002:a2e:88d2:0:b0:263:2c63:d784 with SMTP id a18-20020a2e88d2000000b002632c63d784mr11481762ljk.12.1662395536908; Mon, 05 Sep 2022 09:32:16 -0700 (PDT) Received: from ?IPV6:2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852? ([2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852]) by smtp.googlemail.com with ESMTPSA id q13-20020a056512210d00b004946a758d21sm1235189lfr.161.2022.09.05.09.32.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 09:32:16 -0700 (PDT) From: Mateusz Kwiatkowski X-Google-Original-From: Mateusz Kwiatkowski Message-ID: <6ac67d1f-e5b5-2687-372f-4146eed5cc5d@gmail.com> Date: Mon, 5 Sep 2022 18:32:14 +0200 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes Content-Language: pl To: Maxime Ripard , Geert Uytterhoeven Cc: Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Hans de Goede , Linux ARM , Phil Elwell , Intel Graphics Development , Dave Stevenson , DRI Development , Dom Cobley , Linux Kernel Mailing List , Nouveau Dev , linux-sunxi@lists.linux.dev References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-10-459522d653a7@cerno.tech> <242d272b-5b79-986c-9aaf-64e62f6b37ff@gmail.com> <20220905133251.js26hxdosibx4r4i@houat> In-Reply-To: <20220905133251.js26hxdosibx4r4i@houat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Maxime, W dniu 5.09.2022 o 15:32, Maxime Ripard pisze: > Hi, > > On Wed, Aug 31, 2022 at 10:14:28AM +0200, Geert Uytterhoeven wrote: >>>> +enum drm_mode_analog { >>>> +    DRM_MODE_ANALOG_NTSC, >>>> +    DRM_MODE_ANALOG_PAL, >>>> +}; >>> >>> Using "NTSC" and "PAL" to describe the 50Hz and 60Hz analog TV modes is common, >>> but strictly speaking a misnomer. Those are color encoding systems, and your >>> patchset fully supports lesser used, but standard encodings for those (e.g. >>> PAL-M for 60Hz and SECAM for 50Hz). I'd propose switching to some more neutral >>> naming scheme. Some ideas: >>> >>> - DRM_MODE_ANALOG_60_HZ / DRM_MODE_ANALOG_50_HZ (after standard refresh rate) >>> - DRM_MODE_ANALOG_525_LINES / DRM_MODE_ANALOG_625_LINES (after standard line >>>   count) >> >> IMHO these are bad names, as e.g. VGA640x480@60 is also analog, using >> 60 Hz and 525 lines.  Add "TV" to the name? >> >>> - DRM_MODE_ANALOG_JM / DRM_MODE_ANALOG_BDGHIKLN (after corresponding ITU System >>>   Letter Designations) >> >> Or DRM_MODE_ITU_*? >> But given the long list of letters, this looks fragile to me. > > Does it matter at all? It's an internal API that isn't exposed at all. > I'd rather have a common name that everyone can understand in this case > rather than a *perfect* name where most will scratch their head > wondering what it's about. You may have a point. But in that case, maybe it'd make sense to at least add a short comment explaining what do you mean by "NTSC" and "PAL" in this context? Best regards, Mateusz Kwiatkowski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0E21ECAAA1 for ; Tue, 6 Sep 2022 20:32:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB68810EAB4; Tue, 6 Sep 2022 20:31:31 +0000 (UTC) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD7B710E44F; Mon, 5 Sep 2022 16:32:18 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id by6so9717067ljb.11; Mon, 05 Sep 2022 09:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=Ee8/zXiC17K5Rmn0dM8r0JytBnfg1FnzFfKZcmoJMYt08MtgAEUEjpKH7+0UHsqlkK BZrCCHBnA1Je5o+/sxNlA3yrl0TxM37U7XpZXjbsaVxHKMl2x7PzYQchiiwPobO+z7V/ tYJCFJd1YCvEbeeLM6BvAS/M1DUr6tpSFJVdgoRwA8WStFNY9E6PPHdk4RZZCOrggakT xyQ8/6DOwLr6S51gainQauwtIl7r4PsEHnn/94yga+F5jpf0cp7C0OxDPl+JWqQDMoGv UZySK3bX2kiLPPNYAc06FY4U1q0dxZf5LlWu/claShZQeiMPrvC2bab0MTV9I+5YA40i L12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=EE4eyaTrT0YQ5eN2QI+aVkhSCvGriBL7Kr/8sPd5LUHF2br+9OTfonZPfwxDxAVCJm Ou+fkmKti7Sl8VWRdlmvWzMBQQ40JPCgZhwg5rfrFrVMxm3lpeqQIoRFbM/O3wMzFqOh Vmt9Cj1AAVFTD2UQ3N+lWH7hg3CgGmRRakbD4THiXGrOWClIying5TkVd1E1l30Q0DIK iwypk5HinwUNQQgjK5NUYHNrqeNwm+QR95UTKZVSojZfpLlsTl6wrqjRphpkwXVInUxY uUsgjjMLb+peTkl0EWHXHaCjHe7660+9i80xzuhgNN0bzBziyl1T0lTquxYU/IvDKioJ 11IA== X-Gm-Message-State: ACgBeo0+JGE2T9EPArA2/pYbDW2rCj0iDc2LbDFEAAc4IY/yYfK4imyc NU07X8EDG/nrN+IqipiwiEz15JwPPcrdbg== X-Google-Smtp-Source: AA6agR47yvdHHgnlIjy9Ip2njnz0g5/SwgXMzTGVjcmNgzpxzvtvdxNNmmfmzBYcTnu1KYoufiDMaA== X-Received: by 2002:a2e:88d2:0:b0:263:2c63:d784 with SMTP id a18-20020a2e88d2000000b002632c63d784mr11481762ljk.12.1662395536908; Mon, 05 Sep 2022 09:32:16 -0700 (PDT) Received: from ?IPV6:2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852? ([2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852]) by smtp.googlemail.com with ESMTPSA id q13-20020a056512210d00b004946a758d21sm1235189lfr.161.2022.09.05.09.32.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 09:32:16 -0700 (PDT) From: Mateusz Kwiatkowski X-Google-Original-From: Mateusz Kwiatkowski Message-ID: <6ac67d1f-e5b5-2687-372f-4146eed5cc5d@gmail.com> Date: Mon, 5 Sep 2022 18:32:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: pl To: Maxime Ripard , Geert Uytterhoeven References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-10-459522d653a7@cerno.tech> <242d272b-5b79-986c-9aaf-64e62f6b37ff@gmail.com> <20220905133251.js26hxdosibx4r4i@houat> In-Reply-To: <20220905133251.js26hxdosibx4r4i@houat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 06 Sep 2022 20:31:03 +0000 Subject: Re: [Nouveau] [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Nouveau Dev , Joonas Lahtinen , DRI Development , Phil Elwell , Emma Anholt , Samuel Holland , Jernej Skrabec , Chen-Yu Tsai , Ben Skeggs , linux-sunxi@lists.linux.dev, Intel Graphics Development , Maarten Lankhorst , Jani Nikula , Hans de Goede , Rodrigo Vivi , Daniel Vetter , Linux ARM , Tvrtko Ursulin , Dom Cobley , Linux Kernel Mailing List , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Philipp Zabel Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Hi Maxime, W dniu 5.09.2022 o 15:32, Maxime Ripard pisze: > Hi, > > On Wed, Aug 31, 2022 at 10:14:28AM +0200, Geert Uytterhoeven wrote: >>>> +enum drm_mode_analog { >>>> +    DRM_MODE_ANALOG_NTSC, >>>> +    DRM_MODE_ANALOG_PAL, >>>> +}; >>> >>> Using "NTSC" and "PAL" to describe the 50Hz and 60Hz analog TV modes is common, >>> but strictly speaking a misnomer. Those are color encoding systems, and your >>> patchset fully supports lesser used, but standard encodings for those (e.g. >>> PAL-M for 60Hz and SECAM for 50Hz). I'd propose switching to some more neutral >>> naming scheme. Some ideas: >>> >>> - DRM_MODE_ANALOG_60_HZ / DRM_MODE_ANALOG_50_HZ (after standard refresh rate) >>> - DRM_MODE_ANALOG_525_LINES / DRM_MODE_ANALOG_625_LINES (after standard line >>>   count) >> >> IMHO these are bad names, as e.g. VGA640x480@60 is also analog, using >> 60 Hz and 525 lines.  Add "TV" to the name? >> >>> - DRM_MODE_ANALOG_JM / DRM_MODE_ANALOG_BDGHIKLN (after corresponding ITU System >>>   Letter Designations) >> >> Or DRM_MODE_ITU_*? >> But given the long list of letters, this looks fragile to me. > > Does it matter at all? It's an internal API that isn't exposed at all. > I'd rather have a common name that everyone can understand in this case > rather than a *perfect* name where most will scratch their head > wondering what it's about. You may have a point. But in that case, maybe it'd make sense to at least add a short comment explaining what do you mean by "NTSC" and "PAL" in this context? Best regards, Mateusz Kwiatkowski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57D8CECAAD5 for ; Mon, 5 Sep 2022 18:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: MIME-Version:Date:Message-ID:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uiz15sGr4TgIc5SaYTCZxgxcBKmaQUYD736NgWMl1iA=; b=Ica3z3Jf32/ud/ 0szodrTf17T4UUrRNeevlxT7bkiW48hmSeuBuslMH+KL1hvC0etcQsfqghWhGDRlzdyVHgKbiIP/G Zf9wspvgLBOsPIUeywEyz9mEF3AZX99NxoOtq4RWdrHBtxhQp2bfJHRlH96TnUfgYEgV0Xivvv1a7 UcfHKwbopEfvADlvSx7WWjzCfQtUAwM+dVWCnv6IJRky8sKddKkmfQ5stlgmODCVk8gbFM3/feHoi Voku4ixVNCXQ0/4LbeW5l8DRRMJEvuya2PRqNR4JMB2/z76dy8ytUM+6ejfI0oA+So/dQNVzVboJw p2faL+B0PTmQ9Z8XyKQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVGsM-008Rhh-80; Mon, 05 Sep 2022 18:31:16 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVF1M-006tVy-VG for linux-arm-kernel@bombadil.infradead.org; Mon, 05 Sep 2022 16:32:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:References:Cc:To:Subject:MIME-Version:Date:Message-ID:From: Sender:Reply-To:Content-ID:Content-Description; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=IHgM7bKXYKB169qvRcwCiSYKfA neoULKqinQGHR+R6eorHveMW5xJCYRMhYIwU+dtp6oMb0e1WKN/U8A4p8W8AZxmTI3Kx4EQM+p50f bLpR+cnzjsv5h006g/8ai53wY22Ucx1vN9VtMCna7o8TiRoDKiL/xEnHUntL/rwQ8z/Q3TMMraNXY emqsmUcfHSTEo/Jjn3jxKoCtKTG7+yR1AY5kqM6Q/w9EJWCTNXsV+gAQh1XeyWfRtTBBTQ+I2tJnU dJESYG3tqRmQX3GlpwNfN4Tt8Gx0876scUtCmKkQEc/O9aKiYnDDiZ+WrDLseUh7SZ6u53Rb5VeFi QDXhEODA==; Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVF1I-009pba-UL for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 16:32:23 +0000 Received: by mail-lj1-x22d.google.com with SMTP id l12so1310295ljg.9 for ; Mon, 05 Sep 2022 09:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=Ee8/zXiC17K5Rmn0dM8r0JytBnfg1FnzFfKZcmoJMYt08MtgAEUEjpKH7+0UHsqlkK BZrCCHBnA1Je5o+/sxNlA3yrl0TxM37U7XpZXjbsaVxHKMl2x7PzYQchiiwPobO+z7V/ tYJCFJd1YCvEbeeLM6BvAS/M1DUr6tpSFJVdgoRwA8WStFNY9E6PPHdk4RZZCOrggakT xyQ8/6DOwLr6S51gainQauwtIl7r4PsEHnn/94yga+F5jpf0cp7C0OxDPl+JWqQDMoGv UZySK3bX2kiLPPNYAc06FY4U1q0dxZf5LlWu/claShZQeiMPrvC2bab0MTV9I+5YA40i L12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=S63RGcDrCOq6drWvkciFfr5WCynEvfB3RwxuCIgmuA/eBHMWCn4JbR4qckwcrmZEy9 e9Fqawlb1HnT7POecJajWfVcImk7Aw1vZFzJu2yst8EzVIVv7ml+SSVrqECSb2qDOh+X prPS9Q6EmzElzxAK3C5Fogvv9Po8FA7SKXwV1GxwLBNRBwbQvMLURFwwAU1fwORuuQ26 kjdtjr7mnZ1X1/5jnnuGatqq3eCBK+RUpgt48ifh0IdrH1te9AU/DcbS+BeCS1DD1N4y tF7ZGdeKUFshDx1YJ7yLiEui7XGBCjTWUYnB00fZqj/6El6bS02rmwEtGeLQoee2d/Rw 5pNg== X-Gm-Message-State: ACgBeo3PBo/1ZP4uV/tquCLhiAgl8UntgabPPWV7qiMJY9zzHvvhkA1B WZyfnHrpM6wtMH/cLs6o/Dw= X-Google-Smtp-Source: AA6agR47yvdHHgnlIjy9Ip2njnz0g5/SwgXMzTGVjcmNgzpxzvtvdxNNmmfmzBYcTnu1KYoufiDMaA== X-Received: by 2002:a2e:88d2:0:b0:263:2c63:d784 with SMTP id a18-20020a2e88d2000000b002632c63d784mr11481762ljk.12.1662395536908; Mon, 05 Sep 2022 09:32:16 -0700 (PDT) Received: from ?IPV6:2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852? ([2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852]) by smtp.googlemail.com with ESMTPSA id q13-20020a056512210d00b004946a758d21sm1235189lfr.161.2022.09.05.09.32.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 09:32:16 -0700 (PDT) From: Mateusz Kwiatkowski X-Google-Original-From: Mateusz Kwiatkowski Message-ID: <6ac67d1f-e5b5-2687-372f-4146eed5cc5d@gmail.com> Date: Mon, 5 Sep 2022 18:32:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes Content-Language: pl To: Maxime Ripard , Geert Uytterhoeven Cc: Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Hans de Goede , Linux ARM , Phil Elwell , Intel Graphics Development , Dave Stevenson , DRI Development , Dom Cobley , Linux Kernel Mailing List , Nouveau Dev , linux-sunxi@lists.linux.dev References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-10-459522d653a7@cerno.tech> <242d272b-5b79-986c-9aaf-64e62f6b37ff@gmail.com> <20220905133251.js26hxdosibx4r4i@houat> In-Reply-To: <20220905133251.js26hxdosibx4r4i@houat> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_173221_469301_F0D10070 X-CRM114-Status: GOOD ( 17.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWF4aW1lLAoKVyBkbml1IDUuMDkuMjAyMiBvIDE1OjMyLCBNYXhpbWUgUmlwYXJkIHBpc3pl Ogo+IEhpLAo+Cj4gT24gV2VkLCBBdWcgMzEsIDIwMjIgYXQgMTA6MTQ6MjhBTSArMDIwMCwgR2Vl cnQgVXl0dGVyaG9ldmVuIHdyb3RlOgo+Pj4+ICtlbnVtIGRybV9tb2RlX2FuYWxvZyB7Cj4+Pj4g K8KgwqDCoCBEUk1fTU9ERV9BTkFMT0dfTlRTQywKPj4+PiArwqDCoMKgIERSTV9NT0RFX0FOQUxP R19QQUwsCj4+Pj4gK307Cj4+Pgo+Pj4gVXNpbmcgIk5UU0MiIGFuZCAiUEFMIiB0byBkZXNjcmli ZSB0aGUgNTBIeiBhbmQgNjBIeiBhbmFsb2cgVFYgbW9kZXMgaXMgY29tbW9uLAo+Pj4gYnV0IHN0 cmljdGx5IHNwZWFraW5nIGEgbWlzbm9tZXIuIFRob3NlIGFyZSBjb2xvciBlbmNvZGluZyBzeXN0 ZW1zLCBhbmQgeW91cgo+Pj4gcGF0Y2hzZXQgZnVsbHkgc3VwcG9ydHMgbGVzc2VyIHVzZWQsIGJ1 dCBzdGFuZGFyZCBlbmNvZGluZ3MgZm9yIHRob3NlIChlLmcuCj4+PiBQQUwtTSBmb3IgNjBIeiBh bmQgU0VDQU0gZm9yIDUwSHopLiBJJ2QgcHJvcG9zZSBzd2l0Y2hpbmcgdG8gc29tZSBtb3JlIG5l dXRyYWwKPj4+IG5hbWluZyBzY2hlbWUuIFNvbWUgaWRlYXM6Cj4+Pgo+Pj4gLSBEUk1fTU9ERV9B TkFMT0dfNjBfSFogLyBEUk1fTU9ERV9BTkFMT0dfNTBfSFogKGFmdGVyIHN0YW5kYXJkIHJlZnJl c2ggcmF0ZSkKPj4+IC0gRFJNX01PREVfQU5BTE9HXzUyNV9MSU5FUyAvIERSTV9NT0RFX0FOQUxP R182MjVfTElORVMgKGFmdGVyIHN0YW5kYXJkIGxpbmUKPj4+wqDCoCBjb3VudCkKPj4KPj4gSU1I TyB0aGVzZSBhcmUgYmFkIG5hbWVzLCBhcyBlLmcuIFZHQTY0MHg0ODBANjAgaXMgYWxzbyBhbmFs b2csIHVzaW5nCj4+IDYwIEh6IGFuZCA1MjUgbGluZXMuwqAgQWRkICJUViIgdG8gdGhlIG5hbWU/ Cj4+Cj4+PiAtIERSTV9NT0RFX0FOQUxPR19KTSAvIERSTV9NT0RFX0FOQUxPR19CREdISUtMTiAo YWZ0ZXIgY29ycmVzcG9uZGluZyBJVFUgU3lzdGVtCj4+PsKgwqAgTGV0dGVyIERlc2lnbmF0aW9u cykKPj4KPj4gT3IgRFJNX01PREVfSVRVXyo/Cj4+IEJ1dCBnaXZlbiB0aGUgbG9uZyBsaXN0IG9m IGxldHRlcnMsIHRoaXMgbG9va3MgZnJhZ2lsZSB0byBtZS4KPgo+IERvZXMgaXQgbWF0dGVyIGF0 IGFsbD8gSXQncyBhbiBpbnRlcm5hbCBBUEkgdGhhdCBpc24ndCBleHBvc2VkIGF0IGFsbC4KPiBJ J2QgcmF0aGVyIGhhdmUgYSBjb21tb24gbmFtZSB0aGF0IGV2ZXJ5b25lIGNhbiB1bmRlcnN0YW5k IGluIHRoaXMgY2FzZQo+IHJhdGhlciB0aGFuIGEgKnBlcmZlY3QqIG5hbWUgd2hlcmUgbW9zdCB3 aWxsIHNjcmF0Y2ggdGhlaXIgaGVhZAo+IHdvbmRlcmluZyB3aGF0IGl0J3MgYWJvdXQuCgpZb3Ug bWF5IGhhdmUgYSBwb2ludC4gQnV0IGluIHRoYXQgY2FzZSwgbWF5YmUgaXQnZCBtYWtlIHNlbnNl IHRvIGF0IGxlYXN0IGFkZAphIHNob3J0IGNvbW1lbnQgZXhwbGFpbmluZyB3aGF0IGRvIHlvdSBt ZWFuIGJ5ICJOVFNDIiBhbmQgIlBBTCIgaW4gdGhpcyBjb250ZXh0PwoKQmVzdCByZWdhcmRzLApN YXRldXN6IEt3aWF0a293c2tpCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A98E4ECAAD3 for ; Mon, 5 Sep 2022 16:32:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0198710E44F; Mon, 5 Sep 2022 16:32:22 +0000 (UTC) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD7B710E44F; Mon, 5 Sep 2022 16:32:18 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id by6so9717067ljb.11; Mon, 05 Sep 2022 09:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=Ee8/zXiC17K5Rmn0dM8r0JytBnfg1FnzFfKZcmoJMYt08MtgAEUEjpKH7+0UHsqlkK BZrCCHBnA1Je5o+/sxNlA3yrl0TxM37U7XpZXjbsaVxHKMl2x7PzYQchiiwPobO+z7V/ tYJCFJd1YCvEbeeLM6BvAS/M1DUr6tpSFJVdgoRwA8WStFNY9E6PPHdk4RZZCOrggakT xyQ8/6DOwLr6S51gainQauwtIl7r4PsEHnn/94yga+F5jpf0cp7C0OxDPl+JWqQDMoGv UZySK3bX2kiLPPNYAc06FY4U1q0dxZf5LlWu/claShZQeiMPrvC2bab0MTV9I+5YA40i L12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=8JQHR0mNkkvaucEp4HNFvrtWVwipxgdCyYirWkcxCuc=; b=EE4eyaTrT0YQ5eN2QI+aVkhSCvGriBL7Kr/8sPd5LUHF2br+9OTfonZPfwxDxAVCJm Ou+fkmKti7Sl8VWRdlmvWzMBQQ40JPCgZhwg5rfrFrVMxm3lpeqQIoRFbM/O3wMzFqOh Vmt9Cj1AAVFTD2UQ3N+lWH7hg3CgGmRRakbD4THiXGrOWClIying5TkVd1E1l30Q0DIK iwypk5HinwUNQQgjK5NUYHNrqeNwm+QR95UTKZVSojZfpLlsTl6wrqjRphpkwXVInUxY uUsgjjMLb+peTkl0EWHXHaCjHe7660+9i80xzuhgNN0bzBziyl1T0lTquxYU/IvDKioJ 11IA== X-Gm-Message-State: ACgBeo0+JGE2T9EPArA2/pYbDW2rCj0iDc2LbDFEAAc4IY/yYfK4imyc NU07X8EDG/nrN+IqipiwiEz15JwPPcrdbg== X-Google-Smtp-Source: AA6agR47yvdHHgnlIjy9Ip2njnz0g5/SwgXMzTGVjcmNgzpxzvtvdxNNmmfmzBYcTnu1KYoufiDMaA== X-Received: by 2002:a2e:88d2:0:b0:263:2c63:d784 with SMTP id a18-20020a2e88d2000000b002632c63d784mr11481762ljk.12.1662395536908; Mon, 05 Sep 2022 09:32:16 -0700 (PDT) Received: from ?IPV6:2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852? ([2a02:a31a:a240:1700:9c45:8fa1:8ce7:8852]) by smtp.googlemail.com with ESMTPSA id q13-20020a056512210d00b004946a758d21sm1235189lfr.161.2022.09.05.09.32.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 09:32:16 -0700 (PDT) From: Mateusz Kwiatkowski X-Google-Original-From: Mateusz Kwiatkowski Message-ID: <6ac67d1f-e5b5-2687-372f-4146eed5cc5d@gmail.com> Date: Mon, 5 Sep 2022 18:32:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes Content-Language: pl To: Maxime Ripard , Geert Uytterhoeven References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-10-459522d653a7@cerno.tech> <242d272b-5b79-986c-9aaf-64e62f6b37ff@gmail.com> <20220905133251.js26hxdosibx4r4i@houat> In-Reply-To: <20220905133251.js26hxdosibx4r4i@houat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , David Airlie , Nouveau Dev , DRI Development , Phil Elwell , Emma Anholt , Samuel Holland , Jernej Skrabec , Chen-Yu Tsai , Ben Skeggs , linux-sunxi@lists.linux.dev, Thomas Zimmermann , Intel Graphics Development , Hans de Goede , Rodrigo Vivi , Linux ARM , Tvrtko Ursulin , Dom Cobley , Dave Stevenson , Linux Kernel Mailing List , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, W dniu 5.09.2022 o 15:32, Maxime Ripard pisze: > Hi, > > On Wed, Aug 31, 2022 at 10:14:28AM +0200, Geert Uytterhoeven wrote: >>>> +enum drm_mode_analog { >>>> +    DRM_MODE_ANALOG_NTSC, >>>> +    DRM_MODE_ANALOG_PAL, >>>> +}; >>> >>> Using "NTSC" and "PAL" to describe the 50Hz and 60Hz analog TV modes is common, >>> but strictly speaking a misnomer. Those are color encoding systems, and your >>> patchset fully supports lesser used, but standard encodings for those (e.g. >>> PAL-M for 60Hz and SECAM for 50Hz). I'd propose switching to some more neutral >>> naming scheme. Some ideas: >>> >>> - DRM_MODE_ANALOG_60_HZ / DRM_MODE_ANALOG_50_HZ (after standard refresh rate) >>> - DRM_MODE_ANALOG_525_LINES / DRM_MODE_ANALOG_625_LINES (after standard line >>>   count) >> >> IMHO these are bad names, as e.g. VGA640x480@60 is also analog, using >> 60 Hz and 525 lines.  Add "TV" to the name? >> >>> - DRM_MODE_ANALOG_JM / DRM_MODE_ANALOG_BDGHIKLN (after corresponding ITU System >>>   Letter Designations) >> >> Or DRM_MODE_ITU_*? >> But given the long list of letters, this looks fragile to me. > > Does it matter at all? It's an internal API that isn't exposed at all. > I'd rather have a common name that everyone can understand in this case > rather than a *perfect* name where most will scratch their head > wondering what it's about. You may have a point. But in that case, maybe it'd make sense to at least add a short comment explaining what do you mean by "NTSC" and "PAL" in this context? Best regards, Mateusz Kwiatkowski