From: D. Manresa <dmanresa@gmail.com>
To: brgl@kernel.org, bartosz.golaszewski@oss.qualcomm.com
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
driver-core@lists.linux.dev, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] driver core: fix unbalanced reference counting for software nodes
Date: Tue, 03 Nov 2026 10:19:50 -0800 (PST) [thread overview]
Message-ID: <6aea25c6.9efe04cf.11c115.259a@mx.google.com> (raw)
In-Reply-To: <20261023-swnode-dev-notify-balance-v2-0-948d920a79f6@oss.qualcomm.com>
Tested your v2 on a Surface Pro 7+, where ipu-bridge attaches the IPU's
software node with set_secondary_fwnode() after device_add(), which is
the case the series is about. Reading the node's kobject reference count
directly across a PCI remove of 0000:00:05.0:
6.19.8, unpatched: 4 bound, 3 while removed, stuck at 3
7.3 + this series: 4 bound, 4 while removed
The 4 is one registration reference plus three child port nodes. No
refcount_t, KASAN or other splats either way.
How much that covers: the rescan does not re-probe, because mainline
ipu-bridge only unregisters its IPU HID node on the error path of
ipu_bridge_init(), so the next software_node_register() hits -EEXIST.
Separate leak, unrelated to your patch, but it means only the first
cycle really exercises the fixed path.
Tested-by: D. Manresa <dmanresa@gmail.com>
Assisted-by: LLM
prev parent reply other threads:[~2026-11-03 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 10:14 [PATCH v2 0/3] driver core: fix unbalanced reference counting for software nodes Bartosz Golaszewski
2026-10-23 10:14 ` [PATCH v2 1/3] driver core: provide a test-and-clear device flag accessor Bartosz Golaszewski
2026-10-23 10:14 ` [PATCH v2 2/3] driver core: provide new device flag - DEV_FLAG_SWNODE_NOTIFIER Bartosz Golaszewski
2026-10-23 10:14 ` [PATCH v2 3/3] software node: fix unbalanced reference counting Bartosz Golaszewski
2026-11-02 20:15 ` [PATCH v2 0/3] driver core: fix unbalanced reference counting for software nodes Danilo Krummrich
2026-11-03 18:19 ` D. Manresa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aea25c6.9efe04cf.11c115.259a@mx.google.com \
--to=dmanresa@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.