All of lore.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+7ff3adde89dd795ad4c4@syzkaller.appspotmail.com>
To: drifabdelmalekmohamedsaid@gmail.com
Cc: drifabdelmalekmohamedsaid@gmail.com, dvyukov@google.com,
	glider@google.com,  jack@suse.cz, kmsan-dev@googlegroups.com,
	linux-fsdevel@vger.kernel.org,  linux-kernel@vger.kernel.org,
	syzkaller-upstream-moderation@googlegroups.com
Subject: Re: [PATCH] dm cache: fix divide error in too_many_discard_blocks()
Date: Fri, 06 Nov 2026 10:10:34 -0800	[thread overview]
Message-ID: <6aee181a.8be4ead1.3b45e1.019a.GAE@google.com> (raw)
In-Reply-To: <20261106181031.1446-1-drifabdelmalekmohamedsaid@gmail.com>

> #syz test

This crash does not have a reproducer. I cannot test it.

>
> diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
> index 1a5072425c4a..2d40d6047ef1 100644
> --- a/drivers/md/dm-cache-target.c
> +++ b/drivers/md/dm-cache-target.c
> @@ -2383,9 +2383,7 @@ static int create_cache_policy(struct cache *cache, struct cache_args *ca,
>  static bool too_many_discard_blocks(sector_t discard_block_size,
>  				    sector_t origin_size)
>  {
> -	(void) sector_div(origin_size, discard_block_size);
> -
> -	return origin_size > MAX_DISCARD_BLOCKS;
> +	return div64_u64(origin_size, discard_block_size) > MAX_DISCARD_BLOCKS;
>  }
>  
>  static sector_t calculate_discard_block_size(sector_t cache_block_size,
> -- 
> 2.43.0
>

  reply	other threads:[~2026-11-06 18:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 18:10 [PATCH] dm cache: fix divide error in too_many_discard_blocks() Drif Abdelmalek Mohamed Said
2026-11-06 18:10 ` syzbot [this message]
2026-11-06 18:10 ` syzbot
  -- strict thread matches above, loose matches on Subject: below --
2026-11-06 18:08 Drif Abdelmalek Mohamed Said
2026-11-06 18:18 ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6aee181a.8be4ead1.3b45e1.019a.GAE@google.com \
    --to=syzbot+7ff3adde89dd795ad4c4@syzkaller.appspotmail.com \
    --cc=drifabdelmalekmohamedsaid@gmail.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=jack@suse.cz \
    --cc=kmsan-dev@googlegroups.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-upstream-moderation@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.