All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aradhya Bhatia <aradhya.bhatia@linux.dev>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Jyri Sarha <jyri.sarha@iki.fi>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
	Linus Walleij <linusw@kernel.org>,
	Chaoyi Chen <chaoyi.chen@rock-chips.com>,
	Vicente Bergas <vicencb@gmail.com>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/4] Revert "drm/atomic-helper: Re-order bridge chain pre-enable and post-disable"
Date: Mon, 8 Dec 2025 11:23:17 +0000	[thread overview]
Message-ID: <6af17c1e-32fc-478a-8493-6c754c3020f0@linux.dev> (raw)
In-Reply-To: <20251205-drm-seq-fix-v1-1-fda68fa1b3de@ideasonboard.com>

Hi Tomi,

Thank you for posting this series.

It makes sense to change the order in tidss _commit_tail(), than to
undo the order changes in the regressed drivers.

On 05/12/2025 09:51, Tomi Valkeinen wrote:
> This reverts commit c9b1150a68d9362a0827609fc0dc1664c0d8bfe1.
> 
> Changing the enable/disable sequence has caused regressions on multiple
> platforms: R-Car, MCDE, Rockchip. A series (see link below)  was sent to
> fix these, but it was decided that it's better to revert the original
> patch and change the enable/disable sequence only in the tidss driver.
> 
> Reverting this commit breaks tidss's DSI and OLDI outputs, which will be
> fixed in the following commits.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Link: https://lore.kernel.org/all/20251202-mcde-drm-regression-thirdfix-v6-0-f1bffd4ec0fa%40kernel.org/
> Fixes: c9b1150a68d9 ("drm/atomic-helper: Re-order bridge chain pre-enable and post-disable")
> Cc: stable@vger.kernel.org # v6.17+
> ---
>  drivers/gpu/drm/drm_atomic_helper.c |   8 +-
>  include/drm/drm_bridge.h            | 249 ++++++++++--------------------------
>  2 files changed, 70 insertions(+), 187 deletions(-)
> 

Reviewed-by: Aradhya Bhatia <aradhya.bhatia@linux.dev>



  reply	other threads:[~2025-12-08 11:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20251205095238eucas1p1b7cf95d86a9aecf19877ac568148e265@eucas1p1.samsung.com>
2025-12-05  9:51 ` [PATCH 0/4] drm: Revert and fix enable/disable sequence Tomi Valkeinen
2025-12-05  9:51   ` [PATCH 1/4] Revert "drm/atomic-helper: Re-order bridge chain pre-enable and post-disable" Tomi Valkeinen
2025-12-08 11:23     ` Aradhya Bhatia [this message]
2025-12-05  9:51   ` [PATCH 2/4] Revert "drm/mediatek: dsi: Fix DSI host and panel bridge pre-enable order" Tomi Valkeinen
2025-12-05  9:51   ` [PATCH 3/4] drm/atomic-helper: Export and namespace some functions Tomi Valkeinen
2025-12-08 11:24     ` Aradhya Bhatia
2025-12-05  9:51   ` [PATCH 4/4] drm/tidss: Fix enable/disable order Tomi Valkeinen
2025-12-08 11:26     ` Aradhya Bhatia
2025-12-05 12:36   ` [PATCH 0/4] drm: Revert and fix enable/disable sequence Linus Walleij
2025-12-05 14:25   ` Marek Szyprowski
2025-12-08 11:06   ` Maxime Ripard
2025-12-12 14:21   ` Tomi Valkeinen
2025-12-14 11:14     ` Linus Walleij
2025-12-14 12:42       ` Tomi Valkeinen
2025-12-22 23:18         ` Linus Walleij
2025-12-23 11:48           ` Tomi Valkeinen
2026-01-03 19:12             ` Linus Walleij
2026-01-03 19:27               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6af17c1e-32fc-478a-8493-6c754c3020f0@linux.dev \
    --to=aradhya.bhatia@linux.dev \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=jyri.sarha@iki.fi \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=louisalexis.eyraud@collabora.com \
    --cc=lumag@kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    --cc=vicencb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.