All of lore.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+9c29b92a3b6500bb347d@syzkaller.appspotmail.com>
To: diasyzhangqing@gmail.com
Cc: adilger.kernel@dilger.ca, ahmadpsn95@gmail.com,
	diasyzhang@tencent.com,  diasyzhangqing@gmail.com, jack@suse.cz,
	kartikey406@gmail.com,  libaokun@linux.alibaba.com,
	linux-ext4@vger.kernel.org,  linux-kernel@vger.kernel.org,
	ojaswin@linux.ibm.com, ritesh.list@gmail.com,
	 stable@vger.kernel.org, tytso@mit.edu, yi.zhang@huawei.com,
	 syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] ext4: attach jinode before inline data conversion in setattr
Date: Sun, 15 Nov 2026 21:44:39 -0800	[thread overview]
Message-ID: <6afa9847.b64ae673.1498f1.0dc5.GAE@google.com> (raw)
In-Reply-To: <20261116054424.62067-1-diasyzhang@tencent.com>

> Commit ed9356a30e59 ("ext4: convert inline data to extents when
> truncate exceeds inline size") added inline data conversion to
> ext4_setattr(). Pathname-based truncate bypasses ext4_file_open(),
> so the inode may lack a jinode. In ordered mode, the conversion
> can pass this NULL jinode to jbd2_journal_file_inode(), causing a
> NULL pointer dereference.
>
> Attach the jinode before ext4_convert_inline_data() and propagate
> attachment errors. The attachment in ext4_truncate_up() occurs
> after the conversion and is too late.
>
> Fixes: ed9356a30e59 ("ext4: convert inline data to extents when truncate exceeds inline size")
> Reported-by: Ahmed Khan <ahmadpsn95@gmail.com>
> Link: https://lore.kernel.org/r/CAOaS1==g3mdoqmS2AjOC0_-woXJbA_X0LJQt7+M7d1=+gfyQqw@mail.gmail.com
> Reported-by: syzbot+9c29b92a3b6500bb347d@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=9c29b92a3b6500bb347d
> Cc: stable@vger.kernel.org
> Signed-off-by: Qing Zhang <diasyzhang@tencent.com>
> ---
>
> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

Patch testing via #syz test is temporarily disabled.
See https://github.com/google/syzkaller/issues/8122 for details.

>  fs/ext4/inode.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 10cd85d4c721..1e31933ae98c 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -7127,6 +7127,9 @@ int ext4_setattr(const struct mnt_idmap *idmap, struct dentry *dentry,
>  		 */
>  		if (ext4_has_inline_data(inode) &&
>  		    attr->ia_size > EXT4_I(inode)->i_inline_size) {
> +			error = ext4_inode_attach_jinode(inode);
> +			if (error)
> +				goto err_out;
>  			error = ext4_convert_inline_data(inode);
>  			if (error)
>  				goto err_out;
> -- 
> 2.43.7
>

  reply	other threads:[~2026-11-16  5:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 21:33 [syzbot] [ext4?] BUG: unable to handle kernel paging request in jbd2_journal_file_inode syzbot
2026-11-16  5:44 ` [PATCH] ext4: attach jinode before inline data conversion in setattr Qing Zhang
2026-11-16  5:44   ` syzbot [this message]
2026-11-16  5:55   ` sashiko-bot
2026-11-16 12:27   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6afa9847.b64ae673.1498f1.0dc5.GAE@google.com \
    --to=syzbot+9c29b92a3b6500bb347d@syzkaller.appspotmail.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=ahmadpsn95@gmail.com \
    --cc=diasyzhang@tencent.com \
    --cc=diasyzhangqing@gmail.com \
    --cc=jack@suse.cz \
    --cc=kartikey406@gmail.com \
    --cc=libaokun@linux.alibaba.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tytso@mit.edu \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.