From: Martin KaFai Lau <martin.lau@linux.dev>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
kernel-team <kernel-team@fb.com>, Paolo Abeni <pabeni@redhat.com>,
Joanne Koong <joannelkoong@gmail.com>,
Alexander Potapenko <glider@google.com>,
Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [PATCH net-next] net: Fix incorrect address comparison when searching for a bind2 bucket
Date: Tue, 27 Sep 2022 21:46:40 -0700 [thread overview]
Message-ID: <6afbe4af-ada1-68df-4561-ca4fb45debaf@linux.dev> (raw)
In-Reply-To: <CANn89iLdDbkFWWPh8tPp71-PNf-FY=DqODhqqQ+iUN+o2=GwYw@mail.gmail.com>
On 9/27/22 8:49 PM, Eric Dumazet wrote:
> On Mon, Sep 26, 2022 at 5:25 PM Martin KaFai Lau <kafai@fb.com> wrote:
>>
>> From: Martin KaFai Lau <martin.lau@kernel.org>
>>
>> The v6_rcv_saddr and rcv_saddr are inside a union in the
>> 'struct inet_bind2_bucket'. When searching a bucket by following the
>> bhash2 hashtable chain, eg. inet_bind2_bucket_match, it is only using
>> the sk->sk_family and there is no way to check if the inet_bind2_bucket
>> has a v6 or v4 address in the union. This leads to an uninit-value
>> KMSAN report in [0] and also potentially incorrect matches.
>
> I do not see the KMSAN report, is it missing from this changelog ?
My bad. Forgot to paste the link in the commit message. It is here:
https://lore.kernel.org/netdev/CAG_fn=Ud3zSW7AZWXc+asfMhZVL5ETnvuY44Pmyv4NPv-ijN-A@mail.gmail.com/
next prev parent reply other threads:[~2022-09-28 4:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 0:25 [PATCH net-next] net: Fix incorrect address comparison when searching for a bind2 bucket Martin KaFai Lau
2022-09-28 3:49 ` Eric Dumazet
2022-09-28 4:46 ` Martin KaFai Lau [this message]
2022-09-28 5:07 ` Eric Dumazet
2022-09-28 11:15 ` Alexander Potapenko
2022-09-29 2:20 ` patchwork-bot+netdevbpf
2023-09-08 21:54 ` Andrei Vagin
2023-09-09 7:05 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6afbe4af-ada1-68df-4561-ca4fb45debaf@linux.dev \
--to=martin.lau@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=joannelkoong@gmail.com \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.