From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] netstress: Update help for -m behavior for client and server
Date: Fri, 17 Aug 2018 14:12:07 +0300 [thread overview]
Message-ID: <6b130bd3-596a-ba85-47b4-4d9b136bb1c4@oracle.com> (raw)
In-Reply-To: <20180816172047.6281-1-pvorel@suse.cz>
On 16.08.2018 20:20, Petr Vorel wrote:
> Different udp/udp_lite behaviour for server is due no listen() call.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
Hi Petr,
> testcases/network/netstress/netstress.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/network/netstress/netstress.c b/testcases/network/netstress/netstress.c
> index acce26f00..0de3fde1a 100644
> --- a/testcases/network/netstress/netstress.c
> +++ b/testcases/network/netstress/netstress.c
> @@ -1002,12 +1002,13 @@ static struct tst_option options[] = {
> {"r:", &rarg, "-r x Number of client requests"},
> {"n:", &narg, "-n x Client message size"},
> {"N:", &Narg, "-N x Server message size"},
> - {"m:", &Targ, "-m x Reply timeout in microsec."},
> + {"m:", &Targ, "-m x Reply timeout in microsec (for udp, udp_lite, dccp is timeout always 100 microsec)"},
The timeout value not in microseconds, but in milliseconds.
What is "dccp is timeout always 100 microsec"?
> {"d:", &rpath, "-d x x is a path to file where result is saved"},
> {"A:", &Aarg, "-A x x max payload length (generated randomly)\n"},
>
> {"R:", &Rarg, "Server:\n-R x x requests after which conn.closed"},
> {"q:", &qarg, "-q x x - TFO queue"},
> + {"m:", &Targ, "-m x Connect timeout in microsec (only for udp, udp_lite)"},
This is misleading actually, connect is for the client...
Why not to stick with what we had already discussed some time ago,
something like this?
"-m x Receive timeout in milliseconds (not used by UDP/DCCP client)"
Thanks,
Alexey
> {"B:", &server_bg, "-B x run in background, x - process directory"},
> {NULL, NULL, NULL}
> };
>
next prev parent reply other threads:[~2018-08-17 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 17:20 [LTP] [PATCH 1/2] netstress: Update help for -m behavior for client and server Petr Vorel
2018-08-16 17:20 ` [LTP] [PATCH 2/2] netstress: Unifi help Petr Vorel
2018-08-16 17:23 ` Petr Vorel
2018-08-17 11:12 ` Alexey Kodanev [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-27 23:43 [LTP] [PATCH 1/2] netstress: Update help for -m behavior for client and server Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b130bd3-596a-ba85-47b4-4d9b136bb1c4@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.