From: Pavan Bobba <opensource206@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Pavan Bobba <opensource206@gmail.com>
Subject: [PATCH 06/11] staging: vt6655: Type encoding info dropped from variable name "qwNextTBTT"
Date: Tue, 31 Oct 2023 11:04:29 +0530 [thread overview]
Message-ID: <6b1fe342f7577c46a980cdc1bee0c7f560f05d87.1698730318.git.opensource206@gmail.com> (raw)
In-Reply-To: <cover.1698730318.git.opensource206@gmail.com>
variable name "qwTSFOffset" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
Signed-off-by: Pavan Bobba <opensource206@gmail.com>
---
drivers/staging/vt6655/card.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index c18cbf0aad75..e4b40125b094 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -323,19 +323,19 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
bool card_set_beacon_period(struct vnt_private *priv,
unsigned short beacon_interval)
{
- u64 qwNextTBTT;
+ u64 next_tbtt;
- qwNextTBTT = vt6655_get_current_tsf(priv); /* Get Local TSF counter */
+ next_tbtt = vt6655_get_current_tsf(priv); /* Get Local TSF counter */
- qwNextTBTT = CARDqGetNextTBTT(qwNextTBTT, beacon_interval);
+ next_tbtt = CARDqGetNextTBTT(next_tbtt, beacon_interval);
/* set HW beacon interval */
iowrite16(beacon_interval, priv->port_offset + MAC_REG_BI);
priv->beacon_interval = beacon_interval;
/* Set NextTBTT */
- qwNextTBTT = le64_to_cpu(qwNextTBTT);
- iowrite32((u32)qwNextTBTT, priv->port_offset + MAC_REG_NEXTTBTT);
- iowrite32((u32)(qwNextTBTT >> 32), priv->port_offset + MAC_REG_NEXTTBTT + 4);
+ next_tbtt = le64_to_cpu(next_tbtt);
+ iowrite32((u32)next_tbtt, priv->port_offset + MAC_REG_NEXTTBTT);
+ iowrite32((u32)(next_tbtt >> 32), priv->port_offset + MAC_REG_NEXTTBTT + 4);
vt6655_mac_reg_bits_on(priv->port_offset, MAC_REG_TFTCTL, TFTCTL_TBTTSYNCEN);
return true;
@@ -795,15 +795,15 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv,
unsigned short beacon_interval)
{
void __iomem *iobase = priv->port_offset;
- u64 qwNextTBTT;
+ u64 next_tbtt;
- qwNextTBTT = vt6655_get_current_tsf(priv); /* Get Local TSF counter */
+ next_tbtt = vt6655_get_current_tsf(priv); /* Get Local TSF counter */
- qwNextTBTT = CARDqGetNextTBTT(qwNextTBTT, beacon_interval);
+ next_tbtt = CARDqGetNextTBTT(next_tbtt, beacon_interval);
/* Set NextTBTT */
- qwNextTBTT = le64_to_cpu(qwNextTBTT);
- iowrite32((u32)qwNextTBTT, iobase + MAC_REG_NEXTTBTT);
- iowrite32((u32)(qwNextTBTT >> 32), iobase + MAC_REG_NEXTTBTT + 4);
+ next_tbtt = le64_to_cpu(next_tbtt);
+ iowrite32((u32)next_tbtt, iobase + MAC_REG_NEXTTBTT);
+ iowrite32((u32)(next_tbtt >> 32), iobase + MAC_REG_NEXTTBTT + 4);
vt6655_mac_reg_bits_on(iobase, MAC_REG_TFTCTL, TFTCTL_TBTTSYNCEN);
}
--
2.34.1
next prev parent reply other threads:[~2023-10-31 5:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 5:34 [PATCH 00/11] Type encoding info dropped from variable and function names in NIC driver part2 Pavan Bobba
2023-10-31 5:34 ` [PATCH 01/11] staging: vt6655: Type encoding info dropped from variable name "qwBSSTimestamp" Pavan Bobba
2023-10-31 5:34 ` [PATCH 02/11] staging: vt6655: Type encoding info dropped from variable name "qwTSFOffset" Pavan Bobba
2023-10-31 5:34 ` [PATCH 03/11] staging: vt6655: Type encoding info dropped from function name "CARDqGetTSFOffset" Pavan Bobba
2023-10-31 5:34 ` [PATCH 04/11] staging: vt6655: Type encoding info dropped from function name "CARDbSetBeaconPeriod" Pavan Bobba
2023-10-31 5:34 ` [PATCH 05/11] staging: vt6655: Type encoding info dropped from variable name "wBeaconInterval" Pavan Bobba
2023-10-31 5:34 ` Pavan Bobba [this message]
2023-10-31 5:34 ` [PATCH 07/11] staging: vt6655: Type encoding info dropped from function name "CARDqGetNextTBTT" Pavan Bobba
2023-10-31 5:34 ` [PATCH 08/11] staging: vt6655: Type encoding info dropped from function name "CARDbRadioPowerOff" Pavan Bobba
2023-10-31 5:34 ` [PATCH 09/11] staging: vt6655: Type encoding info dropped from function name "CARDvSafeResetTx" Pavan Bobba
2023-10-31 5:34 ` [PATCH 10/11] staging: vt6655: Type encoding info dropped from variable name "pCurrTD" Pavan Bobba
2023-10-31 5:34 ` [PATCH 11/11] staging: vt6655: Type encoding info dropped from variable name "apTailTD" Pavan Bobba
2023-11-04 11:39 ` [PATCH 00/11] Type encoding info dropped from variable and function names in NIC driver part2 Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b1fe342f7577c46a980cdc1bee0c7f560f05d87.1698730318.git.opensource206@gmail.com \
--to=opensource206@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.