Re: [igt-dev] [PATCH i-g-t] lib/intel_device_info: Add IS_DGFX() support

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: Friday, April 22, 2022 9:38 PM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>
> Cc: igt-dev@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] lib/intel_device_info: Add IS_DGFX() support
> 
> On Fri, 22 Apr 2022 05:59:12 -0700, Anshuman Gupta wrote:
> >
> > Currently IGT is lacking IS_DGFX() macro support.
> > There are some power features like D3Cold are only supported on
> > discrete card. So IGT test/tools specific to D3Cold requires to
> > consume IS_DGFX().
> > Adding a is_dgfx field in intel_device_info and initializing it for
> > DG1. All future discrete platform would require to initialize this
> > field.
> 
> #define IS_DGFX(fd) gem_has_lmem(fd) ?
> 
> gem_has_lmem() is already pretty widely used so maybe we should not
> introduce another way to achieve the same goal?
Before introducing this , I thought on using gem_has_lmem.
But I was not sure in case every discrete platform mandatory to have lmem region.
If it is guaranteed that every discrete platform will have lmem memory region ?
I will  drop  this patch.
Thanks,
Anshuman Gupta.