All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nguyen Dinh Phi [SG]" <phind.uet@gmail.com>
To: Michal Luczaj <mhal@rbox.co>, Stefano Garzarella <sgarzare@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com,
	virtualization@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout
Date: Fri, 24 Jul 2026 15:34:23 +0800	[thread overview]
Message-ID: <6b684c2f-1f98-43ea-84c9-9b6f162d5e9f@gmail.com> (raw)
In-Reply-To: <a6cb1b8f-d8cf-412a-a204-3a26e4db0bd0@rbox.co>

On 24/7/26 05:43, Michal Luczaj wrote:
> On 7/23/26 12:26, Nguyen Dinh Phi [SG] wrote:
>>>>>> ...
>>>>>> Yeah, we need to handle that part better, I think it's a leftover when
>>>>>> we generalized AF_VSOCK to support more transport than vmci.
>>>>
>>>> Speaking of leftovers, I have trouble understanding where does vsock set
>>>> sk_err on listener sockets anyway. If it doesn't, why vsock_accept()
>>>> checks for it?
>>>
>>> I can't also see where it can be set TBH. Should we remove it ?
>>
>> I couldn't find it for listener side too.
> 
> Removing sk_err handling from vsock_accept() solves the problem, right?
> 
> thanks,
> Michal

Yes, confirmed, removing sk_err checks from vsock_accept() does solve 
the problem.

Thanks,
Phi

  reply	other threads:[~2026-07-24  7:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-19 21:57 [PATCH] vsock: use sock_error() to consume sk_err after connect timeout Nguyen Dinh Phi
2026-07-20  8:17 ` Stefano Garzarella
2026-07-20 17:34   ` Phi Nguyen
2026-07-22  7:55     ` Stefano Garzarella
2026-07-23  4:14       ` Nguyen Dinh Phi [SG]
2026-07-23  6:00         ` Michal Luczaj
2026-07-23  8:24           ` Stefano Garzarella
2026-07-23 10:26             ` Nguyen Dinh Phi [SG]
2026-07-23 21:43               ` Michal Luczaj
2026-07-24  7:34                 ` Nguyen Dinh Phi [SG] [this message]
2026-07-28  8:21                   ` Stefano Garzarella
2026-07-29  9:46                     ` Nguyen Dinh Phi [SG]
2026-07-29 13:03                       ` Stefano Garzarella
2026-07-29 13:20                         ` Michal Luczaj
2026-07-29 13:29                           ` Stefano Garzarella
2026-07-29 15:49                             ` Michal Luczaj
2026-07-29 16:51                               ` Phi Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b684c2f-1f98-43ea-84c9-9b6f162d5e9f@gmail.com \
    --to=phind.uet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhal@rbox.co \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.